[ES|QL] Omits sorting non sortable fields on Discover histogram #195531
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
stratoula
changed the title
stratoula
changed the title
stratoula
added
release_note:skip
|
Pinging @elastic/kibana-data-discovery (Team:DataDiscovery) |
|
/ci |
💚 Build Succeeded
Metrics [docs]Module Count
Async chunks
History
|
drewdaemon
approved these changes
Oct 10, 2024
|
Starting backport for target branches: 8.x |
kibanamachine
pushed a commit
to kibanamachine/kibana
that referenced
this pull request
Oct 10, 2024
…tic#195531) ## Summary Closes elastic#195510 Sorting by `geo_point`, tsdb counter fields and _source is not supported in ES|QL. This PR is omitting the sorting for these types and now the breakdown works fine. <img width="2500" alt="image" src="https://github.com/user-attachments/assets/1526f516-5f8d-491d-8b77-1f9734ce83a4"> Note: This behavior is unreleased. ### Checklist - [x] [Unit or functional tests](https://www.elastic.co/guide/en/kibana/master/development-tests.html) were updated or added to match the most common scenarios (cherry picked from commit 2bb9c3c)
💚 All backports created successfully
Note: Successful backport PRs will be merged automatically after passing CI. Questions ?Please refer to the Backport tool documentation |
kibanamachine
added a commit
that referenced
this pull request
Oct 10, 2024
…#195531) (#195809) # Backport This will backport the following commits from `main` to `8.x`: - [[ES|QL] Omits sorting non sortable fields on Discover histogram (#195531)](#195531) <!--- Backport version: 9.4.3 --> ### Questions ? Please refer to the [Backport tool documentation](https://github.com/sqren/backport) <!--BACKPORT [{"author":{"name":"Stratoula Kalafateli","email":"[email protected]"},"sourceCommit":{"committedDate":"2024-10-10T17:12:29Z","message":"[ES|QL] Omits sorting non sortable fields on Discover histogram (#195531)\n\n## Summary\r\n\r\nCloses https://github.com/elastic/kibana/issues/195510\r\n\r\nSorting by `geo_point`, tsdb counter fields and _source is not supported\r\nin ES|QL. This PR is omitting the sorting for these types and now the\r\nbreakdown works fine.\r\n\r\n<img width=\"2500\" alt=\"image\"\r\nsrc=\"https://github.com/user-attachments/assets/1526f516-5f8d-491d-8b77-1f9734ce83a4\">\r\n\r\n\r\nNote: This behavior is unreleased.\r\n\r\n### Checklist\r\n- [x] [Unit or functional\r\ntests](https://www.elastic.co/guide/en/kibana/master/development-tests.html)\r\nwere updated or added to match the most common scenarios","sha":"2bb9c3cc92957faea5985169371e75197f86e407","branchLabelMapping":{"^v9.0.0$":"main","^v8.16.0$":"8.x","^v(\\d+).(\\d+).\\d+$":"$1.$2"}},"sourcePullRequest":{"labels":["Feature:Discover","release_note:skip","v9.0.0","Team:DataDiscovery","backport:prev-minor","v8.16.0"],"title":"[ES|QL] Omits sorting non sortable fields on Discover histogram","number":195531,"url":"https://github.com/elastic/kibana/pull/195531","mergeCommit":{"message":"[ES|QL] Omits sorting non sortable fields on Discover histogram (#195531)\n\n## Summary\r\n\r\nCloses https://github.com/elastic/kibana/issues/195510\r\n\r\nSorting by `geo_point`, tsdb counter fields and _source is not supported\r\nin ES|QL. This PR is omitting the sorting for these types and now the\r\nbreakdown works fine.\r\n\r\n<img width=\"2500\" alt=\"image\"\r\nsrc=\"https://github.com/user-attachments/assets/1526f516-5f8d-491d-8b77-1f9734ce83a4\">\r\n\r\n\r\nNote: This behavior is unreleased.\r\n\r\n### Checklist\r\n- [x] [Unit or functional\r\ntests](https://www.elastic.co/guide/en/kibana/master/development-tests.html)\r\nwere updated or added to match the most common scenarios","sha":"2bb9c3cc92957faea5985169371e75197f86e407"}},"sourceBranch":"main","suggestedTargetBranches":["8.x"],"targetPullRequestStates":[{"branch":"main","label":"v9.0.0","branchLabelMappingKey":"^v9.0.0$","isSourceBranch":true,"state":"MERGED","url":"https://github.com/elastic/kibana/pull/195531","number":195531,"mergeCommit":{"message":"[ES|QL] Omits sorting non sortable fields on Discover histogram (#195531)\n\n## Summary\r\n\r\nCloses https://github.com/elastic/kibana/issues/195510\r\n\r\nSorting by `geo_point`, tsdb counter fields and _source is not supported\r\nin ES|QL. This PR is omitting the sorting for these types and now the\r\nbreakdown works fine.\r\n\r\n<img width=\"2500\" alt=\"image\"\r\nsrc=\"https://github.com/user-attachments/assets/1526f516-5f8d-491d-8b77-1f9734ce83a4\">\r\n\r\n\r\nNote: This behavior is unreleased.\r\n\r\n### Checklist\r\n- [x] [Unit or functional\r\ntests](https://www.elastic.co/guide/en/kibana/master/development-tests.html)\r\nwere updated or added to match the most common scenarios","sha":"2bb9c3cc92957faea5985169371e75197f86e407"}},{"branch":"8.x","label":"v8.16.0","branchLabelMappingKey":"^v8.16.0$","isSourceBranch":false,"state":"NOT_CREATED"}]}] BACKPORT--> Co-authored-by: Stratoula Kalafateli <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Closes #195510
Sorting by
geo_point, tsdb counter fields and _source is not supported in ES|QL. This PR is omitting the sorting for these types and now the breakdown works fine.Note: This behavior is unreleased.
Checklist