Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Updates load-json-file dependency to 7.0.1 and handles changes #195522

Closed
wants to merge 1 commit into from
Closed

Updates load-json-file dependency to 7.0.1 and handles changes #195522

wants to merge 1 commit into from

Conversation

TinaHeiligers
Copy link
Contributor

loadJsonFile.sync changed to loadJsonFileSync in 7.0.1. The async API didn't change.

6.2.0 APIs
7.0.1 APIs

@TinaHeiligers TinaHeiligers added chore Team:Core Core services & architecture: plugins, logging, config, saved objects, http, ES client, i18n, etc release_note:skip Skip the PR/issue when compiling release notes backport:prev-minor Backport to (8.x) the previous minor version (i.e. one version back from main) labels Oct 8, 2024
@TinaHeiligers TinaHeiligers requested review from a team as code owners October 8, 2024 23:57
@elasticmachine
Copy link
Contributor

Pinging @elastic/kibana-core (Team:Core)

@elasticmachine
Copy link
Contributor

elasticmachine commented Oct 9, 2024 •
edited
Loading

💔 Build Failed

Failed CI Steps

Test Failures

  • [job] [logs] Jest Integration Tests #5 / cli invalid config support exits with statusCode 64 and logs an error when config is invalid
  • [job] [logs] Jest Integration Tests #5 / cli invalid config support exits with statusCode 64 and logs an error when config is invalid
  • [job] [logs] Jest Tests #2 / correctly creates default environment if --env.name is supplied.
  • [job] [logs] Jest Tests #2 / correctly creates default environment if --env.name is supplied.
  • [job] [logs] Jest Tests #2 / correctly creates default environment in dev mode.
  • [job] [logs] Jest Tests #2 / correctly creates default environment in dev mode.
  • [job] [logs] Jest Tests #2 / correctly creates default environment in prod distributable mode.
  • [job] [logs] Jest Tests #2 / correctly creates default environment in prod distributable mode.
  • [job] [logs] Jest Tests #2 / correctly creates default environment in prod non-distributable mode.
  • [job] [logs] Jest Tests #2 / correctly creates default environment in prod non-distributable mode.
  • [job] [logs] Jest Integration Tests #2 / migrator-only node starts Kibana, runs migrations and then exits with a "0" status code
  • [job] [logs] Jest Integration Tests #2 / migrator-only node starts Kibana, runs migrations and then exits with a "0" status code
  • [job] [logs] Jest Tests #2 / packageInfo.buildFlavor is set to serverless when the serverless cli flag is true
  • [job] [logs] Jest Tests #2 / packageInfo.buildFlavor is set to serverless when the serverless cli flag is true
  • [job] [logs] Jest Tests #2 / packageInfo.buildFlavor is set to traditional when the serverless cli flag is false
  • [job] [logs] Jest Tests #2 / packageInfo.buildFlavor is set to traditional when the serverless cli flag is false
  • [job] [logs] Jest Tests #4 / plugins discovery system discovers plugins in nested directories
  • [job] [logs] Jest Tests #4 / plugins discovery system discovers plugins in nested directories
  • [job] [logs] Jest Tests #4 / plugins discovery system discovers plugins in the search locations
  • [job] [logs] Jest Tests #4 / plugins discovery system discovers plugins in the search locations
  • [job] [logs] Jest Tests #4 / plugins discovery system discovery order returns the plugins in a deterministic order
  • [job] [logs] Jest Tests #4 / plugins discovery system discovery order returns the plugins in a deterministic order
  • [job] [logs] Jest Tests #4 / plugins discovery system does not discover plugins nested inside another plugin
  • [job] [logs] Jest Tests #4 / plugins discovery system does not discover plugins nested inside another plugin
  • [job] [logs] Jest Tests #4 / plugins discovery system does not log a warning about --plugin-path when used in production
  • [job] [logs] Jest Tests #4 / plugins discovery system does not log a warning about --plugin-path when used in production
  • [job] [logs] Jest Tests #4 / plugins discovery system logs a warning about --plugin-path when used in development
  • [job] [logs] Jest Tests #4 / plugins discovery system logs a warning about --plugin-path when used in development
  • [job] [logs] Jest Tests #4 / plugins discovery system plugin packages filters repoPackages in the env and converts them to PluginWrappers
  • [job] [logs] Jest Tests #4 / plugins discovery system plugin packages filters repoPackages in the env and converts them to PluginWrappers
  • [job] [logs] Jest Tests #4 / plugins discovery system return an error when the manifest file is not accessible
  • [job] [logs] Jest Tests #4 / plugins discovery system return an error when the manifest file is not accessible
  • [job] [logs] Jest Tests #4 / plugins discovery system return errors when the manifest is invalid or incompatible
  • [job] [logs] Jest Tests #4 / plugins discovery system return errors when the manifest is invalid or incompatible
  • [job] [logs] Jest Tests #4 / plugins discovery system return errors when the plugin search path is missing
  • [job] [logs] Jest Tests #4 / plugins discovery system return errors when the plugin search path is missing
  • [job] [logs] Jest Tests #4 / plugins discovery system return errors when the plugin search path is not accessible
  • [job] [logs] Jest Tests #4 / plugins discovery system return errors when the plugin search path is not accessible
  • [job] [logs] Jest Tests #4 / plugins discovery system stops scanning when reaching maxDepth
  • [job] [logs] Jest Tests #4 / plugins discovery system stops scanning when reaching maxDepth
  • [job] [logs] Jest Tests #4 / plugins discovery system works with symlinks
  • [job] [logs] Jest Tests #4 / plugins discovery system works with symlinks
  • [job] [logs] Jest Tests #12 / query tab with unified timeline Leading actions - notes securitySolutionNotesEnabled = true should have the notification dot & correct tooltip
  • [job] [logs] Jest Tests #2 / When using useConsoleActionSubmitter() hook should store action details api error

Metrics [docs]

✅ unchanged

History

@TinaHeiligers
Copy link
Contributor Author

moving this to draft to sort CI failures

@TinaHeiligers TinaHeiligers marked this pull request as draft October 9, 2024 00:48
@elasticmachine
Copy link
Contributor

🤖 Jobs for this PR can be triggered through checkboxes. 🚧

ℹ️ To trigger the CI, please tick the checkbox below 👇

  • Click to trigger kibana-pull-request for this PR!

@TinaHeiligers
Copy link
Contributor Author

There aren't any security vulnerabilities requiring an update to the package.
The dependency uses import, causing CI FTR to throw `'ERR_REQUIRE_ESM'. Closing as not doing.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
backport:prev-minor Backport to (8.x) the previous minor version (i.e. one version back from main) chore release_note:skip Skip the PR/issue when compiling release notes Team:Core Core services & architecture: plugins, logging, config, saved objects, http, ES client, i18n, etc
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@TinaHeiligers @elasticmachine