Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[WIP] Fix DSL custom filters #195470

Draft
wants to merge 31 commits into
base: main
Choose a base branch
from

Conversation

markov00
Copy link
Member

@markov00 markov00 commented Oct 8, 2024

Summary

Testing DSL custom filters fix

@markov00 markov00 added the WIP Work in progress label Oct 8, 2024
@elasticmachine
Copy link
Contributor

elasticmachine commented Oct 8, 2024

🤖 Jobs for this PR can be triggered through checkboxes. 🚧

ℹ️ To trigger the CI, please tick the checkbox below 👇

  • Click to trigger kibana-pull-request for this PR!

@elasticmachine
Copy link
Contributor

elasticmachine commented Oct 8, 2024

💔 Build Failed

Failed CI Steps

Test Failures

  • [job] [logs] Jest Tests #16 / combineQueryAndFilters should accept multiple queries (and play nice with meta filters)
  • [job] [logs] Jest Tests #16 / combineQueryAndFilters should accept multiple queries (and play nice with meta filters)
  • [job] [logs] Jest Tests #16 / combineQueryAndFilters should add ignored filters as disabled
  • [job] [logs] Jest Tests #16 / combineQueryAndFilters should add ignored filters as disabled
  • [job] [logs] Jest Tests #16 / combineQueryAndFilters should append lucene meta filters to an existing lucene query
  • [job] [logs] Jest Tests #16 / combineQueryAndFilters should append lucene meta filters to an existing lucene query
  • [job] [logs] Jest Tests #16 / combineQueryAndFilters should append lucene meta filters to app filters even if existing filters are using kuery
  • [job] [logs] Jest Tests #16 / combineQueryAndFilters should append lucene meta filters to app filters even if existing filters are using kuery
  • [job] [logs] Jest Tests #16 / combineQueryAndFilters should assign kuery meta filters to app filters if existing query is using lucene language
  • [job] [logs] Jest Tests #16 / combineQueryAndFilters should assign kuery meta filters to app filters if existing query is using lucene language
  • [job] [logs] Jest Tests #16 / combineQueryAndFilters should work for complex cases of nested meta filters
  • [job] [logs] Jest Tests #16 / combineQueryAndFilters should work for complex cases of nested meta filters
  • [job] [logs] Jest Tests #16 / combineQueryAndFilters should work for prefix wildcard in disabled KQL filter
  • [job] [logs] Jest Tests #16 / combineQueryAndFilters should work for prefix wildcard in disabled KQL filter
  • [job] [logs] Jest Tests #16 / combineQueryAndFilters should work together with enabled and disabled filters
  • [job] [logs] Jest Tests #16 / combineQueryAndFilters should work together with enabled and disabled filters
  • [job] [logs] FTR Configs #16 / discover/ccs_compatible discover search errors exception on single shard shows warning and results
  • [job] [logs] FTR Configs #90 / discover/ccs_compatible discover search errors exception on single shard shows warning and results
  • [job] [logs] FTR Configs #16 / discover/ccs_compatible discover search errors exception on single shard shows warning and results
  • [job] [logs] FTR Configs #90 / discover/ccs_compatible discover search errors exception on single shard shows warning and results
  • [job] [logs] Jest Tests #17 / ruleActionsAlertsFilter should allow for changing query
  • [job] [logs] Jest Tests #17 / ruleActionsAlertsFilter should allow for changing query
  • [job] [logs] Jest Tests #11 / SearchBar sets filterManager filters correctly
  • [job] [logs] Jest Tests #11 / SearchBar sets filterManager filters correctly
  • [job] [logs] Jest Tests #11 / SearchBar updates filters correctly
  • [job] [logs] Jest Tests #11 / SearchBar updates filters correctly
  • [job] [logs] Jest Tests #7 / Template fields renders template fields correctly

Metrics [docs]

Async chunks

Total size of all lazy-loaded chunks that will be downloaded as the user navigates the app

id before after diff
alerting 93.6KB 93.7KB +36.0B
triggersActionsUi 1.6MB 1.6MB +74.0B
unifiedSearch 348.0KB 348.2KB +198.0B
total +308.0B

Page load bundle

Size of the bundles that are downloaded on every page load. Target size is below 100kb

id before after diff
kbnUiSharedDeps-srcJs 3.4MB 3.4MB -10.0B
triggersActionsUi 123.3KB 123.3KB +36.0B
total +26.0B

History

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
WIP Work in progress
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants