[Security GenAI] Remove assistantBedrockChat feature flag
#195461
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
stephmilovic
added
release_note:fix
v9.0.0
Team: SecuritySolution
|
Pinging @elastic/security-solution (Team: SecuritySolution) |
|
@elasticmachine merge upstream |
⏳ Build in-progress, with failures
Failed CI StepsTest Failures
History
|
|
@elasticmachine merge upstream |
| @@ -164,41 +154,6 @@ export const streamGraph = async ({ | |||
| } | |||
| } | |||
| } | |||
| if (event.name === 'ActionsClientSimpleChatModel') { | |||
patrykkopycinski
approved these changes
Oct 8, 2024
💚 Build Succeeded
Metrics [docs]Async chunks
Page load bundle
History
|
|
Starting backport for target branches: 8.x |
💔 All backports failed
Manual backportTo create the backport manually run: Questions ?Please refer to the Backport tool documentation |
💚 All backports created successfully
Note: Successful backport PRs will be merged automatically after passing CI. Questions ?Please refer to the Backport tool documentation |
stephmilovic
added a commit
that referenced
this pull request
Oct 9, 2024
…95461) (#195516) # Backport This will backport the following commits from `main` to `8.x`: - [[Security GenAI] Remove `assistantBedrockChat` feature flag (#195461)](#195461) <!--- Backport version: 8.9.8 --> ### Questions ? Please refer to the [Backport tool documentation](https://github.com/sqren/backport) <!--BACKPORT [{"author":{"name":"Steph Milovic","email":"[email protected]"},"sourceCommit":{"committedDate":"2024-10-08T22:31:05Z","message":"[Security GenAI] Remove `assistantBedrockChat` feature flag (#195461)","sha":"38d0bdd3deeb72ca4e502361fb0df1f68fa7f443","branchLabelMapping":{"^v9.0.0$":"main","^v8.16.0$":"8.x","^v(\\d+).(\\d+).\\d+$":"$1.$2"}},"sourcePullRequest":{"labels":["release_note:fix","v9.0.0","Team: SecuritySolution","backport:prev-minor","Team:Security Generative AI","v8.16.0"],"number":195461,"url":"https://github.com/elastic/kibana/pull/195461","mergeCommit":{"message":"[Security GenAI] Remove `assistantBedrockChat` feature flag (#195461)","sha":"38d0bdd3deeb72ca4e502361fb0df1f68fa7f443"}},"sourceBranch":"main","suggestedTargetBranches":["8.x"],"targetPullRequestStates":[{"branch":"main","label":"v9.0.0","labelRegex":"^v9.0.0$","isSourceBranch":true,"state":"MERGED","url":"https://github.com/elastic/kibana/pull/195461","number":195461,"mergeCommit":{"message":"[Security GenAI] Remove `assistantBedrockChat` feature flag (#195461)","sha":"38d0bdd3deeb72ca4e502361fb0df1f68fa7f443"}},{"branch":"8.x","label":"v8.16.0","labelRegex":"^v8.16.0$","isSourceBranch":false,"state":"NOT_CREATED"}]}] BACKPORT--> Co-authored-by: Elastic Machine <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
The
assistantBedrockChatfeature flag was never properly implemented. It was set totrueby default, with the assumption that adding it tokibana.dev.ymlwould switch it tofalse. However, we've since learned feature flags can only go fromfalsetotrue. Therefore, whenassistantBedrockChatwas introduced in 8.15 it was always set totrue. We are keeping the truthy paths in place and removing the flag in this PR.assistantBedrockChatfeature flagActionsClientSimpleChatModelfromx-pack/plugins/elastic_assistantdefault_assistant_graph/helpers.ts