-
Notifications
You must be signed in to change notification settings - Fork 8.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[OneDiscover] Contextual App Menu Extension Point #195448
Merged
jughosta
merged 79 commits into
elastic:main
from
jughosta:194269-app-menu-extension-point
Oct 30, 2024
Merged
Changes from 56 commits
Commits
Show all changes
79 commits
Select commit
Hold shift + click to select a range
f8f2b0d
[Discover] Initial implementation
jughosta 6cf8d90
[CI] Auto-commit changed files from 'node scripts/notice'
kibanamachine 2e96f8d
[Discover] Refactor further
jughosta 39c67a1
Merge remote-tracking branch 'origin/194269-app-menu-extension-point'…
jughosta 1a2ba08
[Discover] Extract actions
jughosta 80bcf51
[CI] Auto-commit changed files from 'node scripts/notice'
kibanamachine 0197f7a
[Discover] Fix test ids
jughosta 96dda65
Merge remote-tracking branch 'origin/194269-app-menu-extension-point'…
jughosta 8fbc4da
[Discover] Fix circular deps
jughosta b3cab7c
[CI] Auto-commit changed files from 'node scripts/notice'
kibanamachine 37f5ce3
[Discover] Fix circular deps
jughosta e4b0296
[CI] Auto-commit changed files from 'node scripts/notice'
kibanamachine 16756e5
[Discover] Start using icons for the primary actions
davismcphee 4363ece
Merge remote-tracking branch 'origin/194269-app-menu-extension-point'…
jughosta 0c89b3e
[Discover] Avoid the circular deps
jughosta 53bacc1
[Discover] Clean up unused customization option
jughosta 4666a4d
[CI] Auto-commit changed files from 'node scripts/notice'
kibanamachine 0b6c159
[Discover] Add a registry
jughosta 73e1ace
Merge remote-tracking branch 'origin/194269-app-menu-extension-point'…
jughosta df1b0dd
[Discover] Commit the registry
jughosta 36a4514
[Discover] Fix lint issues
jughosta 0817e7a
[Discover] Introduce the new extension point
jughosta 4270bf9
[Discover] Update tests
jughosta e8f5da4
[Discover] Fix checks
jughosta a5a5474
[Discover] Add to the example profile
jughosta 1c88df4
[Discover] Update types
jughosta 3720043
[Discover] Make types stricter
jughosta e387f50
[Discover] Update types
jughosta 48faa35
[Discover] Add horizontal rule support
jughosta 82deba6
[Discover] Add comments
jughosta a388627
Merge branch 'main' into 194269-app-menu-extension-point
jughosta ab3c171
[Discover] Change how submenu items are registered
jughosta 4ee6153
[Discover] Limit number of custom items
jughosta 12a92f2
Merge remote-tracking branch 'upstream/main' into 194269-app-menu-ext…
jughosta 3dde34b
[Discover] Update share icon
jughosta 2f76f87
[Discover] Update tooltip delay
jughosta 9863d8c
[Discover] Update top nav gap
jughosta c129bf4
Merge branch 'main' into 194269-app-menu-extension-point
jughosta fa0372f
[Discover] Add top nav tests
jughosta c909227
[Discover] Add app menu registry tests
jughosta 934359c
[Discover] Add more tests
jughosta c0a405b
[Discover] Add more tests
jughosta e7964f0
[Discover] Add e2e tests
jughosta dbd897d
[Discover] Add comment
jughosta 179290f
[Discover] Fix tests
jughosta 5b84058
Merge branch 'main' into 194269-app-menu-extension-point
jughosta b8f2868
[Discover] Fix tests
jughosta f36b74b
Merge remote-tracking branch 'origin/194269-app-menu-extension-point'…
jughosta 4e8580d
Merge branch 'main' into 194269-app-menu-extension-point
jughosta 8ed5792
[Discover] Update tests
jughosta 25466dc
Merge branch 'main' into 194269-app-menu-extension-point
jughosta f3aa321
Merge remote-tracking branch 'origin/194269-app-menu-extension-point'…
jughosta 33edf76
[Discover] Update tests
jughosta 6f0210b
Merge branch 'main' into 194269-app-menu-extension-point
jughosta fecdaad
[Discover] Fix getSortedItems
jughosta b4586c8
[Discover] Remove memo
jughosta 750e281
Merge branch 'main' into 194269-app-menu-extension-point
jughosta 092c450
[Discover] Simplify badges
jughosta a958803
[Discover] Switch to discoverParams
jughosta ecefecc
Update src/plugins/discover/public/context_awareness/types.ts
jughosta 72df414
[Discover] Add serverless tests
jughosta c889492
Merge remote-tracking branch 'origin/194269-app-menu-extension-point'…
jughosta c9377cd
[Discover] Fix clearing the items on data view change
jughosta bbe7dc7
[Discover] Update serverless tests
jughosta 81f5794
[Discover] Update example labels
jughosta 3a530e9
[Discover] Allow to add icons to submenu items
jughosta 2f7a0ae
[Discover] Fix types
jughosta db648d1
[Discover] Update tests
jughosta fb84ca9
[Discover] Update types
jughosta 0970bd5
[Discover] Update tests
jughosta c041657
[Discover] Remove services from the extension params
jughosta 5c5c983
[Discover] Update tests
jughosta 814a654
[Discover] Allow to override submenu actions with custom ones
jughosta 24e9c5c
[Discover] Fix types
jughosta 2c3b1c7
[Discover] Fix types
jughosta 91da211
Merge remote-tracking branch 'upstream/main' into 194269-app-menu-ext…
jughosta d918635
[Discover] Fix after the merge
jughosta bf13cb4
Merge branch 'main' into 194269-app-menu-extension-point
jughosta 79982bd
Merge branch 'main' into 194269-app-menu-extension-point
jughosta File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
131 changes: 131 additions & 0 deletions
131
...s/kbn-discover-utils/src/components/app_menu/__snapshots__/app_menu_registry.test.ts.snap
Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.
Oops, something went wrong.
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Reduced the scope of Discover customization (deleted
order
andgetMenuItems
configuration) as it was not used anyway and we will offer only contextual profiles going forward.