Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Docs][Maps] Update EMS Server instructions #195419

Merged
merged 3 commits into from
Oct 10, 2024

Conversation

jsanz
Copy link
Member

@jsanz jsanz commented Oct 8, 2024

Summary

Small improvements to the Elastic Maps Service documentation:

  • fixes the reference to the Docker image to pull
  • adds details about using cosign to verify the image pulled
  • updates the screenshot to a more recent UI.

@jsanz jsanz added Team:Presentation Presentation Team for Dashboard, Input Controls, and Canvas release_note:skip Skip the PR/issue when compiling release notes docs backport:prev-minor Backport to (8.x) the previous minor version (i.e. one version back from main) Feature:Maps labels Oct 8, 2024
Copy link
Contributor

github-actions bot commented Oct 8, 2024

A documentation preview will be available soon.

Request a new doc build by commenting
  • Rebuild this PR: run docs-build
  • Rebuild this PR and all Elastic docs: run docs-build rebuild

run docs-build is much faster than run docs-build rebuild. A rebuild should only be needed in rare situations.

If your PR continues to fail for an unknown reason, the doc build pipeline may be broken. Elastic employees can check the pipeline status here.

@elasticmachine
Copy link
Contributor

💚 Build Succeeded

History

@jsanz jsanz requested a review from a team October 10, 2024 15:30
@jsanz jsanz marked this pull request as ready for review October 10, 2024 15:33
@elasticmachine
Copy link
Contributor

Pinging @elastic/kibana-presentation (Team:Presentation)

endif::[]

ifeval::["{release-state}"!="unreleased"]

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Removing this ifeval conditional now displays the docker pull and start docker commands even though the image is not available yet. Is that intentional?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes, this aligns the installation instructions with Kibana, from our current preview

https://kibana_bk_195419.docs-preview.app.elstc.co/guide/en/kibana/master/docker.html

@nreese nreese requested review from nreese and a team and removed request for nreese October 10, 2024 15:40
Copy link
Member

@nickpeihl nickpeihl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

docs changes lgtm!

@jsanz jsanz merged commit ad8cec1 into elastic:main Oct 10, 2024
9 checks passed
@jsanz jsanz deleted the docs/ems/docker-versions branch October 10, 2024 19:02
@kibanamachine
Copy link
Contributor

Starting backport for target branches: 8.x

https://github.com/elastic/kibana/actions/runs/11280343351

kibanamachine pushed a commit to kibanamachine/kibana that referenced this pull request Oct 10, 2024
## Summary

Small improvements to the Elastic Maps Service documentation:

* fixes the reference to the Docker image to pull
* adds details about using `cosign` to verify the image pulled
* updates the screenshot to a more recent UI.

(cherry picked from commit ad8cec1)
@kibanamachine
Copy link
Contributor

💚 All backports created successfully

Status Branch Result
8.x

Note: Successful backport PRs will be merged automatically after passing CI.

Questions ?

Please refer to the Backport tool documentation

kibanamachine added a commit that referenced this pull request Oct 10, 2024
# Backport

This will backport the following commits from `main` to `8.x`:
- [[Docs][Maps] Update EMS Server instructions
(#195419)](#195419)

<!--- Backport version: 9.4.3 -->

### Questions ?
Please refer to the [Backport tool
documentation](https://github.com/sqren/backport)

<!--BACKPORT [{"author":{"name":"Jorge
Sanz","email":"[email protected]"},"sourceCommit":{"committedDate":"2024-10-10T19:02:23Z","message":"[Docs][Maps]
Update EMS Server instructions (#195419)\n\n## Summary\n\nSmall
improvements to the Elastic Maps Service documentation:\n\n* fixes the
reference to the Docker image to pull\n* adds details about using
`cosign` to verify the image pulled \n* updates the screenshot to a more
recent
UI.","sha":"ad8cec13b6ebb8270dd91fc4012ed8ff2b531353","branchLabelMapping":{"^v9.0.0$":"main","^v8.16.0$":"8.x","^v(\\d+).(\\d+).\\d+$":"$1.$2"}},"sourcePullRequest":{"labels":["Team:Presentation","release_note:skip","v9.0.0","docs","backport:prev-minor","Feature:Maps"],"title":"[Docs][Maps]
Update EMS Server
instructions","number":195419,"url":"https://github.com/elastic/kibana/pull/195419","mergeCommit":{"message":"[Docs][Maps]
Update EMS Server instructions (#195419)\n\n## Summary\n\nSmall
improvements to the Elastic Maps Service documentation:\n\n* fixes the
reference to the Docker image to pull\n* adds details about using
`cosign` to verify the image pulled \n* updates the screenshot to a more
recent
UI.","sha":"ad8cec13b6ebb8270dd91fc4012ed8ff2b531353"}},"sourceBranch":"main","suggestedTargetBranches":[],"targetPullRequestStates":[{"branch":"main","label":"v9.0.0","branchLabelMappingKey":"^v9.0.0$","isSourceBranch":true,"state":"MERGED","url":"https://github.com/elastic/kibana/pull/195419","number":195419,"mergeCommit":{"message":"[Docs][Maps]
Update EMS Server instructions (#195419)\n\n## Summary\n\nSmall
improvements to the Elastic Maps Service documentation:\n\n* fixes the
reference to the Docker image to pull\n* adds details about using
`cosign` to verify the image pulled \n* updates the screenshot to a more
recent UI.","sha":"ad8cec13b6ebb8270dd91fc4012ed8ff2b531353"}}]}]
BACKPORT-->

Co-authored-by: Jorge Sanz <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backport:prev-minor Backport to (8.x) the previous minor version (i.e. one version back from main) docs Feature:Maps release_note:skip Skip the PR/issue when compiling release notes Team:Presentation Presentation Team for Dashboard, Input Controls, and Canvas v8.16.0 v9.0.0
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants