Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Sustainable Kibana Architecture] Update plugins (wave #1) #195375

Merged

Conversation

gsoldevila
Copy link
Contributor

@gsoldevila gsoldevila commented Oct 8, 2024

Summary

Follow-up of #195367
As part of the Sustainable Kibana Architecture initiative, this PR leverages the mechanisms and concepts introduced in #194810, updating plugins that were considered to be solution-specific in Luke's PoC.

This might trigger linting rule violations in CI, and help uncover conflicts related to forbidden dependencies.
As soon as they are resolved, we can proceed to classify solutions' plugins.

@gsoldevila gsoldevila added Team:Core Core services & architecture: plugins, logging, config, saved objects, http, ES client, i18n, etc release_note:skip Skip the PR/issue when compiling release notes backport:skip This commit does not require backporting labels Oct 8, 2024
@gsoldevila gsoldevila force-pushed the kbn-team-1066-move-solutions-plugins branch 3 times, most recently from e591ea3 to a9a3879 Compare October 16, 2024 09:45
@gsoldevila gsoldevila force-pushed the kbn-team-1066-move-solutions-plugins branch 4 times, most recently from c833e6a to 73f8098 Compare October 23, 2024 19:17
@gsoldevila gsoldevila changed the title Sustainable Kibana Architecture - Update solutions plugins Sustainable Kibana Architecture - Update plugins (wave #1) Oct 23, 2024
@gsoldevila gsoldevila changed the title Sustainable Kibana Architecture - Update plugins (wave #1) [Sustainable Kibana Architecture] Update plugins (wave #1) Oct 23, 2024
@gsoldevila gsoldevila marked this pull request as ready for review October 23, 2024 19:51
@gsoldevila gsoldevila requested review from a team as code owners October 23, 2024 19:51
@elasticmachine
Copy link
Contributor

Pinging @elastic/kibana-core (Team:Core)

@botelastic botelastic bot added ci:project-deploy-observability Create an Observability project Feature:Drilldowns Embeddable panel Drilldowns Feature:Embedding Embedding content via iFrame Feature:ExpressionLanguage Interpreter expression language (aka canvas pipeline) Team:Fleet Team label for Observability Data Collection Fleet team Team:Obs AI Assistant Observability AI Assistant Team:obs-ux-infra_services Observability Infrastructure & Services User Experience Team Team:obs-ux-management Observability Management User Experience Team labels Oct 24, 2024
@elasticmachine
Copy link
Contributor

Pinging @elastic/obs-ai-assistant (Team:Obs AI Assistant)

@elasticmachine
Copy link
Contributor

Pinging @elastic/obs-ux-management-team (Team:obs-ux-management)

@elasticmachine
Copy link
Contributor

Pinging @elastic/fleet (Team:Fleet)

@elasticmachine
Copy link
Contributor

Pinging @elastic/obs-ux-infra_services-team (Team:obs-ux-infra_services)

@gsoldevila gsoldevila force-pushed the kbn-team-1066-move-solutions-plugins branch from b662149 to 6b79b88 Compare October 25, 2024 09:53
@elasticmachine
Copy link
Contributor

elasticmachine commented Oct 25, 2024

💚 Build Succeeded

Metrics [docs]

✅ unchanged

History

  • 💚 Build #245497 succeeded f281a577cf0bd2590d2b43fd9ce94c1817dcc26d
  • 💔 Build #245444 failed 9905174fcf83b3e801d8e6b26cf2c7cc360c6764
  • 💔 Build #245311 failed bb1363ed49683b41122cf50efa3abf3a2d0174c3
  • 💔 Build #245138 failed c833e6a64644d96ab605e22caa5ed034c49a0a33
  • 💔 Build #244633 failed 5537bfc18864bda3440eee451c0e99cb19fe419a

@gsoldevila gsoldevila merged commit a5517d9 into elastic:main Oct 25, 2024
58 checks passed
@gsoldevila gsoldevila added backport:prev-minor Backport to (8.x) the previous minor version (i.e. one version back from main) and removed backport:skip This commit does not require backporting labels Nov 7, 2024
@kibanamachine
Copy link
Contributor

Starting backport for target branches: 8.x

https://github.com/elastic/kibana/actions/runs/11719808995

@kibanamachine
Copy link
Contributor

Starting backport for target branches: 8.x

https://github.com/elastic/kibana/actions/runs/11719808951

@kibanamachine
Copy link
Contributor

💔 All backports failed

Status Branch Result
8.x Backport failed because of merge conflicts

Manual backport

To create the backport manually run:

node scripts/backport --pr 195375

Questions ?

Please refer to the Backport tool documentation

gsoldevila added a commit to gsoldevila/kibana that referenced this pull request Nov 7, 2024
…95375)

## Summary

Follow-up of elastic#195367
As part of the Sustainable Kibana Architecture initiative, this PR
leverages the mechanisms and concepts introduced in
elastic#194810, updating plugins that
were considered to be solution-specific in Luke's
[PoC](elastic#179710).

This might trigger linting rule violations in CI, and help uncover
conflicts related to forbidden dependencies.
As soon as they are resolved, we can proceed to classify solutions'
plugins.

(cherry picked from commit a5517d9)

# Conflicts:
#	src/plugins/maps_ems/kibana.jsonc
#	x-pack/plugins/file_upload/kibana.jsonc
#	x-pack/plugins/maps/kibana.jsonc
@gsoldevila
Copy link
Contributor Author

💚 All backports created successfully

Status Branch Result
8.x

Note: Successful backport PRs will be merged automatically after passing CI.

Questions ?

Please refer to the Backport tool documentation

@kibanamachine
Copy link
Contributor

💔 All backports failed

Status Branch Result
8.x Backport failed because of merge conflicts

Manual backport

To create the backport manually run:

node scripts/backport --pr 195375

Questions ?

Please refer to the Backport tool documentation

gsoldevila added a commit to gsoldevila/kibana that referenced this pull request Nov 7, 2024
…95375)

## Summary

Follow-up of elastic#195367
As part of the Sustainable Kibana Architecture initiative, this PR
leverages the mechanisms and concepts introduced in
elastic#194810, updating plugins that
were considered to be solution-specific in Luke's
[PoC](elastic#179710).

This might trigger linting rule violations in CI, and help uncover
conflicts related to forbidden dependencies.
As soon as they are resolved, we can proceed to classify solutions'
plugins.

(cherry picked from commit a5517d9)

# Conflicts:
#	src/plugins/maps_ems/kibana.jsonc
#	x-pack/plugins/file_upload/kibana.jsonc
#	x-pack/plugins/maps/kibana.jsonc
@kibanamachine
Copy link
Contributor

Looks like this PR has a backport PR but it still hasn't been merged. Please merge it ASAP to keep the branches relatively in sync.

@kibanamachine kibanamachine added the backport missing Added to PRs automatically when the are determined to be missing a backport. label Nov 8, 2024
gsoldevila added a commit that referenced this pull request Nov 8, 2024
…5375) (#199268)

# Backport

This will backport the following commits from `main` to `8.x`:
- [[Sustainable Kibana Architecture] Update plugins (wave #1)
(#195375)](#195375)

<!--- Backport version: 8.9.8 -->

### Questions ?
Please refer to the [Backport tool
documentation](https://github.com/sqren/backport)

<!--BACKPORT [{"author":{"name":"Gerard
Soldevila","email":"[email protected]"},"sourceCommit":{"committedDate":"2024-10-25T14:05:27Z","message":"[Sustainable
Kibana Architecture] Update plugins (wave #1) (#195375)\n\n##
Summary\r\n\r\nFollow-up of
https://github.com/elastic/kibana/pull/195367\r\nAs part of the
Sustainable Kibana Architecture initiative, this PR\r\nleverages the
mechanisms and concepts introduced
in\r\nhttps://github.com//pull/194810, updating plugins
that\r\nwere considered to be solution-specific in
Luke's\r\n[PoC](https://github.com/elastic/kibana/pull/179710).\r\n\r\nThis
might trigger linting rule violations in CI, and help
uncover\r\nconflicts related to forbidden dependencies.\r\nAs soon as
they are resolved, we can proceed to classify
solutions'\r\nplugins.","sha":"a5517d9d2cf38369fc46ea9622ce36c768436aad","branchLabelMapping":{"^v9.0.0$":"main","^v8.17.0$":"8.x","^v(\\d+).(\\d+).\\d+$":"$1.$2"}},"sourcePullRequest":{"labels":["Team:Core","Feature:Embedding","Feature:ExpressionLanguage","release_note:skip","Feature:Drilldowns","Team:Fleet","v9.0.0","backport:prev-minor","Team:Obs
AI
Assistant","ci:project-deploy-observability","Team:obs-ux-infra_services","Team:obs-ux-management"],"number":195375,"url":"https://github.com/elastic/kibana/pull/195375","mergeCommit":{"message":"[Sustainable
Kibana Architecture] Update plugins (wave #1) (#195375)\n\n##
Summary\r\n\r\nFollow-up of
https://github.com/elastic/kibana/pull/195367\r\nAs part of the
Sustainable Kibana Architecture initiative, this PR\r\nleverages the
mechanisms and concepts introduced
in\r\nhttps://github.com//pull/194810, updating plugins
that\r\nwere considered to be solution-specific in
Luke's\r\n[PoC](https://github.com/elastic/kibana/pull/179710).\r\n\r\nThis
might trigger linting rule violations in CI, and help
uncover\r\nconflicts related to forbidden dependencies.\r\nAs soon as
they are resolved, we can proceed to classify
solutions'\r\nplugins.","sha":"a5517d9d2cf38369fc46ea9622ce36c768436aad"}},"sourceBranch":"main","suggestedTargetBranches":[],"targetPullRequestStates":[{"branch":"main","label":"v9.0.0","labelRegex":"^v9.0.0$","isSourceBranch":true,"state":"MERGED","url":"https://github.com/elastic/kibana/pull/195375","number":195375,"mergeCommit":{"message":"[Sustainable
Kibana Architecture] Update plugins (wave #1) (#195375)\n\n##
Summary\r\n\r\nFollow-up of
https://github.com/elastic/kibana/pull/195367\r\nAs part of the
Sustainable Kibana Architecture initiative, this PR\r\nleverages the
mechanisms and concepts introduced
in\r\nhttps://github.com//pull/194810, updating plugins
that\r\nwere considered to be solution-specific in
Luke's\r\n[PoC](https://github.com/elastic/kibana/pull/179710).\r\n\r\nThis
might trigger linting rule violations in CI, and help
uncover\r\nconflicts related to forbidden dependencies.\r\nAs soon as
they are resolved, we can proceed to classify
solutions'\r\nplugins.","sha":"a5517d9d2cf38369fc46ea9622ce36c768436aad"}}]}]
BACKPORT-->
@kibanamachine kibanamachine added v8.17.0 and removed backport missing Added to PRs automatically when the are determined to be missing a backport. labels Nov 8, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backport:prev-minor Backport to (8.x) the previous minor version (i.e. one version back from main) ci:project-deploy-observability Create an Observability project Feature:Drilldowns Embeddable panel Drilldowns Feature:Embedding Embedding content via iFrame Feature:ExpressionLanguage Interpreter expression language (aka canvas pipeline) release_note:skip Skip the PR/issue when compiling release notes Team:Core Core services & architecture: plugins, logging, config, saved objects, http, ES client, i18n, etc Team:Fleet Team label for Observability Data Collection Fleet team Team:Obs AI Assistant Observability AI Assistant Team:obs-ux-infra_services Observability Infrastructure & Services User Experience Team Team:obs-ux-management Observability Management User Experience Team v8.17.0 v9.0.0
Projects
None yet
Development

Successfully merging this pull request may close these issues.

7 participants