Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[8.x] [Dashboard] [Usability] Add scroll margin to panels (#193430) #195323

Merged
merged 2 commits into from
Oct 15, 2024

Conversation

kibanamachine
Copy link
Contributor

Backport

This will backport the following commits from main to 8.x:

Questions ?

Please refer to the Backport tool documentation

## Summary

Closes [[Bug] Upper part of the chart is hidden when user edits a chart
inline · Issue elastic#192437 · elastic/kibana ·
GitHub](elastic#192437)

This PR disables the overflow-y hidden css and the panel is set to the
top. Users are also able to scroll to the top of the visualization in
inline editing mode.

### Now:

https://github.com/user-attachments/assets/a68a3bdc-5452-40f3-84a6-4950e2fc7893

---------

Co-authored-by: Hannah Mudge <[email protected]>
(cherry picked from commit b4d52e4)
@kibanamachine kibanamachine merged commit a3cead9 into elastic:8.x Oct 15, 2024
24 checks passed
@elasticmachine
Copy link
Contributor

💚 Build Succeeded

Metrics [docs]

Async chunks

Total size of all lazy-loaded chunks that will be downloaded as the user navigates the app

id before after diff
dashboard 637.1KB 637.4KB +256.0B

History

cc @rshen91

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants