Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[8.x] [embeddable] avoid uncaught error when embeddable factory is not found (#195306) #195321

Merged
merged 2 commits into from
Oct 10, 2024

Conversation

kibanamachine
Copy link
Contributor

Backport

This will backport the following commits from main to 8.x:

Questions ?

Please refer to the Backport tool documentation

elastic#195306)

Small clean-up of ReactEmbeddableRenderer
1. avoid uncaught error when embeddable factory is not found. Move
`getReactEmbeddableFactory` into `buildEmbeddable` so that if factory is
not found and `getReactEmbeddableFactory` throws, its caught by
try/catch wrapping `buildEmbeddable`.
2. unsubscribe from `subscriptions`

(cherry picked from commit afb671f)
@nreese
Copy link
Contributor

nreese commented Oct 9, 2024

@elasticmachine merge upstream

@kibanamachine kibanamachine merged commit 695098b into elastic:8.x Oct 10, 2024
20 checks passed
@elasticmachine
Copy link
Contributor

💚 Build Succeeded

Metrics [docs]

Page load bundle

Size of the bundles that are downloaded on every page load. Target size is below 100kb

id before after diff
embeddable 71.7KB 71.7KB +18.0B

History

cc @nreese

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backport Feature:Embedding Embedding content via iFrame
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants