Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[8.15] [Auto Import] Make sure the committed schema is generated (#195302) #195314

Merged
merged 1 commit into from
Oct 7, 2024

Conversation

kibanamachine
Copy link
Contributor

Backport

This will backport the following commits from main to 8.15:

Questions ?

Please refer to the Backport tool documentation

…5302)

## Summary

Previously our schema and `.gen` files were not in sync, in the sense that

```
git checkout main && yarn kbn bootstrap && node scripts/generate_openapi --rootDir ./x-pack/plugins/integration_assistant && git diff
```

returned a non-trivial diff, despite the implementation in elastic#193243.

In this PR we

- add missing additionalProperties to the schema;
- generate and commit exactly the generated files.

There don't seem to be any effects from the change from `passthrough` to
`catchall`.

Tested with Teleport (see GitHub).

(cherry picked from commit 1599e4f)
@kibanamachine kibanamachine merged commit 725769c into elastic:8.15 Oct 7, 2024
23 checks passed
@elasticmachine
Copy link
Contributor

💚 Build Succeeded

Metrics [docs]

Async chunks

Total size of all lazy-loaded chunks that will be downloaded as the user navigates the app

id before after diff
integrationAssistant 948.0KB 948.0KB +22.0B

cc @ilyannn

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants