[8.x] [Discover] Adjust log.level indicator alignment (#195098) #195265
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
## 📓 Summary A change in the EuiDataGrid style clashed with a custom CSS change applied to the grid in order to render the `log.level` indicator on the whole line height. This change fixes the spacing issue and delegates to the inner element, the indicator itself, the responsibility to make fill the whole space ignoring padding imposed by the grid (using an absolute positioning, the DOM node will ignore inner spacing and fill the parent container.) https://github.com/user-attachments/assets/fe8d418a-5c7f-4999-86a4-296304d5aa97 Co-authored-by: Marco Antonio Ghiani <[email protected]> (cherry picked from commit 78cc1ad)
![github-actions[bot]](https://avatars.githubusercontent.com/in/15368?s=60&v=4){kind=small}
💚 Build Succeeded
Metrics [docs]Async chunks
To update your PR or re-run it, just comment with: cc @tonyghiani |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Backport
This will backport the following commits from
mainto8.x:Questions ?
Please refer to the Backport tool documentation