Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Inventory][ECO] Show alerts for entities #195250

Merged
merged 36 commits into from
Oct 15, 2024
Merged

[Inventory][ECO] Show alerts for entities #195250

merged 36 commits into from
Oct 15, 2024

Conversation

kpatticha
Copy link
Contributor

@kpatticha kpatticha commented Oct 7, 2024 •
edited by kibanamachine
Loading

Summary

Show alerts related to entities

close #194381

Checklist

Screen.Recording.2024-10-10.at.18.56.01.mov

How to test

  • run any synthtrace scenario exnode scripts/synthtrace infra_hosts_with_apm_hosts.ts
  • create a rule (SLO or apm)
  • click on the alert count

@reakaleek
Copy link
Member

🤖 GitHub comments

Expand to view the GitHub comments

Just comment with:

  • /oblt-deploy : Deploy a Kibana instance using the Observability test environments.
  • run docs-build : Re-trigger the docs validation. (use unformatted text in the comment!)

@kpatticha kpatticha changed the title 194381 entities alerts [Inventory][ECO] Show alerts for entities Oct 10, 2024
@kpatticha kpatticha marked this pull request as ready for review October 10, 2024 16:06
@kpatticha kpatticha requested review from a team as code owners October 10, 2024 16:06
@botelastic botelastic bot added ci:project-deploy-observability Create an Observability project Team:obs-ux-infra_services Observability Infrastructure & Services User Experience Team labels Oct 10, 2024
@elasticmachine
Copy link
Contributor

Pinging @elastic/obs-ux-infra_services-team (Team:obs-ux-infra_services)

@kpatticha kpatticha requested a review from a team as a code owner October 11, 2024 15:20
dominiqueclarke
dominiqueclarke approved these changes Oct 11, 2024
View reviewed changes
Copy link
Contributor

@dominiqueclarke dominiqueclarke left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

obs-ux-management changes LGTM

@flash1293
Copy link
Contributor

flash1293 commented Oct 11, 2024 •
edited
Loading

Does this also work for burn rate alerts? I have a burn rate alert firing and it's linking to the service view properly:
Screenshot 2024-10-11 at 18 50 46
Screenshot 2024-10-11 at 18 52 43

But when I follow this link and go to the alerts tab, it's not showing:
Screenshot 2024-10-11 at 18 51 10

Not sure whether this PR is targeting this problem, but it would be important for the demo we are targeting

@kpatticha
Copy link
Contributor Author

@flash1293 good point, thanks for reviewing it. This is happening cause in APM we fetch alerts that are produced from apm

kibana/x-pack/plugins/observability_solution/apm/server/lib/helpers/get_apm_alerts_client.ts

Line 34 in 62ca320

const apmAlertsIndices = await alertsClient.getAuthorizedAlertsIndices(['apm']);

I created a separate issue #196053 to tackle this

cauemarcondes
cauemarcondes reviewed Oct 14, 2024
View reviewed changes
Copy link
Contributor

@cauemarcondes cauemarcondes left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Round 2

x-pack/plugins/observability_solution/inventory/public/components/alerts_badge/alerts_badge.tsx Outdated Show resolved Hide resolved
...servability_solution/inventory/server/routes/entities/get_identity_fields_per_entity_type.ts Outdated Show resolved Hide resolved
...servability_solution/inventory/server/routes/entities/get_identity_fields_per_entity_type.ts Outdated Show resolved Hide resolved
x-pack/plugins/observability_solution/inventory/server/routes/entities/get_latest_entities.ts Outdated Show resolved Hide resolved
x-pack/plugins/observability_solution/inventory/server/routes/entities/get_latest_entities.ts Show resolved Hide resolved
...lugins/observability_solution/inventory/server/routes/entities/get_latest_entities_alerts.ts Show resolved Hide resolved
x-pack/plugins/observability_solution/inventory/server/routes/entities/route.ts Show resolved Hide resolved
cauemarcondes
cauemarcondes approved these changes Oct 15, 2024
View reviewed changes
Copy link
Contributor

@cauemarcondes cauemarcondes left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Just a nit

...servability_solution/inventory/server/routes/entities/get_identity_fields_per_entity_type.ts Outdated Show resolved Hide resolved
@kpatticha kpatticha enabled auto-merge (squash) October 15, 2024 09:46
@elasticmachine
Copy link
Contributor

elasticmachine commented Oct 15, 2024 •
edited
Loading

💚 Build Succeeded

  • Buildkite Build
  • Commit: d152a6b
  • Kibana Serverless Image: docker.elastic.co/kibana-ci/kibana-serverless:pr-195250-d152a6ba87cb

Metrics [docs]

Module Count

Fewer modules leads to a faster build time

id before after diff
inventory 224 227 +3

Async chunks

Total size of all lazy-loaded chunks that will be downloaded as the user navigates the app

id before after diff
inventory 216.5KB 218.2KB +1.7KB

Page load bundle

Size of the bundles that are downloaded on every page load. Target size is below 100kb

id before after diff
inventory 10.6KB 10.7KB +38.0B

History

@kpatticha kpatticha merged commit c0bd82b into elastic:main Oct 15, 2024
27 checks passed
@kibanamachine
Copy link
Contributor

Starting backport for target branches: 8.x

https://github.com/elastic/kibana/actions/runs/11345446408

kibanamachine pushed a commit to kibanamachine/kibana that referenced this pull request Oct 15, 2024
@kpatticha
[Inventory][ECO] Show alerts for entities (elastic#195250)
c2e66ad 
## Summary

Show alerts related to entities

close elastic#194381

### Checklist

- change default sorting from last seen to alertsCount
- when alertsCount is not available server side sorting fallbacks to
last seen
- [Change app route from /app/observability/inventory to
/app/inventory](elastic@57598d0)
(causing issue when importing observability plugin
- refactoring: move columns into seperate file

https://github.com/user-attachments/assets/ea3abc5a-0581-41e7-a174-6655a39c1133

### How to test
- run any synthtrace scenario ex`node scripts/synthtrace
infra_hosts_with_apm_hosts.ts`
- create a rule (SLO or apm)
- click on the alert count

---------

Co-authored-by: kibanamachine <[email protected]>
Co-authored-by: Cauê Marcondes <[email protected]>
(cherry picked from commit c0bd82b)
@kibanamachine kibanamachine mentioned this pull request Oct 15, 2024
Merged
@kibanamachine
Copy link
Contributor

💚 All backports created successfully

Status Branch Result
✅ 8.x

Note: Successful backport PRs will be merged automatically after passing CI.

Questions ?

Please refer to the Backport tool documentation

This was referenced Oct 15, 2024
Merged
Merged
kibanamachine added a commit that referenced this pull request Oct 15, 2024
@kibanamachine @kpatticha
[8.x] [Inventory][ECO] Show alerts for entities (#195250) (#196288)
c04b25b 
# Backport

This will backport the following commits from `main` to `8.x`:
- [[Inventory][ECO] Show alerts for entities
(#195250)](#195250)

<!--- Backport version: 9.4.3 -->

### Questions ?
Please refer to the [Backport tool
documentation](https://github.com/sqren/backport)

<!--BACKPORT
[{"author":{"name":"Katerina","email":"[email protected]"},"sourceCommit":{"committedDate":"2024-10-15T11:51:34Z","message":"[Inventory][ECO]
Show alerts for entities (#195250)\n\n## Summary\r\n\r\nShow alerts
related to entities\r\n\r\nclose
#194381 \r\n\r\n###
Checklist\r\n\r\n- change default sorting from last seen to
alertsCount\r\n- when alertsCount is not available server side sorting
fallbacks to\r\nlast seen\r\n- [Change app route from
/app/observability/inventory
to\r\n/app/inventory](https://github.com/elastic/kibana/pull/195250/commits/57598d05fbc27b5ef1c2654508719e4bd8069879)\r\n(causing
issue when importing observability plugin\r\n- refactoring: move columns
into seperate file
\r\n\r\n\r\n\r\n\r\nhttps://github.com/user-attachments/assets/ea3abc5a-0581-41e7-a174-6655a39c1133\r\n\r\n\r\n\r\n###
How to test\r\n- run any synthtrace scenario ex`node
scripts/synthtrace\r\ninfra_hosts_with_apm_hosts.ts`\r\n- create a rule
(SLO or apm) \r\n- click on the alert
count\r\n\r\n---------\r\n\r\nCo-authored-by: kibanamachine
<[email protected]>\r\nCo-authored-by:
Cauê Marcondes
<[email protected]>","sha":"c0bd82b30ca7e0fec99321412a37a2e37bc20970","branchLabelMapping":{"^v9.0.0$":"main","^v8.16.0$":"8.x","^v(\\d+).(\\d+).\\d+$":"$1.$2"}},"sourcePullRequest":{"labels":["v9.0.0","release_note:feature","backport:prev-minor","ci:project-deploy-observability","Team:obs-ux-infra_services","v8.16.0"],"title":"[Inventory][ECO]
Show alerts for entities
","number":195250,"url":"https://github.com/elastic/kibana/pull/195250","mergeCommit":{"message":"[Inventory][ECO]
Show alerts for entities (#195250)\n\n## Summary\r\n\r\nShow alerts
related to entities\r\n\r\nclose
#194381 \r\n\r\n###
Checklist\r\n\r\n- change default sorting from last seen to
alertsCount\r\n- when alertsCount is not available server side sorting
fallbacks to\r\nlast seen\r\n- [Change app route from
/app/observability/inventory
to\r\n/app/inventory](https://github.com/elastic/kibana/pull/195250/commits/57598d05fbc27b5ef1c2654508719e4bd8069879)\r\n(causing
issue when importing observability plugin\r\n- refactoring: move columns
into seperate file
\r\n\r\n\r\n\r\n\r\nhttps://github.com/user-attachments/assets/ea3abc5a-0581-41e7-a174-6655a39c1133\r\n\r\n\r\n\r\n###
How to test\r\n- run any synthtrace scenario ex`node
scripts/synthtrace\r\ninfra_hosts_with_apm_hosts.ts`\r\n- create a rule
(SLO or apm) \r\n- click on the alert
count\r\n\r\n---------\r\n\r\nCo-authored-by: kibanamachine
<[email protected]>\r\nCo-authored-by:
Cauê Marcondes
<[email protected]>","sha":"c0bd82b30ca7e0fec99321412a37a2e37bc20970"}},"sourceBranch":"main","suggestedTargetBranches":["8.x"],"targetPullRequestStates":[{"branch":"main","label":"v9.0.0","branchLabelMappingKey":"^v9.0.0$","isSourceBranch":true,"state":"MERGED","url":"https://github.com/elastic/kibana/pull/195250","number":195250,"mergeCommit":{"message":"[Inventory][ECO]
Show alerts for entities (#195250)\n\n## Summary\r\n\r\nShow alerts
related to entities\r\n\r\nclose
#194381 \r\n\r\n###
Checklist\r\n\r\n- change default sorting from last seen to
alertsCount\r\n- when alertsCount is not available server side sorting
fallbacks to\r\nlast seen\r\n- [Change app route from
/app/observability/inventory
to\r\n/app/inventory](https://github.com/elastic/kibana/pull/195250/commits/57598d05fbc27b5ef1c2654508719e4bd8069879)\r\n(causing
issue when importing observability plugin\r\n- refactoring: move columns
into seperate file
\r\n\r\n\r\n\r\n\r\nhttps://github.com/user-attachments/assets/ea3abc5a-0581-41e7-a174-6655a39c1133\r\n\r\n\r\n\r\n###
How to test\r\n- run any synthtrace scenario ex`node
scripts/synthtrace\r\ninfra_hosts_with_apm_hosts.ts`\r\n- create a rule
(SLO or apm) \r\n- click on the alert
count\r\n\r\n---------\r\n\r\nCo-authored-by: kibanamachine
<[email protected]>\r\nCo-authored-by:
Cauê Marcondes
<[email protected]>","sha":"c0bd82b30ca7e0fec99321412a37a2e37bc20970"}},{"branch":"8.x","label":"v8.16.0","branchLabelMappingKey":"^v8.16.0$","isSourceBranch":false,"state":"NOT_CREATED"}]}]
BACKPORT-->

Co-authored-by: Katerina <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@cauemarcondes cauemarcondes cauemarcondes approved these changes

@dominiqueclarke dominiqueclarke dominiqueclarke approved these changes

@jloleysens jloleysens jloleysens approved these changes

Assignees
No one assigned
Labels
backport:prev-minor Backport to (8.x) the previous minor version (i.e. one version back from main) ci:project-deploy-observability Create an Observability project release_note:feature Makes this part of the condensed release notes Team:obs-ux-infra_services Observability Infrastructure & Services User Experience Team v8.16.0 v9.0.0
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[Inventory][ECO] Show alerts count
8 participants
@kpatticha @reakaleek @elasticmachine @flash1293 @kibanamachine @jloleysens @dominiqueclarke @cauemarcondes