[Lens][ES|QL] Do not refetch the attributes if the query hasn't changed #195196
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
💛 Build succeeded, but was flaky
Failed CI StepsMetrics [docs]Async chunks
To update your PR or re-run it, just comment with: |
stratoula
added
Team:Visualizations
|
Pinging @elastic/kibana-visualizations (Team:Visualizations) |
markov00
reviewed
Oct 9, 2024
x-pack/plugins/lens/public/app_plugin/shared/edit_on_the_fly/lens_configuration_flyout.tsx
Outdated
Show resolved
Hide resolved
markov00
approved these changes
Oct 9, 2024
|
Starting backport for target branches: 8.x |
💚 Build Succeeded
Metrics [docs]Async chunks
History
|
kibanamachine
pushed a commit
to kibanamachine/kibana
that referenced
this pull request
Oct 9, 2024
…ed (elastic#195196) ## Summary When a user is creating a Lens ES|QL chart we run the suggestions api even if the query hasn't changed. This PR adds a guard to avoid refetching the attributes when the query hasn't changed at all. (cherry picked from commit a209fe8)
💚 All backports created successfully
Note: Successful backport PRs will be merged automatically after passing CI. Questions ?Please refer to the Backport tool documentation |
kibanamachine
added a commit
that referenced
this pull request
Oct 9, 2024
…x27;t changed (#195196) (#195649) # Backport This will backport the following commits from `main` to `8.x`: - [[Lens][ES|QL] Do not refetch the attributes if the query hasn't changed (#195196)](#195196) <!--- Backport version: 9.4.3 --> ### Questions ? Please refer to the [Backport tool documentation](https://github.com/sqren/backport) <!--BACKPORT [{"author":{"name":"Stratoula Kalafateli","email":"[email protected]"},"sourceCommit":{"committedDate":"2024-10-09T16:46:31Z","message":"[Lens][ES|QL] Do not refetch the attributes if the query hasn't changed (#195196)\n\n## Summary\r\n\r\nWhen a user is creating a Lens ES|QL chart we run the suggestions api\r\neven if the query hasn't changed. This PR adds a guard to avoid\r\nrefetching the attributes when the query hasn't changed at all.","sha":"a209fe8d7d7d1e27bb9b80475ea2821a9202e823","branchLabelMapping":{"^v9.0.0$":"main","^v8.16.0$":"8.x","^v(\\d+).(\\d+).\\d+$":"$1.$2"}},"sourcePullRequest":{"labels":["Team:Visualizations","release_note:skip","Feature:Lens","v9.0.0","backport:prev-minor","Feature:ES|QL"],"title":"[Lens][ES|QL] Do not refetch the attributes if the query hasn't changed","number":195196,"url":"https://github.com/elastic/kibana/pull/195196","mergeCommit":{"message":"[Lens][ES|QL] Do not refetch the attributes if the query hasn't changed (#195196)\n\n## Summary\r\n\r\nWhen a user is creating a Lens ES|QL chart we run the suggestions api\r\neven if the query hasn't changed. This PR adds a guard to avoid\r\nrefetching the attributes when the query hasn't changed at all.","sha":"a209fe8d7d7d1e27bb9b80475ea2821a9202e823"}},"sourceBranch":"main","suggestedTargetBranches":[],"targetPullRequestStates":[{"branch":"main","label":"v9.0.0","branchLabelMappingKey":"^v9.0.0$","isSourceBranch":true,"state":"MERGED","url":"https://github.com/elastic/kibana/pull/195196","number":195196,"mergeCommit":{"message":"[Lens][ES|QL] Do not refetch the attributes if the query hasn't changed (#195196)\n\n## Summary\r\n\r\nWhen a user is creating a Lens ES|QL chart we run the suggestions api\r\neven if the query hasn't changed. This PR adds a guard to avoid\r\nrefetching the attributes when the query hasn't changed at all.","sha":"a209fe8d7d7d1e27bb9b80475ea2821a9202e823"}}]}] BACKPORT--> Co-authored-by: Stratoula Kalafateli <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
When a user is creating a Lens ES|QL chart we run the suggestions api even if the query hasn't changed. This PR adds a guard to avoid refetching the attributes when the query hasn't changed at all.