Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[index management] Index templates matching a_fake_index_pattern_that_wont_match_any_indices preview fix #195174

Merged
merged 17 commits into from
Nov 13, 2024

Conversation

mattkime
Copy link
Contributor

@mattkime mattkime commented Oct 7, 2024

Summary

Preview functionality (Index template detail -> preview tab) on index templates matching a_fake_index_pattern_that_wont_match_any_indices (such as * or a*) would fail once saved.

Now passing template name instead of content for saved templates which avoids annoyances with passing the index_pattern.

Linked issue has a good set of steps for reproduction.

Closes #189555

@mattkime mattkime self-assigned this Nov 3, 2024
@mattkime mattkime added Team:Kibana Management Dev Tools, Index Management, Upgrade Assistant, ILM, Ingest Node Pipelines, and more backport:prev-minor Backport to (8.x) the previous minor version (i.e. one version back from main) release_note:skip Skip the PR/issue when compiling release notes labels Nov 3, 2024
@mattkime mattkime changed the title use simulate by name for saved index templates [index management] Index templates matching a_fake_index_pattern_that_wont_match_any_indices preview fix Nov 3, 2024
@elasticmachine
Copy link
Contributor

💚 Build Succeeded

Metrics [docs]

Async chunks

Total size of all lazy-loaded chunks that will be downloaded as the user navigates the app

id before after diff
indexManagement 689.9KB 690.0KB +145.0B
Unknown metric groups

ESLint disabled line counts

id before after diff
indexManagement 15 16 +1

Total ESLint disabled count

id before after diff
indexManagement 18 19 +1

History

cc @mattkime

@elastic elastic deleted a comment from kibana-ci Nov 13, 2024
@mattkime mattkime marked this pull request as ready for review November 13, 2024 01:48
@mattkime mattkime requested a review from a team as a code owner November 13, 2024 01:48
@elasticmachine
Copy link
Contributor

Pinging @elastic/kibana-management (Team:Kibana Management)

@sabarasaba sabarasaba added the Feature:Index Management Index and index templates UI label Nov 13, 2024
Copy link
Member

@sabarasaba sabarasaba left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks a lot for patching this up @mattkime! Changes lgtm, tested locally 🚀

@mattkime mattkime merged commit a15ab4d into elastic:main Nov 13, 2024
23 checks passed
@kibanamachine
Copy link
Contributor

Starting backport for target branches: 8.x

https://github.com/elastic/kibana/actions/runs/11816561627

kibanamachine pushed a commit to kibanamachine/kibana that referenced this pull request Nov 13, 2024
…t_wont_match_any_indices` preview fix (elastic#195174)

## Summary

Preview functionality (Index template detail -> preview tab) on index
templates matching `a_fake_index_pattern_that_wont_match_any_indices`
(such as `*` or `a*`) would fail once saved.

Now passing template name instead of content for saved templates which
avoids annoyances with passing the `index_pattern`.

Linked issue has a good set of steps for reproduction.

Closes elastic#189555

(cherry picked from commit a15ab4d)
@kibanamachine
Copy link
Contributor

💚 All backports created successfully

Status Branch Result
8.x

Note: Successful backport PRs will be merged automatically after passing CI.

Questions ?

Please refer to the Backport tool documentation

kibanamachine added a commit that referenced this pull request Nov 13, 2024
…pattern_that_wont_match_any_indices` preview fix (#195174) (#199983)

# Backport

This will backport the following commits from `main` to `8.x`:
- [[index management] Index templates matching
`a_fake_index_pattern_that_wont_match_any_indices` preview fix
(#195174)](#195174)

<!--- Backport version: 9.4.3 -->

### Questions ?
Please refer to the [Backport tool
documentation](https://github.com/sqren/backport)

<!--BACKPORT [{"author":{"name":"Matthew
Kime","email":"[email protected]"},"sourceCommit":{"committedDate":"2024-11-13T11:43:41Z","message":"[index
management] Index templates matching
`a_fake_index_pattern_that_wont_match_any_indices` preview fix
(#195174)\n\n## Summary\r\n\r\nPreview functionality (Index template
detail -> preview tab) on index\r\ntemplates matching
`a_fake_index_pattern_that_wont_match_any_indices`\r\n(such as `*` or
`a*`) would fail once saved.\r\n\r\nNow passing template name instead of
content for saved templates which\r\navoids annoyances with passing the
`index_pattern`.\r\n\r\nLinked issue has a good set of steps for
reproduction.\r\n\r\nCloses
https://github.com/elastic/kibana/issues/189555","sha":"a15ab4d8557c371563eab8da6d5ef8c21b6bbbcb","branchLabelMapping":{"^v9.0.0$":"main","^v8.17.0$":"8.x","^v(\\d+).(\\d+).\\d+$":"$1.$2"}},"sourcePullRequest":{"labels":["Feature:Index
Management","Team:Kibana
Management","release_note:skip","v9.0.0","backport:prev-minor"],"title":"[index
management] Index templates matching
`a_fake_index_pattern_that_wont_match_any_indices` preview
fix","number":195174,"url":"https://github.com/elastic/kibana/pull/195174","mergeCommit":{"message":"[index
management] Index templates matching
`a_fake_index_pattern_that_wont_match_any_indices` preview fix
(#195174)\n\n## Summary\r\n\r\nPreview functionality (Index template
detail -> preview tab) on index\r\ntemplates matching
`a_fake_index_pattern_that_wont_match_any_indices`\r\n(such as `*` or
`a*`) would fail once saved.\r\n\r\nNow passing template name instead of
content for saved templates which\r\navoids annoyances with passing the
`index_pattern`.\r\n\r\nLinked issue has a good set of steps for
reproduction.\r\n\r\nCloses
https://github.com/elastic/kibana/issues/189555","sha":"a15ab4d8557c371563eab8da6d5ef8c21b6bbbcb"}},"sourceBranch":"main","suggestedTargetBranches":[],"targetPullRequestStates":[{"branch":"main","label":"v9.0.0","branchLabelMappingKey":"^v9.0.0$","isSourceBranch":true,"state":"MERGED","url":"https://github.com/elastic/kibana/pull/195174","number":195174,"mergeCommit":{"message":"[index
management] Index templates matching
`a_fake_index_pattern_that_wont_match_any_indices` preview fix
(#195174)\n\n## Summary\r\n\r\nPreview functionality (Index template
detail -> preview tab) on index\r\ntemplates matching
`a_fake_index_pattern_that_wont_match_any_indices`\r\n(such as `*` or
`a*`) would fail once saved.\r\n\r\nNow passing template name instead of
content for saved templates which\r\navoids annoyances with passing the
`index_pattern`.\r\n\r\nLinked issue has a good set of steps for
reproduction.\r\n\r\nCloses
https://github.com/elastic/kibana/issues/189555","sha":"a15ab4d8557c371563eab8da6d5ef8c21b6bbbcb"}}]}]
BACKPORT-->

Co-authored-by: Matthew Kime <[email protected]>
CAWilson94 pushed a commit to CAWilson94/kibana that referenced this pull request Nov 18, 2024
…t_wont_match_any_indices` preview fix (elastic#195174)

## Summary

Preview functionality (Index template detail -> preview tab) on index
templates matching `a_fake_index_pattern_that_wont_match_any_indices`
(such as `*` or `a*`) would fail once saved.

Now passing template name instead of content for saved templates which
avoids annoyances with passing the `index_pattern`.

Linked issue has a good set of steps for reproduction.

Closes elastic#189555
CAWilson94 pushed a commit to CAWilson94/kibana that referenced this pull request Nov 18, 2024
…t_wont_match_any_indices` preview fix (elastic#195174)

## Summary

Preview functionality (Index template detail -> preview tab) on index
templates matching `a_fake_index_pattern_that_wont_match_any_indices`
(such as `*` or `a*`) would fail once saved.

Now passing template name instead of content for saved templates which
avoids annoyances with passing the `index_pattern`.

Linked issue has a good set of steps for reproduction.

Closes elastic#189555
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backport:prev-minor Backport to (8.x) the previous minor version (i.e. one version back from main) Feature:Index Management Index and index templates UI release_note:skip Skip the PR/issue when compiling release notes Team:Kibana Management Dev Tools, Index Management, Upgrade Assistant, ILM, Ingest Node Pipelines, and more v8.17.0 v9.0.0
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Preview for match-all template gives error response
4 participants