-
Notifications
You must be signed in to change notification settings - Fork 8.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[index management] Index templates matching a_fake_index_pattern_that_wont_match_any_indices
preview fix
#195174
[index management] Index templates matching a_fake_index_pattern_that_wont_match_any_indices
preview fix
#195174
Conversation
a_fake_index_pattern_that_wont_match_any_indices
preview fix
…/kibana into index_template_simulate_by_name
…/kibana into index_template_simulate_by_name
💚 Build Succeeded
Metrics [docs]Async chunks
Unknown metric groupsESLint disabled line counts
Total ESLint disabled count
History
cc @mattkime |
Pinging @elastic/kibana-management (Team:Kibana Management) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks a lot for patching this up @mattkime! Changes lgtm, tested locally 🚀
Starting backport for target branches: 8.x |
…t_wont_match_any_indices` preview fix (elastic#195174) ## Summary Preview functionality (Index template detail -> preview tab) on index templates matching `a_fake_index_pattern_that_wont_match_any_indices` (such as `*` or `a*`) would fail once saved. Now passing template name instead of content for saved templates which avoids annoyances with passing the `index_pattern`. Linked issue has a good set of steps for reproduction. Closes elastic#189555 (cherry picked from commit a15ab4d)
💚 All backports created successfully
Note: Successful backport PRs will be merged automatically after passing CI. Questions ?Please refer to the Backport tool documentation |
…pattern_that_wont_match_any_indices` preview fix (#195174) (#199983) # Backport This will backport the following commits from `main` to `8.x`: - [[index management] Index templates matching `a_fake_index_pattern_that_wont_match_any_indices` preview fix (#195174)](#195174) <!--- Backport version: 9.4.3 --> ### Questions ? Please refer to the [Backport tool documentation](https://github.com/sqren/backport) <!--BACKPORT [{"author":{"name":"Matthew Kime","email":"[email protected]"},"sourceCommit":{"committedDate":"2024-11-13T11:43:41Z","message":"[index management] Index templates matching `a_fake_index_pattern_that_wont_match_any_indices` preview fix (#195174)\n\n## Summary\r\n\r\nPreview functionality (Index template detail -> preview tab) on index\r\ntemplates matching `a_fake_index_pattern_that_wont_match_any_indices`\r\n(such as `*` or `a*`) would fail once saved.\r\n\r\nNow passing template name instead of content for saved templates which\r\navoids annoyances with passing the `index_pattern`.\r\n\r\nLinked issue has a good set of steps for reproduction.\r\n\r\nCloses https://github.com/elastic/kibana/issues/189555","sha":"a15ab4d8557c371563eab8da6d5ef8c21b6bbbcb","branchLabelMapping":{"^v9.0.0$":"main","^v8.17.0$":"8.x","^v(\\d+).(\\d+).\\d+$":"$1.$2"}},"sourcePullRequest":{"labels":["Feature:Index Management","Team:Kibana Management","release_note:skip","v9.0.0","backport:prev-minor"],"title":"[index management] Index templates matching `a_fake_index_pattern_that_wont_match_any_indices` preview fix","number":195174,"url":"https://github.com/elastic/kibana/pull/195174","mergeCommit":{"message":"[index management] Index templates matching `a_fake_index_pattern_that_wont_match_any_indices` preview fix (#195174)\n\n## Summary\r\n\r\nPreview functionality (Index template detail -> preview tab) on index\r\ntemplates matching `a_fake_index_pattern_that_wont_match_any_indices`\r\n(such as `*` or `a*`) would fail once saved.\r\n\r\nNow passing template name instead of content for saved templates which\r\navoids annoyances with passing the `index_pattern`.\r\n\r\nLinked issue has a good set of steps for reproduction.\r\n\r\nCloses https://github.com/elastic/kibana/issues/189555","sha":"a15ab4d8557c371563eab8da6d5ef8c21b6bbbcb"}},"sourceBranch":"main","suggestedTargetBranches":[],"targetPullRequestStates":[{"branch":"main","label":"v9.0.0","branchLabelMappingKey":"^v9.0.0$","isSourceBranch":true,"state":"MERGED","url":"https://github.com/elastic/kibana/pull/195174","number":195174,"mergeCommit":{"message":"[index management] Index templates matching `a_fake_index_pattern_that_wont_match_any_indices` preview fix (#195174)\n\n## Summary\r\n\r\nPreview functionality (Index template detail -> preview tab) on index\r\ntemplates matching `a_fake_index_pattern_that_wont_match_any_indices`\r\n(such as `*` or `a*`) would fail once saved.\r\n\r\nNow passing template name instead of content for saved templates which\r\navoids annoyances with passing the `index_pattern`.\r\n\r\nLinked issue has a good set of steps for reproduction.\r\n\r\nCloses https://github.com/elastic/kibana/issues/189555","sha":"a15ab4d8557c371563eab8da6d5ef8c21b6bbbcb"}}]}] BACKPORT--> Co-authored-by: Matthew Kime <[email protected]>
…t_wont_match_any_indices` preview fix (elastic#195174) ## Summary Preview functionality (Index template detail -> preview tab) on index templates matching `a_fake_index_pattern_that_wont_match_any_indices` (such as `*` or `a*`) would fail once saved. Now passing template name instead of content for saved templates which avoids annoyances with passing the `index_pattern`. Linked issue has a good set of steps for reproduction. Closes elastic#189555
…t_wont_match_any_indices` preview fix (elastic#195174) ## Summary Preview functionality (Index template detail -> preview tab) on index templates matching `a_fake_index_pattern_that_wont_match_any_indices` (such as `*` or `a*`) would fail once saved. Now passing template name instead of content for saved templates which avoids annoyances with passing the `index_pattern`. Linked issue has a good set of steps for reproduction. Closes elastic#189555
Summary
Preview functionality (Index template detail -> preview tab) on index templates matching
a_fake_index_pattern_that_wont_match_any_indices
(such as*
ora*
) would fail once saved.Now passing template name instead of content for saved templates which avoids annoyances with passing the
index_pattern
.Linked issue has a good set of steps for reproduction.
Closes #189555