Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Dashboard Usability] Filters in new tabs #194877

Closed
wants to merge 4 commits into from

Conversation

rshen91
Copy link
Contributor

@rshen91 rshen91 commented Oct 3, 2024

Summary

Closes #188914

This PR allows users to open dashboards in a new tab from the dashboard listing page with unsaved and unpinned filters. Previously, filters needed to be pinned or the dashboard needed to be saved for filters to persist across tabs.

  • FIX: Filters being saved aren't lost
  • FIX: If it's saved with filters - open from the listing page or open in a new tab, and it goes to unsaved changes without a filter
  • Test multiple filter pills

Now

Oct-03-2024.19-37-46.mp4

Checklist

Delete any items that are not applicable to this PR.

@elasticmachine
Copy link
Contributor

elasticmachine commented Oct 3, 2024

🤖 Jobs for this PR can be triggered through checkboxes. 🚧

ℹ️ To trigger the CI, please tick the checkbox below 👇

  • Click to trigger kibana-pull-request for this PR!

@kibana-ci
Copy link
Collaborator

kibana-ci commented Oct 7, 2024

💔 Build Failed

Failed CI Steps

Test Failures

  • [job] [logs] FTR Configs #59 / dashboard app - group 2 dashboard filter bar filter pills are preserved after opening a dashboard saved with filters
  • [job] [logs] FTR Configs #59 / dashboard app - group 2 dashboard filter bar filter pills are preserved after opening a dashboard saved with filters
  • [job] [logs] FTR Configs #1 / dashboard app - group 6 dashboard view edit mode shows lose changes warning and loses changes on confirmation when a filter is deleted
  • [job] [logs] FTR Configs #1 / dashboard app - group 6 dashboard view edit mode shows lose changes warning and loses changes on confirmation when a filter is deleted
  • [job] [logs] FTR Configs #47 / dashboard Reporting Dashboard Generate CSV Default Saved Search Data Downloads a saved search panel with a custom time range that does not intersect with dashboard time range
  • [job] [logs] FTR Configs #47 / dashboard Reporting Dashboard Generate CSV Default Saved Search Data Downloads a saved search panel with a custom time range that does not intersect with dashboard time range
  • [job] [logs] FTR Configs #83 / data plugin Session management Dashboard starts a session on filter change
  • [job] [logs] FTR Configs #83 / data plugin Session management Dashboard starts a session on filter change
  • [job] [logs] FTR Configs #63 / links panel links panel navigation dashboard links useCurrentFilters should pass filter pills and query
  • [job] [logs] FTR Configs #63 / links panel links panel navigation dashboard links useCurrentFilters should pass filter pills and query
  • [job] [logs] FTR Configs #56 / maps app embeddable tooltip filter actions panel actions should trigger dashboard drilldown action when clicked
  • [job] [logs] FTR Configs #56 / maps app embeddable tooltip filter actions panel actions should trigger dashboard drilldown action when clicked
  • [job] [logs] FTR Configs #16 / serverless search UI Building a new dashboard loads the saved Dashboard
  • [job] [logs] FTR Configs #16 / serverless search UI Building a new dashboard loads the saved Dashboard
  • [job] [logs] FTR Configs #76 / visualize app visual builder Time Series basics Clicking on the chart should create a filter for series with multiple split by terms fields one of which has formatting
  • [job] [logs] FTR Configs #76 / visualize app visual builder Time Series basics Clicking on the chart should create a filter for series with multiple split by terms fields one of which has formatting

Metrics [docs]

Async chunks

Total size of all lazy-loaded chunks that will be downloaded as the user navigates the app

id before after diff
dashboard 649.8KB 650.3KB +552.0B

Page load bundle

Size of the bundles that are downloaded on every page load. Target size is below 100kb

id before after diff
dashboard 27.8KB 28.0KB +165.0B

History

To update your PR or re-run it, just comment with:
@elasticmachine merge upstream

cc @rshen91

@rshen91 rshen91 added the backport:all-open Backport to all branches that could still receive a release label Oct 7, 2024
@rshen91
Copy link
Contributor Author

rshen91 commented Oct 11, 2024

Closing in favor of #195985

@rshen91 rshen91 closed this Oct 11, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backport:all-open Backport to all branches that could still receive a release release_note:enhancement
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Dashboard usability] Filters are lost when users open dashboards in a new tab
3 participants