Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[8.x] [Search][Onboarding] api-key plugin (#191926) #194756

Merged
merged 2 commits into from
Oct 3, 2024

Conversation

joemcelroy
Copy link
Member

Backport

This will backport the following commits from main to 8.x:

Questions ?

Please refer to the Backport tool documentation

## Summary
Kibana plugin that helps manage the session for the api-key that
provides two exports:
- React custom hook to read the api-key stored in session. This hook
should return the api-key if it exists, otherwise null.
- Component to present either the api key in storage or action to create
api key and store into sessionStorage after callback.
<img width="1255" alt="Screenshot 2024-09-27 at 20 52 52"
src="https://github.com/user-attachments/assets/dc5bcd39-7fe6-433c-8aaa-ad3578a68b62">
<img width="1248" alt="Screenshot 2024-09-27 at 20 52 39"
src="https://github.com/user-attachments/assets/d760c163-9017-4f57-ba1a-38ee8ee21534">
<img width="676" alt="Screenshot 2024-09-27 at 20 52 28"
src="https://github.com/user-attachments/assets/e908d20a-7e0c-4f3b-9ea2-8e2d1a74c9eb">

(cherry picked from commit c5aa739)

# Conflicts:
#	.github/CODEOWNERS
@joemcelroy joemcelroy enabled auto-merge (squash) October 2, 2024 18:52
@kibana-ci
Copy link
Collaborator

💛 Build succeeded, but was flaky

Failed CI Steps

Test Failures

  • [job] [logs] Jest Tests #5 / StepConfigurePackage should show nothing to configure if no matching integration

Metrics [docs]

Module Count

Fewer modules leads to a faster build time

id before after diff
searchIndices 182 217 +35

Public APIs missing comments

Total count of every public API that lacks a comment. Target amount is 0. Run node scripts/build_api_docs --plugin [yourplugin] --stats comments for more detailed information.

id before after diff
@kbn/search-api-keys-components - 8 +8
@kbn/search-api-keys-server - 3 +3
@kbn/search-shared-ui - 2 +2
total +13

Async chunks

Total size of all lazy-loaded chunks that will be downloaded as the user navigates the app

id before after diff
searchIndices 96.4KB 152.0KB +55.6KB
security 590.8KB 590.9KB +80.0B
serverlessSearch 331.3KB 331.4KB +80.0B
total +55.7KB

Public APIs missing exports

Total count of every type that is part of your API that should be exported but is not. This will cause broken links in the API documentation system. Target amount is 0. Run node scripts/build_api_docs --plugin [yourplugin] --stats exports for more detailed information.

id before after diff
@kbn/core 1 2 +1
@kbn/search-api-keys-components - 1 +1
total +2

Page load bundle

Size of the bundles that are downloaded on every page load. Target size is below 100kb

id before after diff
searchIndices 6.0KB 6.2KB +227.0B
Unknown metric groups

API count

id before after diff
@kbn/search-api-keys-components - 8 +8
@kbn/search-api-keys-server - 3 +3
@kbn/search-shared-ui - 2 +2
total +13

async chunk count

id before after diff
searchIndices 4 5 +1

ESLint disabled line counts

id before after diff
@kbn/security-api-key-management 5 6 +1

Total ESLint disabled count

id before after diff
@kbn/security-api-key-management 5 6 +1

To update your PR or re-run it, just comment with:
@elasticmachine merge upstream

@joemcelroy joemcelroy merged commit 522fffb into elastic:8.x Oct 3, 2024
29 checks passed
@joemcelroy joemcelroy deleted the backport/8.x/pr-191926 branch October 3, 2024 13:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants