Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[ Security Solution ]Re-organize the Investigations api integration test for MKI #194707

Merged

Conversation

logeekal
Copy link
Contributor

@logeekal logeekal commented Oct 2, 2024

Summary

This is Part 1 of the in resolving the issue : #183645 .

This PR re-organizes investigations API tests so that they can be run in Serveless MKI at both basic/essentials and complete licenses.

How to test this PR

Below are the commands that are affected by this change and you can test the PR by running below commands.

Each commands sets up the test environment and give you a command to run tests. Please run those tests to see if everything is okay. An example is shown in below screenshot.

grafik
Module Deployment License Command
Timelines ESS basic yarn investigations:basic:timeline:server:ess
Timelines ESS Trial yarn investigations:timeline:server:ess
Timelines Serverless basic yarn investigations:basic:timeline:server:serverless
Timelines Serverless Trial yarn investigations:timeline:server:serverless
Saved Objects ESS basic yarn investigations:basic:saved-objects:server:ess
Saved Objects ESS Trial yarn investigations:saved-objects:server:ess
Saved Objects Serverless basic yarn investigations:basic:saved-objects:server:serverless
Saved Objects Serverless Trial yarn investigations:saved-objects:server:serverless

@logeekal logeekal added Team:Threat Hunting:Investigations Security Solution Investigations Team backport:prev-minor Backport to (8.x) the previous minor version (i.e. one version back from main) labels Oct 2, 2024
@logeekal logeekal marked this pull request as ready for review October 2, 2024 14:01
@logeekal logeekal requested review from a team as code owners October 2, 2024 14:01
@elasticmachine
Copy link
Contributor

Pinging @elastic/security-threat-hunting-investigations (Team:Threat Hunting:Investigations)

@logeekal logeekal added the release_note:skip Skip the PR/issue when compiling release notes label Oct 2, 2024
@logeekal logeekal changed the title [ Security Solution ]Re-organize the security solution api integration test for MKI [ Security Solution ]Re-organize the Investigations api integration test for MKI Oct 2, 2024
.buildkite/ftr_configs.yml Outdated Show resolved Hide resolved
@logeekal logeekal requested a review from pheyos October 4, 2024 09:30
@kibana-ci
Copy link
Collaborator

💚 Build Succeeded

Metrics [docs]

✅ unchanged

History

  • 💛 Build #239704 was flaky 3c0d9e1762a184395cf9cbbd399a66a7b6f5b600
  • 💔 Build #239431 failed fa66347469959e90b2693fd570acc9e1598613c6
  • 💔 Build #239373 failed 405419e7d5d087824a90ed192f65b0f304bbcf14
  • 💔 Build #238832 failed 0f627e0d27e637d53eacce4b034853486cee41fd

To update your PR or re-run it, just comment with:
@elasticmachine merge upstream

Copy link
Member

@pheyos pheyos left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM on resolving my comments.
With these changes however, there's no modified file under appex-qa code ownership anymore.

@logeekal logeekal force-pushed the fix/security_solution_api_integration_test branch 2 times, most recently from 8b22b34 to a5c0c19 Compare October 16, 2024 09:45
@logeekal logeekal enabled auto-merge (squash) October 16, 2024 09:47
@logeekal logeekal force-pushed the fix/security_solution_api_integration_test branch from 9f7a043 to ffcf5ee Compare October 16, 2024 12:28
@logeekal logeekal merged commit 2eff6d1 into elastic:main Oct 16, 2024
20 checks passed
@kibanamachine
Copy link
Contributor

Starting backport for target branches: 8.x

https://github.com/elastic/kibana/actions/runs/11371175195

@elasticmachine
Copy link
Contributor

💚 Build Succeeded

Metrics [docs]

✅ unchanged

History

kibanamachine pushed a commit to kibanamachine/kibana that referenced this pull request Oct 16, 2024
…est for MKI (elastic#194707)

## Summary

This is Part 1 of the in resolving the issue :
elastic#183645 .

This PR re-organizes investigations API tests so that they can be run in
Serveless MKI at both `basic/essentials` and `complete` licenses.

## How to test this PR

Below are the commands that are affected by this change and you can test
the PR by running below commands.

Each commands sets up the test environment and give you a command to run
tests. Please run those tests to see if everything is okay. An example
is shown in below screenshot.

<img width="1916" alt="grafik"
src="https://github.com/user-attachments/assets/fa400450-e4aa-41dc-a1ea-ac21634c46d3">

|Module|Deployment|License|Command|
|--|--|--|--|
|Timelines|ESS|basic|`yarn investigations:basic:timeline:server:ess`|
|Timelines|ESS|Trial|`yarn investigations:timeline:server:ess`|
|Timelines|Serverless|basic|`yarn
investigations:basic:timeline:server:serverless`|
|Timelines|Serverless|Trial|`yarn
investigations:timeline:server:serverless`|
|Saved Objects|ESS|basic|`yarn
investigations:basic:saved-objects:server:ess`|
|Saved Objects|ESS|Trial|`yarn investigations:saved-objects:server:ess`|
|Saved Objects|Serverless|basic|`yarn
investigations:basic:saved-objects:server:serverless`|
|Saved Objects|Serverless|Trial|`yarn
investigations:saved-objects:server:serverless`|

---------

Co-authored-by: kibanamachine <[email protected]>
(cherry picked from commit 2eff6d1)
@kibanamachine
Copy link
Contributor

💚 All backports created successfully

Status Branch Result
8.x

Note: Successful backport PRs will be merged automatically after passing CI.

Questions ?

Please refer to the Backport tool documentation

kibanamachine added a commit that referenced this pull request Oct 16, 2024
…tion test for MKI (#194707) (#196588)

# Backport

This will backport the following commits from `main` to `8.x`:
- [[ Security Solution ]Re-organize the Investigations api integration
test for MKI (#194707)](#194707)

<!--- Backport version: 9.4.3 -->

### Questions ?
Please refer to the [Backport tool
documentation](https://github.com/sqren/backport)

<!--BACKPORT [{"author":{"name":"Jatin
Kathuria","email":"[email protected]"},"sourceCommit":{"committedDate":"2024-10-16T17:56:41Z","message":"[
Security Solution ]Re-organize the Investigations api integration test
for MKI (#194707)\n\n## Summary\r\n\r\nThis is Part 1 of the in
resolving the issue :\r\nhttps://github.com//issues/183645
.\r\n\r\nThis PR re-organizes investigations API tests so that they can
be run in\r\nServeless MKI at both `basic/essentials` and `complete`
licenses.\r\n\r\n## How to test this PR \r\n\r\nBelow are the commands
that are affected by this change and you can test\r\nthe PR by running
below commands.\r\n\r\nEach commands sets up the test environment and
give you a command to run\r\ntests. Please run those tests to see if
everything is okay. An example\r\nis shown in below
screenshot.\r\n\r\n<img width=\"1916\"
alt=\"grafik\"\r\nsrc=\"https://github.com/user-attachments/assets/fa400450-e4aa-41dc-a1ea-ac21634c46d3\">\r\n\r\n\r\n|Module|Deployment|License|Command|\r\n|--|--|--|--|\r\n|Timelines|ESS|basic|`yarn
investigations:basic:timeline:server:ess`|\r\n|Timelines|ESS|Trial|`yarn
investigations:timeline:server:ess`|\r\n|Timelines|Serverless|basic|`yarn\r\ninvestigations:basic:timeline:server:serverless`|\r\n|Timelines|Serverless|Trial|`yarn\r\ninvestigations:timeline:server:serverless`|\r\n|Saved
Objects|ESS|basic|`yarn\r\ninvestigations:basic:saved-objects:server:ess`|\r\n|Saved
Objects|ESS|Trial|`yarn
investigations:saved-objects:server:ess`|\r\n|Saved
Objects|Serverless|basic|`yarn\r\ninvestigations:basic:saved-objects:server:serverless`|\r\n|Saved
Objects|Serverless|Trial|`yarn\r\ninvestigations:saved-objects:server:serverless`|\r\n\r\n---------\r\n\r\nCo-authored-by:
kibanamachine
<[email protected]>","sha":"2eff6d1046c94252ac0cc52f78859101383e6f71","branchLabelMapping":{"^v9.0.0$":"main","^v8.16.0$":"8.x","^v(\\d+).(\\d+).\\d+$":"$1.$2"}},"sourcePullRequest":{"labels":["release_note:skip","v9.0.0","Team:Threat
Hunting:Investigations","backport:prev-minor"],"title":"[ Security
Solution ]Re-organize the Investigations api integration test for
MKI","number":194707,"url":"https://github.com/elastic/kibana/pull/194707","mergeCommit":{"message":"[
Security Solution ]Re-organize the Investigations api integration test
for MKI (#194707)\n\n## Summary\r\n\r\nThis is Part 1 of the in
resolving the issue :\r\nhttps://github.com//issues/183645
.\r\n\r\nThis PR re-organizes investigations API tests so that they can
be run in\r\nServeless MKI at both `basic/essentials` and `complete`
licenses.\r\n\r\n## How to test this PR \r\n\r\nBelow are the commands
that are affected by this change and you can test\r\nthe PR by running
below commands.\r\n\r\nEach commands sets up the test environment and
give you a command to run\r\ntests. Please run those tests to see if
everything is okay. An example\r\nis shown in below
screenshot.\r\n\r\n<img width=\"1916\"
alt=\"grafik\"\r\nsrc=\"https://github.com/user-attachments/assets/fa400450-e4aa-41dc-a1ea-ac21634c46d3\">\r\n\r\n\r\n|Module|Deployment|License|Command|\r\n|--|--|--|--|\r\n|Timelines|ESS|basic|`yarn
investigations:basic:timeline:server:ess`|\r\n|Timelines|ESS|Trial|`yarn
investigations:timeline:server:ess`|\r\n|Timelines|Serverless|basic|`yarn\r\ninvestigations:basic:timeline:server:serverless`|\r\n|Timelines|Serverless|Trial|`yarn\r\ninvestigations:timeline:server:serverless`|\r\n|Saved
Objects|ESS|basic|`yarn\r\ninvestigations:basic:saved-objects:server:ess`|\r\n|Saved
Objects|ESS|Trial|`yarn
investigations:saved-objects:server:ess`|\r\n|Saved
Objects|Serverless|basic|`yarn\r\ninvestigations:basic:saved-objects:server:serverless`|\r\n|Saved
Objects|Serverless|Trial|`yarn\r\ninvestigations:saved-objects:server:serverless`|\r\n\r\n---------\r\n\r\nCo-authored-by:
kibanamachine
<[email protected]>","sha":"2eff6d1046c94252ac0cc52f78859101383e6f71"}},"sourceBranch":"main","suggestedTargetBranches":[],"targetPullRequestStates":[{"branch":"main","label":"v9.0.0","branchLabelMappingKey":"^v9.0.0$","isSourceBranch":true,"state":"MERGED","url":"https://github.com/elastic/kibana/pull/194707","number":194707,"mergeCommit":{"message":"[
Security Solution ]Re-organize the Investigations api integration test
for MKI (#194707)\n\n## Summary\r\n\r\nThis is Part 1 of the in
resolving the issue :\r\nhttps://github.com//issues/183645
.\r\n\r\nThis PR re-organizes investigations API tests so that they can
be run in\r\nServeless MKI at both `basic/essentials` and `complete`
licenses.\r\n\r\n## How to test this PR \r\n\r\nBelow are the commands
that are affected by this change and you can test\r\nthe PR by running
below commands.\r\n\r\nEach commands sets up the test environment and
give you a command to run\r\ntests. Please run those tests to see if
everything is okay. An example\r\nis shown in below
screenshot.\r\n\r\n<img width=\"1916\"
alt=\"grafik\"\r\nsrc=\"https://github.com/user-attachments/assets/fa400450-e4aa-41dc-a1ea-ac21634c46d3\">\r\n\r\n\r\n|Module|Deployment|License|Command|\r\n|--|--|--|--|\r\n|Timelines|ESS|basic|`yarn
investigations:basic:timeline:server:ess`|\r\n|Timelines|ESS|Trial|`yarn
investigations:timeline:server:ess`|\r\n|Timelines|Serverless|basic|`yarn\r\ninvestigations:basic:timeline:server:serverless`|\r\n|Timelines|Serverless|Trial|`yarn\r\ninvestigations:timeline:server:serverless`|\r\n|Saved
Objects|ESS|basic|`yarn\r\ninvestigations:basic:saved-objects:server:ess`|\r\n|Saved
Objects|ESS|Trial|`yarn
investigations:saved-objects:server:ess`|\r\n|Saved
Objects|Serverless|basic|`yarn\r\ninvestigations:basic:saved-objects:server:serverless`|\r\n|Saved
Objects|Serverless|Trial|`yarn\r\ninvestigations:saved-objects:server:serverless`|\r\n\r\n---------\r\n\r\nCo-authored-by:
kibanamachine
<[email protected]>","sha":"2eff6d1046c94252ac0cc52f78859101383e6f71"}}]}]
BACKPORT-->

Co-authored-by: Jatin Kathuria <[email protected]>
hop-dev pushed a commit to hop-dev/kibana that referenced this pull request Oct 17, 2024
…est for MKI (elastic#194707)

## Summary

This is Part 1 of the in resolving the issue :
elastic#183645 .

This PR re-organizes investigations API tests so that they can be run in
Serveless MKI at both `basic/essentials` and `complete` licenses.

## How to test this PR 

Below are the commands that are affected by this change and you can test
the PR by running below commands.

Each commands sets up the test environment and give you a command to run
tests. Please run those tests to see if everything is okay. An example
is shown in below screenshot.

<img width="1916" alt="grafik"
src="https://github.com/user-attachments/assets/fa400450-e4aa-41dc-a1ea-ac21634c46d3">


|Module|Deployment|License|Command|
|--|--|--|--|
|Timelines|ESS|basic|`yarn investigations:basic:timeline:server:ess`|
|Timelines|ESS|Trial|`yarn investigations:timeline:server:ess`|
|Timelines|Serverless|basic|`yarn
investigations:basic:timeline:server:serverless`|
|Timelines|Serverless|Trial|`yarn
investigations:timeline:server:serverless`|
|Saved Objects|ESS|basic|`yarn
investigations:basic:saved-objects:server:ess`|
|Saved Objects|ESS|Trial|`yarn investigations:saved-objects:server:ess`|
|Saved Objects|Serverless|basic|`yarn
investigations:basic:saved-objects:server:serverless`|
|Saved Objects|Serverless|Trial|`yarn
investigations:saved-objects:server:serverless`|

---------

Co-authored-by: kibanamachine <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backport:prev-minor Backport to (8.x) the previous minor version (i.e. one version back from main) release_note:skip Skip the PR/issue when compiling release notes Team:Threat Hunting:Investigations Security Solution Investigations Team v8.16.0 v9.0.0
Projects
None yet
Development

Successfully merging this pull request may close these issues.

7 participants