Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[fix] type issue from race condition on merge #194676

Merged
merged 1 commit into from
Oct 2, 2024
Merged

[fix] type issue from race condition on merge #194676

merged 1 commit into from
Oct 2, 2024

Conversation

delanni
Copy link
Contributor

@delanni delanni commented Oct 2, 2024

Summary

#191926 introduces something that's in contradiction with #194144

This PR adds a fix.

@delanni delanni added release_note:skip Skip the PR/issue when compiling release notes backport:prev-minor Backport to (8.x) the previous minor version (i.e. one version back from main) labels Oct 2, 2024
@delanni delanni marked this pull request as ready for review October 2, 2024 09:56
@delanni delanni requested a review from a team as a code owner October 2, 2024 09:56
@delanni delanni merged commit df05976 into main Oct 2, 2024
10 of 14 checks passed
@delanni delanni deleted the fix-type-issue branch October 2, 2024 10:05
@kibanamachine
Copy link
Contributor

Starting backport for target branches: 8.x

https://github.com/elastic/kibana/actions/runs/11141839989

@kibanamachine
Copy link
Contributor

@kibana-ci
Copy link
Collaborator

💛 Build succeeded, but was flaky

Failed CI Steps

Metrics [docs]

✅ unchanged

To update your PR or re-run it, just comment with:
@elasticmachine merge upstream

@kibanamachine kibanamachine added the backport missing Added to PRs automatically when the are determined to be missing a backport. label Oct 3, 2024
@kibanamachine
Copy link
Contributor

Friendly reminder: Looks like this PR hasn’t been backported yet.
To create automatically backports add a backport:* label or prevent reminders by adding the backport:skip label.
You can also create backports manually by running node scripts/backport --pr 194676 locally

1 similar comment
@kibanamachine
Copy link
Contributor

Friendly reminder: Looks like this PR hasn’t been backported yet.
To create automatically backports add a backport:* label or prevent reminders by adding the backport:skip label.
You can also create backports manually by running node scripts/backport --pr 194676 locally

@delanni delanni added the backport:skip This commit does not require backporting label Oct 4, 2024
@kibanamachine kibanamachine removed the backport missing Added to PRs automatically when the are determined to be missing a backport. label Oct 4, 2024
@delanni delanni added backport missing Added to PRs automatically when the are determined to be missing a backport. and removed backport:prev-minor Backport to (8.x) the previous minor version (i.e. one version back from main) labels Oct 4, 2024
@kibanamachine kibanamachine removed backport missing Added to PRs automatically when the are determined to be missing a backport. labels Oct 4, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backport:skip This commit does not require backporting release_note:skip Skip the PR/issue when compiling release notes v9.0.0
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants