-
Notifications
You must be signed in to change notification settings - Fork 8.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Infra][ECO] Adding summary API #194612
[Infra][ECO] Adding summary API #194612
Conversation
Pinging @elastic/obs-ux-infra_services-team (Team:obs-ux-infra_services) |
x-pack/plugins/entity_manager/server/lib/entities/built_in/services_from_ecs_data.ts
Outdated
Show resolved
Hide resolved
…nto infra-summary-api
💛 Build succeeded, but was flaky
Failed CI StepsMetrics [docs]Module Count
Public APIs missing comments
Async chunks
Page load bundle
Unknown metric groupsAPI count
History
To update your PR or re-run it, just comment with: |
x-pack/plugins/observability_solution/observability_shared/common/field_names/elasticsearch.ts
Show resolved
Hide resolved
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Kibana.jsonc LGTM
Starting backport for target branches: 8.x |
closes elastic#193701 This PR does a few things: - Adds a new API endpoint on infra to fetch an entity summary: `/api/infra/entities/{entityType}/{entityId}/summary`. It fetches the latest EEM index filtering by entity.type(host | container) and depending on the entity type host.name or container.id. And it returns the following payload: ``` { "sourceDataStreams": [ "logs", "metrics" ], "entityId": "caues-mbp", "entityType": "host" } ``` - Fix a problem on the `Service` entity definition removing the `datastream.type` and moving it to `source_data_stream.type` due to ECS conflicts. - Moves some common field definitions to **observability-shared** plugin, and updated APM and Inventory plugin. --------- Co-authored-by: kibanamachine <[email protected]> (cherry picked from commit a91d007)
💚 All backports created successfully
Note: Successful backport PRs will be merged automatically after passing CI. Questions ?Please refer to the Backport tool documentation |
# Backport This will backport the following commits from `main` to `8.x`: - [[Infra][ECO] Adding summary API (#194612)](#194612) <!--- Backport version: 9.4.3 --> ### Questions ? Please refer to the [Backport tool documentation](https://github.com/sqren/backport) <!--BACKPORT [{"author":{"name":"Cauê Marcondes","email":"[email protected]"},"sourceCommit":{"committedDate":"2024-10-04T08:46:54Z","message":"[Infra][ECO] Adding summary API (#194612)\n\ncloses https://github.com/elastic/kibana/issues/193701\r\n\r\nThis PR does a few things:\r\n- Adds a new API endpoint on infra to fetch an entity summary:\r\n`/api/infra/entities/{entityType}/{entityId}/summary`. It fetches the\r\nlatest EEM index filtering by entity.type(host | container) and\r\ndepending on the entity type host.name or container.id. And it returns\r\nthe following payload:\r\n```\r\n{\r\n \"sourceDataStreams\": [\r\n \"logs\",\r\n \"metrics\"\r\n ],\r\n \"entityId\": \"caues-mbp\",\r\n \"entityType\": \"host\"\r\n}\r\n```\r\n- Fix a problem on the `Service` entity definition removing the\r\n`datastream.type` and moving it to `source_data_stream.type` due to ECS\r\nconflicts.\r\n- Moves some common field definitions to **observability-shared**\r\nplugin, and updated APM and Inventory plugin.\r\n\r\n---------\r\n\r\nCo-authored-by: kibanamachine <[email protected]>","sha":"a91d00731ae732c3bb2d370651048d94dd8adc2b","branchLabelMapping":{"^v9.0.0$":"main","^v8.16.0$":"8.x","^v(\\d+).(\\d+).\\d+$":"$1.$2"}},"sourcePullRequest":{"labels":["release_note:skip","v9.0.0","backport:prev-minor","ci:project-deploy-observability","Team:obs-ux-infra_services","v8.16.0"],"title":"[Infra][ECO] Adding summary API","number":194612,"url":"https://github.com/elastic/kibana/pull/194612","mergeCommit":{"message":"[Infra][ECO] Adding summary API (#194612)\n\ncloses https://github.com/elastic/kibana/issues/193701\r\n\r\nThis PR does a few things:\r\n- Adds a new API endpoint on infra to fetch an entity summary:\r\n`/api/infra/entities/{entityType}/{entityId}/summary`. It fetches the\r\nlatest EEM index filtering by entity.type(host | container) and\r\ndepending on the entity type host.name or container.id. And it returns\r\nthe following payload:\r\n```\r\n{\r\n \"sourceDataStreams\": [\r\n \"logs\",\r\n \"metrics\"\r\n ],\r\n \"entityId\": \"caues-mbp\",\r\n \"entityType\": \"host\"\r\n}\r\n```\r\n- Fix a problem on the `Service` entity definition removing the\r\n`datastream.type` and moving it to `source_data_stream.type` due to ECS\r\nconflicts.\r\n- Moves some common field definitions to **observability-shared**\r\nplugin, and updated APM and Inventory plugin.\r\n\r\n---------\r\n\r\nCo-authored-by: kibanamachine <[email protected]>","sha":"a91d00731ae732c3bb2d370651048d94dd8adc2b"}},"sourceBranch":"main","suggestedTargetBranches":["8.x"],"targetPullRequestStates":[{"branch":"main","label":"v9.0.0","branchLabelMappingKey":"^v9.0.0$","isSourceBranch":true,"state":"MERGED","url":"https://github.com/elastic/kibana/pull/194612","number":194612,"mergeCommit":{"message":"[Infra][ECO] Adding summary API (#194612)\n\ncloses https://github.com/elastic/kibana/issues/193701\r\n\r\nThis PR does a few things:\r\n- Adds a new API endpoint on infra to fetch an entity summary:\r\n`/api/infra/entities/{entityType}/{entityId}/summary`. It fetches the\r\nlatest EEM index filtering by entity.type(host | container) and\r\ndepending on the entity type host.name or container.id. And it returns\r\nthe following payload:\r\n```\r\n{\r\n \"sourceDataStreams\": [\r\n \"logs\",\r\n \"metrics\"\r\n ],\r\n \"entityId\": \"caues-mbp\",\r\n \"entityType\": \"host\"\r\n}\r\n```\r\n- Fix a problem on the `Service` entity definition removing the\r\n`datastream.type` and moving it to `source_data_stream.type` due to ECS\r\nconflicts.\r\n- Moves some common field definitions to **observability-shared**\r\nplugin, and updated APM and Inventory plugin.\r\n\r\n---------\r\n\r\nCo-authored-by: kibanamachine <[email protected]>","sha":"a91d00731ae732c3bb2d370651048d94dd8adc2b"}},{"branch":"8.x","label":"v8.16.0","branchLabelMappingKey":"^v8.16.0$","isSourceBranch":false,"state":"NOT_CREATED"}]}] BACKPORT--> Co-authored-by: Cauê Marcondes <[email protected]>
closes elastic#193701 This PR does a few things: - Adds a new API endpoint on infra to fetch an entity summary: `/api/infra/entities/{entityType}/{entityId}/summary`. It fetches the latest EEM index filtering by entity.type(host | container) and depending on the entity type host.name or container.id. And it returns the following payload: ``` { "sourceDataStreams": [ "logs", "metrics" ], "entityId": "caues-mbp", "entityType": "host" } ``` - Fix a problem on the `Service` entity definition removing the `datastream.type` and moving it to `source_data_stream.type` due to ECS conflicts. - Moves some common field definitions to **observability-shared** plugin, and updated APM and Inventory plugin. --------- Co-authored-by: kibanamachine <[email protected]>
closes #193701
This PR does a few things:
/api/infra/entities/{entityType}/{entityId}/summary
. It fetches the latest EEM index filtering by entity.type(host | container) and depending on the entity type host.name or container.id. And it returns the following payload:Service
entity definition removing thedatastream.type
and moving it tosource_data_stream.type
due to ECS conflicts.