Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[8.x] [One Discover] Add summary column for logs contextual experience (#192567) #194389

Merged
merged 1 commit into from
Sep 30, 2024

Conversation

kibanamachine
Copy link
Contributor

Backport

This will backport the following commits from main to 8.x:

Questions ?

Please refer to the Backport tool documentation

…stic#192567)

## 📓 Summary

Closes elastic/logs-dev#165

This work introduces a Summary column as a replacement for the Document
one for the Discover logs contextual experience.
> We also decided to port this change as a replacement for the
**resource** and **content** virtual columns in Logs Explorer to have a
better alignment between the 2 apps.

## 🎥 Demo

https://github.com/user-attachments/assets/3dfca483-768e-471c-8735-d5fc8bbd5d00

## 💡 Reviewer hints

I left notes through the changes to help answer some questions.

The notable changes on this PR are:
- Rename `Document` column to `Summary`.
- Refactor `resource` and `content` virtual columns into a single
`Summary` column, which replaces the default Summary content for the
logs' contextual experience.
- Provide support for the plugin services to the context awareness
profiles.
- Disable virtual columns (clean up will go in a follow-up work) in Logs
Explorer and rely on the Summary column as the default selection.

---------

Co-authored-by: Marco Antonio Ghiani <[email protected]>
Co-authored-by: kibanamachine <[email protected]>
Co-authored-by: Davis McPhee <[email protected]>
(cherry picked from commit 36a73ce)
@kibana-ci
Copy link
Collaborator

💛 Build succeeded, but was flaky

Failed CI Steps

Test Failures

  • [job] [logs] FTR Configs #11 / Cloud Security Posture Test adding Cloud Security Posture Integrations CNVM CNVM AWS Hyperlink on PostInstallation Modal should have the correct URL

Metrics [docs]

Module Count

Fewer modules leads to a faster build time

id before after diff
canvas 1292 1291 -1
cloudSecurityPosture 652 651 -1
discover 998 992 -6
esqlDataGrid 364 363 -1
eventAnnotationListing 579 578 -1
lens 1462 1461 -1
logsExplorer 563 562 -1
observability 1061 1060 -1
searchPlayground 242 241 -1
securitySolution 5929 5928 -1
slo 847 846 -1
unifiedDocViewer 221 220 -1
unifiedHistogram 186 185 -1
total -18

Public APIs missing comments

Total count of every public API that lacks a comment. Target amount is 0. Run node scripts/build_api_docs --plugin [yourplugin] --stats comments for more detailed information.

id before after diff
@kbn/unified-data-table 90 110 +20

Async chunks

Total size of all lazy-loaded chunks that will be downloaded as the user navigates the app

id before after diff
cloudSecurityPosture 506.5KB 506.8KB +317.0B
discover 815.5KB 819.2KB +3.7KB
esqlDataGrid 154.0KB 154.3KB +318.0B
logsExplorer 222.6KB 222.6KB +1.0B
securitySolution 20.5MB 20.5MB +1.6KB
slo 854.2KB 854.6KB +317.0B
unifiedDocViewer 125.9KB 125.9KB -75.0B
total +6.2KB

Page load bundle

Size of the bundles that are downloaded on every page load. Target size is below 100kb

id before after diff
discover 49.0KB 49.0KB +14.0B
logsExplorer 27.5KB 27.5KB -3.0B
total +11.0B
Unknown metric groups

API count

id before after diff
@kbn/unified-data-table 165 185 +20

async chunk count

id before after diff
discover 27 28 +1

ESLint disabled line counts

id before after diff
discover 24 27 +3

Total ESLint disabled count

id before after diff
discover 26 29 +3

To update your PR or re-run it, just comment with:
@elasticmachine merge upstream

cc @tonyghiani

@kibanamachine kibanamachine merged commit a17659f into elastic:8.x Sep 30, 2024
26 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backport ci:project-deploy-observability Create an Observability project
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants