[Dashboard] Fix share dashboard iframe embed code incorrectly #194366
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Hi @viajes7 there is a duplicate issue of the one you picked up: #193447. Since that issue was triaged to my team sooner, I already have a fix of that one which is in review: #194185. Sorry about this mixup. How do you feel about closing this PR and sticking to the one I have? I prefer my PR since it also adds tests to the fix. |
|
Hi, @tsullivan , after reviewed the pr #194185 , I think my modification is still advisable. In Consider clean code, this component is not suitable for Single Responsibility Principle. Maybe update it in On the other hand, the And I find that the Just my opinion, waiting for your news. 😄 |
@viajes7 If you can add a unit test for |
|
/ci |
|
@elasticmachine merge upstream |
|
@tsullivan Hi, Added some test cases for embed shareUrl. Please have a look, thanks. |
tsullivan
added
the
Team:SharedUX
|
Pinging @elastic/appex-sharedux (Team:SharedUX) |
tsullivan
added
release_note:fix
v8.16.0
backport:version
tsullivan
approved these changes
Oct 2, 2024
|
/ci |
1 task
💛 Build succeeded, but was flaky
Failed CI StepsMetrics [docs]Page load bundle
History
To update your PR or re-run it, just comment with: |
|
@elasticmachine run docs-build |
|
Starting backport for target branches: 8.15, 8.x |
kibanamachine
pushed a commit
to kibanamachine/kibana
that referenced
this pull request
Oct 3, 2024
…c#194366) ## Summary Fixes [elastic#192980](elastic#193447) Maybe related pr: elastic#179037 After fix it, having an URL that is like this: ``` ?embed=true&_g=(refreshInterval%3A(pause%3A!t%2Cvalue%3A60000)%2Ctime%3A(from%3Anow-15m%2Cto%3Anow))&hide-filter-bar=true ``` **Screenshot** <img width="1918" alt="image" src="https://github.com/user-attachments/assets/de069fdb-895e-479a-b868-891bbb55594e"> --------- Co-authored-by: Elastic Machine <[email protected]> Co-authored-by: Tim Sullivan <[email protected]> (cherry picked from commit e4ff3bb)
💔 Some backports could not be created
Note: Successful backport PRs will be merged automatically after passing CI. Manual backportTo create the backport manually run: Questions ?Please refer to the Backport tool documentation |
💚 All backports created successfully
Note: Successful backport PRs will be merged automatically after passing CI. Questions ?Please refer to the Backport tool documentation |
kibanamachine
added a commit
that referenced
this pull request
Oct 3, 2024
…194366) (#194773) # Backport This will backport the following commits from `main` to `8.x`: - [[Dashboard] Fix share dashboard iframe embed code incorrectly (#194366)](#194366) <!--- Backport version: 9.4.3 --> ### Questions ? Please refer to the [Backport tool documentation](https://github.com/sqren/backport) <!--BACKPORT [{"author":{"name":"Jusheng Huang","email":"[email protected]"},"sourceCommit":{"committedDate":"2024-10-03T00:24:46Z","message":"[Dashboard] Fix share dashboard iframe embed code incorrectly (#194366)\n\n## Summary\r\n\r\nFixes [#192980](https://github.com/elastic/kibana/issues/193447)\r\n\r\nMaybe related pr: #179037 \r\n\r\nAfter fix it, having an URL that is like this:\r\n```\r\n?embed=true&_g=(refreshInterval%3A(pause%3A!t%2Cvalue%3A60000)%2Ctime%3A(from%3Anow-15m%2Cto%3Anow))&hide-filter-bar=true\r\n```\r\n\r\n**Screenshot**\r\n<img width=\"1918\" alt=\"image\"\r\nsrc=\"https://github.com/user-attachments/assets/de069fdb-895e-479a-b868-891bbb55594e\">\r\n\r\n---------\r\n\r\nCo-authored-by: Elastic Machine <[email protected]>\r\nCo-authored-by: Tim Sullivan <[email protected]>","sha":"e4ff3bb44874f77a63c24de998fde2f6d7ac9404","branchLabelMapping":{"^v9.0.0$":"main","^v8.16.0$":"8.x","^v(\\d+).(\\d+).\\d+$":"$1.$2"}},"sourcePullRequest":{"labels":["release_note:fix","💝community","v9.0.0","Team:SharedUX","v8.16.0","backport:version","v8.15.3"],"title":"[Dashboard] Fix share dashboard iframe embed code incorrectly","number":194366,"url":"https://github.com/elastic/kibana/pull/194366","mergeCommit":{"message":"[Dashboard] Fix share dashboard iframe embed code incorrectly (#194366)\n\n## Summary\r\n\r\nFixes [#192980](https://github.com/elastic/kibana/issues/193447)\r\n\r\nMaybe related pr: #179037 \r\n\r\nAfter fix it, having an URL that is like this:\r\n```\r\n?embed=true&_g=(refreshInterval%3A(pause%3A!t%2Cvalue%3A60000)%2Ctime%3A(from%3Anow-15m%2Cto%3Anow))&hide-filter-bar=true\r\n```\r\n\r\n**Screenshot**\r\n<img width=\"1918\" alt=\"image\"\r\nsrc=\"https://github.com/user-attachments/assets/de069fdb-895e-479a-b868-891bbb55594e\">\r\n\r\n---------\r\n\r\nCo-authored-by: Elastic Machine <[email protected]>\r\nCo-authored-by: Tim Sullivan <[email protected]>","sha":"e4ff3bb44874f77a63c24de998fde2f6d7ac9404"}},"sourceBranch":"main","suggestedTargetBranches":["8.x","8.15"],"targetPullRequestStates":[{"branch":"main","label":"v9.0.0","branchLabelMappingKey":"^v9.0.0$","isSourceBranch":true,"state":"MERGED","url":"https://github.com/elastic/kibana/pull/194366","number":194366,"mergeCommit":{"message":"[Dashboard] Fix share dashboard iframe embed code incorrectly (#194366)\n\n## Summary\r\n\r\nFixes [#192980](https://github.com/elastic/kibana/issues/193447)\r\n\r\nMaybe related pr: #179037 \r\n\r\nAfter fix it, having an URL that is like this:\r\n```\r\n?embed=true&_g=(refreshInterval%3A(pause%3A!t%2Cvalue%3A60000)%2Ctime%3A(from%3Anow-15m%2Cto%3Anow))&hide-filter-bar=true\r\n```\r\n\r\n**Screenshot**\r\n<img width=\"1918\" alt=\"image\"\r\nsrc=\"https://github.com/user-attachments/assets/de069fdb-895e-479a-b868-891bbb55594e\">\r\n\r\n---------\r\n\r\nCo-authored-by: Elastic Machine <[email protected]>\r\nCo-authored-by: Tim Sullivan <[email protected]>","sha":"e4ff3bb44874f77a63c24de998fde2f6d7ac9404"}},{"branch":"8.x","label":"v8.16.0","branchLabelMappingKey":"^v8.16.0$","isSourceBranch":false,"state":"NOT_CREATED"},{"branch":"8.15","label":"v8.15.3","branchLabelMappingKey":"^v(\\d+).(\\d+).\\d+$","isSourceBranch":false,"state":"NOT_CREATED"}]}] BACKPORT--> Co-authored-by: Jusheng Huang <[email protected]>
tsullivan
pushed a commit
to tsullivan/kibana
that referenced
this pull request
Oct 3, 2024
…c#194366) ## Summary Fixes [elastic#192980](elastic#193447) Maybe related pr: elastic#179037 After fix it, having an URL that is like this: ``` ?embed=true&_g=(refreshInterval%3A(pause%3A!t%2Cvalue%3A60000)%2Ctime%3A(from%3Anow-15m%2Cto%3Anow))&hide-filter-bar=true ``` **Screenshot** <img width="1918" alt="image" src="https://github.com/user-attachments/assets/de069fdb-895e-479a-b868-891bbb55594e"> --------- Co-authored-by: Elastic Machine <[email protected]> Co-authored-by: Tim Sullivan <[email protected]> (cherry picked from commit e4ff3bb) # Conflicts: # src/plugins/share/public/components/share_tabs.test.tsx # src/plugins/share/public/services/share_menu_manager.tsx
|
Looks like this PR has backport PRs but they still haven't been merged. Please merge them ASAP to keep the branches relatively in sync. |
kibanamachine
added
the
backport missing
tsullivan
added a commit
that referenced
this pull request
Oct 4, 2024
…194366) (#194774) # Backport This will backport the following commits from `main` to `8.15`: - [[Dashboard] Fix share dashboard iframe embed code incorrectly (#194366)](#194366) <!--- Backport version: 8.9.8 --> ### Questions ? Please refer to the [Backport tool documentation](https://github.com/sqren/backport) <!--BACKPORT [{"author":{"name":"Jusheng Huang","email":"[email protected]"},"sourceCommit":{"committedDate":"2024-10-03T00:24:46Z","message":"[Dashboard] Fix share dashboard iframe embed code incorrectly (#194366)\n\n## Summary\r\n\r\nFixes [#192980](https://github.com/elastic/kibana/issues/193447)\r\n\r\nMaybe related pr: #179037 \r\n\r\nAfter fix it, having an URL that is like this:\r\n```\r\n?embed=true&_g=(refreshInterval%3A(pause%3A!t%2Cvalue%3A60000)%2Ctime%3A(from%3Anow-15m%2Cto%3Anow))&hide-filter-bar=true\r\n```\r\n\r\n**Screenshot**\r\n<img width=\"1918\" alt=\"image\"\r\nsrc=\"https://github.com/user-attachments/assets/de069fdb-895e-479a-b868-891bbb55594e\">\r\n\r\n---------\r\n\r\nCo-authored-by: Elastic Machine <[email protected]>\r\nCo-authored-by: Tim Sullivan <[email protected]>","sha":"e4ff3bb44874f77a63c24de998fde2f6d7ac9404","branchLabelMapping":{"^v9.0.0$":"main","^v8.16.0$":"8.x","^v(\\d+).(\\d+).\\d+$":"$1.$2"}},"sourcePullRequest":{"labels":["release_note:fix","💝community","v9.0.0","Team:SharedUX","v8.16.0","backport:version","v8.15.3"],"number":194366,"url":"https://github.com/elastic/kibana/pull/194366","mergeCommit":{"message":"[Dashboard] Fix share dashboard iframe embed code incorrectly (#194366)\n\n## Summary\r\n\r\nFixes [#192980](https://github.com/elastic/kibana/issues/193447)\r\n\r\nMaybe related pr: #179037 \r\n\r\nAfter fix it, having an URL that is like this:\r\n```\r\n?embed=true&_g=(refreshInterval%3A(pause%3A!t%2Cvalue%3A60000)%2Ctime%3A(from%3Anow-15m%2Cto%3Anow))&hide-filter-bar=true\r\n```\r\n\r\n**Screenshot**\r\n<img width=\"1918\" alt=\"image\"\r\nsrc=\"https://github.com/user-attachments/assets/de069fdb-895e-479a-b868-891bbb55594e\">\r\n\r\n---------\r\n\r\nCo-authored-by: Elastic Machine <[email protected]>\r\nCo-authored-by: Tim Sullivan <[email protected]>","sha":"e4ff3bb44874f77a63c24de998fde2f6d7ac9404"}},"sourceBranch":"main","suggestedTargetBranches":["8.15"],"targetPullRequestStates":[{"branch":"main","label":"v9.0.0","labelRegex":"^v9.0.0$","isSourceBranch":true,"state":"MERGED","url":"https://github.com/elastic/kibana/pull/194366","number":194366,"mergeCommit":{"message":"[Dashboard] Fix share dashboard iframe embed code incorrectly (#194366)\n\n## Summary\r\n\r\nFixes [#192980](https://github.com/elastic/kibana/issues/193447)\r\n\r\nMaybe related pr: #179037 \r\n\r\nAfter fix it, having an URL that is like this:\r\n```\r\n?embed=true&_g=(refreshInterval%3A(pause%3A!t%2Cvalue%3A60000)%2Ctime%3A(from%3Anow-15m%2Cto%3Anow))&hide-filter-bar=true\r\n```\r\n\r\n**Screenshot**\r\n<img width=\"1918\" alt=\"image\"\r\nsrc=\"https://github.com/user-attachments/assets/de069fdb-895e-479a-b868-891bbb55594e\">\r\n\r\n---------\r\n\r\nCo-authored-by: Elastic Machine <[email protected]>\r\nCo-authored-by: Tim Sullivan <[email protected]>","sha":"e4ff3bb44874f77a63c24de998fde2f6d7ac9404"}},{"branch":"8.x","label":"v8.16.0","labelRegex":"^v8.16.0$","isSourceBranch":false,"url":"https://github.com/elastic/kibana/pull/194773","number":194773,"state":"OPEN"},{"branch":"8.15","label":"v8.15.3","labelRegex":"^v(\\d+).(\\d+).\\d+$","isSourceBranch":false,"state":"NOT_CREATED"}]}] BACKPORT--> --------- Co-authored-by: Jusheng Huang <[email protected]> Co-authored-by: kibanamachine <[email protected]>
kibanamachine
removed
the
backport missing
tiansivive
pushed a commit
to tiansivive/kibana
that referenced
this pull request
Oct 7, 2024
…c#194366) ## Summary Fixes [elastic#192980](elastic#193447) Maybe related pr: elastic#179037 After fix it, having an URL that is like this: ``` ?embed=true&_g=(refreshInterval%3A(pause%3A!t%2Cvalue%3A60000)%2Ctime%3A(from%3Anow-15m%2Cto%3Anow))&hide-filter-bar=true ``` **Screenshot** <img width="1918" alt="image" src="https://github.com/user-attachments/assets/de069fdb-895e-479a-b868-891bbb55594e"> --------- Co-authored-by: Elastic Machine <[email protected]> Co-authored-by: Tim Sullivan <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Fixes #192980
Maybe related pr: #179037
After fix it, having an URL that is like this:
Screenshot
