[Cloud Security] 3P integrations callouts #194362
Conversation
JordanSh
added
release_note:skip
|
Pinging @elastic/kibana-cloud-security-posture (Team:Cloud Security) |
...ugins/cloud_security_posture/public/pages/configurations/findings_flyout/findings_flyout.tsx
Outdated
Show resolved
Hide resolved
...cloud_security_posture/public/pages/configurations/latest_findings/latest_findings_table.tsx
Outdated
Show resolved
Hide resolved
x-pack/plugins/cloud_security_posture/public/pages/findings/findings.tsx
Show resolved
Hide resolved
...plugins/cloud_security_posture/public/pages/vulnerabilities/latest_vulnerabilities_table.tsx
Outdated
Show resolved
Hide resolved
|
also the callout looks a bit weird in the empty state, as we are duplicating the information we already have on the empty state tile 
|
I wanted to fix it but TBH im not sure what is the correct behaviour. if we only display is when there is a table, and we have two tables on one page, does it appear and disappear if only one tab has a table? The other option is that we have a callout for each table, above the table itself instead of above the tabs. but it means users will have to close this box twice. I'm not sure what is the best solution, right now im tending into leaving it as it. we change later if product will have another idea |
…h/kibana into 3p-integrations-callouts
| if (dataset === WIZ_MISCONFIGURATIONS_DATASET || dataset === WIZ_VULN_DATASET) return 'Wiz'; | ||
| if (dataset === CSP_MISCONFIGURATIONS_DATASET || dataset === CSP_VULN_DATASET) | ||
| return 'Elastic CSP'; | ||
| if (dataset === CSP_MISCONFIGURATIONS_DATASET || dataset === CSP_VULN_DATASET) return 'Elastic'; |
…h/kibana into 3p-integrations-callouts
💛 Build succeeded, but was flaky
Failed CI StepsMetrics [docs]Module Count
Public APIs missing comments
Async chunks
Public APIs missing exports
History
To update your PR or re-run it, just comment with: cc @JordanSh |
|
Starting backport for target branches: 8.x |
(cherry picked from commit d3f3d34)
💚 All backports created successfully
Note: Successful backport PRs will be merged automatically after passing CI. Questions ?Please refer to the Backport tool documentation |
# Backport This will backport the following commits from `main` to `8.x`: - [[Cloud Security] 3P integrations callouts (#194362)](#194362) <!--- Backport version: 9.4.3 --> ### Questions ? Please refer to the [Backport tool documentation](https://github.com/sqren/backport) <!--BACKPORT [{"author":{"name":"Jordan","email":"[email protected]"},"sourceCommit":{"committedDate":"2024-10-04T17:27:56Z","message":"[Cloud Security] 3P integrations callouts (#194362)","sha":"d3f3d34519c0be68f1660f3bd6c82540e6d97b90","branchLabelMapping":{"^v9.0.0$":"main","^v8.16.0$":"8.x","^v(\\d+).(\\d+).\\d+$":"$1.$2"}},"sourcePullRequest":{"labels":["release_note:skip","v9.0.0","Team:Cloud Security","backport:prev-minor"],"title":"[Cloud Security] 3P integrations callouts","number":194362,"url":"https://github.com/elastic/kibana/pull/194362","mergeCommit":{"message":"[Cloud Security] 3P integrations callouts (#194362)","sha":"d3f3d34519c0be68f1660f3bd6c82540e6d97b90"}},"sourceBranch":"main","suggestedTargetBranches":[],"targetPullRequestStates":[{"branch":"main","label":"v9.0.0","branchLabelMappingKey":"^v9.0.0$","isSourceBranch":true,"state":"MERGED","url":"https://github.com/elastic/kibana/pull/194362","number":194362,"mergeCommit":{"message":"[Cloud Security] 3P integrations callouts (#194362)","sha":"d3f3d34519c0be68f1660f3bd6c82540e6d97b90"}}]}] BACKPORT--> Co-authored-by: Jordan <[email protected]>
Summary
Adding PLG callouts for Wiz integration in the findings pages, while also addressing some minor bugs and changes revolving around the 3P workflows changes
Resolves #187571
Resolves #194383
Resolves #189617
Screen.Recording.2024-09-29.at.18.07.54.mov
Screen.Recording.2024-09-29.at.20.44.51.mov