[Inventory] Promote new inventory plugin in APM #193997
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
iblancof
added
release_note:skip
|
Pinging @elastic/obs-ux-infra_services-team (Team:obs-ux-infra_services) |
botelastic
bot
added
the
ci:project-deploy-observability
🤖 GitHub commentsExpand to view the GitHub comments
Just comment with:
|
|
Goodbye New Service inventory page 👋🏻 |
...s/observability_solution/apm/public/components/routing/templates/apm_main_template/index.tsx
Outdated
Show resolved
Hide resolved
...s/observability_solution/apm/public/components/routing/templates/apm_main_template/index.tsx
Outdated
Show resolved
Hide resolved
...s/observability_solution/apm/public/components/routing/templates/apm_main_template/index.tsx
Outdated
Show resolved
Hide resolved
...ity_solution/apm/public/components/routing/templates/apm_main_template/inventory_callout.tsx
Outdated
Show resolved
Hide resolved
x-pack/plugins/observability_solution/inventory/public/plugin.ts
Outdated
Show resolved
Hide resolved
|
Can we revert the value set on Or maybe stop looking at it and always render the apm service inventory page. 
|
kpatticha
reviewed
Sep 25, 2024
...ity_solution/apm/public/components/routing/templates/apm_main_template/inventory_callout.tsx
Outdated
Show resolved
Hide resolved
…s://github.com/iblancof/kibana into 192856-apm-promote-new-inventory-plugin-in-apm
kpatticha
approved these changes
Sep 27, 2024
💛 Build succeeded, but was flaky
Failed CI StepsTest Failures
Metrics [docs]Module Count
Public APIs missing comments
Async chunks
Page load bundle
Unknown metric groupsAPI count
miscellaneous assets size
History
To update your PR or re-run it, just comment with: cc @iblancof |
|
Starting backport for target branches: 8.x |
kibanamachine
pushed a commit
to kibanamachine/kibana
that referenced
this pull request
Sep 30, 2024
## Summary Closes elastic#192856. This PR removes the ability to enable the new APM experience and replaces it with a link promoting the new Inventory feature.  --------- Co-authored-by: kibanamachine <[email protected]> (cherry picked from commit 9f9d911)
💚 All backports created successfully
Note: Successful backport PRs will be merged automatically after passing CI. Questions ?Please refer to the Backport tool documentation |
kibanamachine
added a commit
that referenced
this pull request
Sep 30, 2024
) # Backport This will backport the following commits from `main` to `8.x`: - [[Inventory] Promote new inventory plugin in APM (#193997)](#193997) <!--- Backport version: 9.4.3 --> ### Questions ? Please refer to the [Backport tool documentation](https://github.com/sqren/backport) <!--BACKPORT [{"author":{"name":"Irene Blanco","email":"[email protected]"},"sourceCommit":{"committedDate":"2024-09-30T14:38:45Z","message":"[Inventory] Promote new inventory plugin in APM (#193997)\n\n## Summary\r\n\r\nCloses https://github.com/elastic/kibana/issues/192856.\r\n\r\nThis PR removes the ability to enable the new APM experience and\r\nreplaces it with a link promoting the new Inventory feature.\r\n\r\n\r\n\r\n---------\r\n\r\nCo-authored-by: kibanamachine <[email protected]>","sha":"9f9d911dbacc45729fd6e93bad0e08a761eb8823","branchLabelMapping":{"^v9.0.0$":"main","^v8.16.0$":"8.x","^v(\\d+).(\\d+).\\d+$":"$1.$2"}},"sourcePullRequest":{"labels":["release_note:skip","v9.0.0","backport:prev-minor","ci:project-deploy-observability","Team:obs-ux-infra_services","v8.16.0"],"title":"[Inventory] Promote new inventory plugin in APM","number":193997,"url":"https://github.com/elastic/kibana/pull/193997","mergeCommit":{"message":"[Inventory] Promote new inventory plugin in APM (#193997)\n\n## Summary\r\n\r\nCloses https://github.com/elastic/kibana/issues/192856.\r\n\r\nThis PR removes the ability to enable the new APM experience and\r\nreplaces it with a link promoting the new Inventory feature.\r\n\r\n\r\n\r\n---------\r\n\r\nCo-authored-by: kibanamachine <[email protected]>","sha":"9f9d911dbacc45729fd6e93bad0e08a761eb8823"}},"sourceBranch":"main","suggestedTargetBranches":["8.x"],"targetPullRequestStates":[{"branch":"main","label":"v9.0.0","branchLabelMappingKey":"^v9.0.0$","isSourceBranch":true,"state":"MERGED","url":"https://github.com/elastic/kibana/pull/193997","number":193997,"mergeCommit":{"message":"[Inventory] Promote new inventory plugin in APM (#193997)\n\n## Summary\r\n\r\nCloses https://github.com/elastic/kibana/issues/192856.\r\n\r\nThis PR removes the ability to enable the new APM experience and\r\nreplaces it with a link promoting the new Inventory feature.\r\n\r\n\r\n\r\n---------\r\n\r\nCo-authored-by: kibanamachine <[email protected]>","sha":"9f9d911dbacc45729fd6e93bad0e08a761eb8823"}},{"branch":"8.x","label":"v8.16.0","branchLabelMappingKey":"^v8.16.0$","isSourceBranch":false,"state":"NOT_CREATED"}]}] BACKPORT--> Co-authored-by: Irene Blanco <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Closes #192856.
This PR removes the ability to enable the new APM experience and replaces it with a link promoting the new Inventory feature.