-
Notifications
You must be signed in to change notification settings - Fork 8.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Stateful sidenav] Update docs #193988
Merged
Merged
[Stateful sidenav] Update docs #193988
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sebelga
added
release_note:skip
Skip the PR/issue when compiling release notes
docs
Team:SharedUX
Team label for AppEx-SharedUX (formerly Global Experience)
backport:prev-minor
Backport to (8.x) the previous minor version (i.e. one version back from main)
labels
Sep 25, 2024
Pinging @elastic/appex-sharedux (Team:SharedUX) |
💚 Build Succeeded
To update your PR or re-run it, just comment with: |
Dosant
approved these changes
Sep 25, 2024
kibanamachine
pushed a commit
to kibanamachine/kibana
that referenced
this pull request
Sep 26, 2024
(cherry picked from commit 650c730)
💚 All backports created successfully
Note: Successful backport PRs will be merged automatically after passing CI. Questions ?Please refer to the Backport tool documentation |
kibanamachine
added a commit
that referenced
this pull request
Sep 26, 2024
# Backport This will backport the following commits from `main` to `8.x`: - [[Stateful sidenav] Update docs (#193988)](#193988) <!--- Backport version: 9.4.3 --> ### Questions ? Please refer to the [Backport tool documentation](https://github.com/sqren/backport) <!--BACKPORT [{"author":{"name":"Sébastien Loix","email":"[email protected]"},"sourceCommit":{"committedDate":"2024-09-26T12:17:56Z","message":"[Stateful sidenav] Update docs (#193988)","sha":"650c730c209743779e5c8980311693d1e3e117eb","branchLabelMapping":{"^v9.0.0$":"main","^v8.16.0$":"8.x","^v(\\d+).(\\d+).\\d+$":"$1.$2"}},"sourcePullRequest":{"labels":["release_note:skip","v9.0.0","docs","Team:SharedUX","backport:prev-minor"],"title":"[Stateful sidenav] Update docs","number":193988,"url":"https://github.com/elastic/kibana/pull/193988","mergeCommit":{"message":"[Stateful sidenav] Update docs (#193988)","sha":"650c730c209743779e5c8980311693d1e3e117eb"}},"sourceBranch":"main","suggestedTargetBranches":[],"targetPullRequestStates":[{"branch":"main","label":"v9.0.0","branchLabelMappingKey":"^v9.0.0$","isSourceBranch":true,"state":"MERGED","url":"https://github.com/elastic/kibana/pull/193988","number":193988,"mergeCommit":{"message":"[Stateful sidenav] Update docs (#193988)","sha":"650c730c209743779e5c8980311693d1e3e117eb"}}]}] BACKPORT--> Co-authored-by: Sébastien Loix <[email protected]>
Merged
bmorelli25
added a commit
that referenced
this pull request
Sep 26, 2024
`kibDevTutorialsServerlessProjectNavigation` was changed to `kibDevTutorialsSolutionNavigation` in #193988 but they missed one. This PR fixes the failing docs.elastic.dev build.
kibanamachine
pushed a commit
to kibanamachine/kibana
that referenced
this pull request
Oct 9, 2024
`kibDevTutorialsServerlessProjectNavigation` was changed to `kibDevTutorialsSolutionNavigation` in elastic#193988 but they missed one. This PR fixes the failing docs.elastic.dev build. (cherry picked from commit 4bebd25)
kibanamachine
added a commit
that referenced
this pull request
Oct 9, 2024
# Backport This will backport the following commits from `main` to `8.x`: - [Fix dev docs (#194229)](#194229) <!--- Backport version: 9.4.3 --> ### Questions ? Please refer to the [Backport tool documentation](https://github.com/sqren/backport) <!--BACKPORT [{"author":{"name":"Brandon Morelli","email":"[email protected]"},"sourceCommit":{"committedDate":"2024-09-26T21:32:03Z","message":"Fix dev docs (#194229)\n\n`kibDevTutorialsServerlessProjectNavigation`\r\nwas changed to\r\n`kibDevTutorialsSolutionNavigation`\r\nin\r\nhttps://github.com//pull/193988\r\n\r\nbut they missed one. This PR fixes the failing docs.elastic.dev build.","sha":"4bebd2539f59b400456a2f25d59c038c87563181","branchLabelMapping":{"^v9.0.0$":"main","^v8.16.0$":"8.x","^v(\\d+).(\\d+).\\d+$":"$1.$2"}},"sourcePullRequest":{"labels":["release_note:skip","v9.0.0","backport:prev-minor","v8.16.0"],"title":"Fix dev docs","number":194229,"url":"https://github.com/elastic/kibana/pull/194229","mergeCommit":{"message":"Fix dev docs (#194229)\n\n`kibDevTutorialsServerlessProjectNavigation`\r\nwas changed to\r\n`kibDevTutorialsSolutionNavigation`\r\nin\r\nhttps://github.com//pull/193988\r\n\r\nbut they missed one. This PR fixes the failing docs.elastic.dev build.","sha":"4bebd2539f59b400456a2f25d59c038c87563181"}},"sourceBranch":"main","suggestedTargetBranches":["8.x"],"targetPullRequestStates":[{"branch":"main","label":"v9.0.0","branchLabelMappingKey":"^v9.0.0$","isSourceBranch":true,"state":"MERGED","url":"https://github.com/elastic/kibana/pull/194229","number":194229,"mergeCommit":{"message":"Fix dev docs (#194229)\n\n`kibDevTutorialsServerlessProjectNavigation`\r\nwas changed to\r\n`kibDevTutorialsSolutionNavigation`\r\nin\r\nhttps://github.com//pull/193988\r\n\r\nbut they missed one. This PR fixes the failing docs.elastic.dev build.","sha":"4bebd2539f59b400456a2f25d59c038c87563181"}},{"branch":"8.x","label":"v8.16.0","branchLabelMappingKey":"^v8.16.0$","isSourceBranch":false,"state":"NOT_CREATED"}]}] BACKPORT--> Co-authored-by: Brandon Morelli <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
backport:prev-minor
Backport to (8.x) the previous minor version (i.e. one version back from main)
docs
release_note:skip
Skip the PR/issue when compiling release notes
Team:SharedUX
Team label for AppEx-SharedUX (formerly Global Experience)
v8.16.0
v9.0.0
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In this PR I've updated the documentation of the side nav to include both serverless and stateful.
The documentation was previously only mentioning serverless projects and we need to make it include the solution navigation in stateful.