Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Fleet] Document space awareness #193963

Merged
merged 3 commits into from
Sep 26, 2024

Conversation

nchaulet
Copy link
Member

@nchaulet nchaulet commented Sep 25, 2024

Summary

Add some developer documentation on how to develop to support a space aware Fleet, especially document which saved object client could be used in different scenario.

@nchaulet nchaulet added release_note:skip Skip the PR/issue when compiling release notes Team:Fleet Team label for Observability Data Collection Fleet team backport:prev-minor Backport to (8.x) the previous minor version (i.e. one version back from main) v8.16.0 labels Sep 25, 2024
@nchaulet nchaulet self-assigned this Sep 25, 2024
@nchaulet nchaulet requested a review from a team as a code owner September 25, 2024 10:28
@elasticmachine
Copy link
Contributor

Pinging @elastic/fleet (Team:Fleet)

@obltmachine
Copy link

🤖 GitHub comments

Expand to view the GitHub comments

Just comment with:

  • /oblt-deploy : Deploy a Kibana instance using the Observability test environments.
  • run docs-build : Re-trigger the docs validation. (use unformatted text in the comment!)

x-pack/plugins/fleet/dev_docs/space_awareness.md Outdated Show resolved Hide resolved
x-pack/plugins/fleet/dev_docs/space_awareness.md Outdated Show resolved Hide resolved
x-pack/plugins/fleet/dev_docs/space_awareness.md Outdated Show resolved Hide resolved
x-pack/plugins/fleet/dev_docs/space_awareness.md Outdated Show resolved Hide resolved
x-pack/plugins/fleet/dev_docs/space_awareness.md Outdated Show resolved Hide resolved
@nchaulet nchaulet requested a review from jen-huang September 26, 2024 08:42
Copy link
Contributor

@jen-huang jen-huang left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the changes, LGTM

@jen-huang jen-huang merged commit 641eee0 into elastic:main Sep 26, 2024
9 checks passed
@kibanamachine
Copy link
Contributor

Starting backport for target branches: 8.x

https://github.com/elastic/kibana/actions/runs/11058847861

kibanamachine pushed a commit to kibanamachine/kibana that referenced this pull request Sep 26, 2024
## Summary

Add some developer documentation on how to develop to support a space
aware Fleet, especially document which saved object client could be used
in different scenario.

---------

Co-authored-by: Jen Huang <[email protected]>
(cherry picked from commit 641eee0)
@kibanamachine
Copy link
Contributor

💚 All backports created successfully

Status Branch Result
8.x

Note: Successful backport PRs will be merged automatically after passing CI.

Questions ?

Please refer to the Backport tool documentation

kibanamachine added a commit that referenced this pull request Sep 26, 2024
# Backport

This will backport the following commits from `main` to `8.x`:
- [[Fleet] Document space awareness
(#193963)](#193963)

<!--- Backport version: 9.4.3 -->

### Questions ?
Please refer to the [Backport tool
documentation](https://github.com/sqren/backport)

<!--BACKPORT [{"author":{"name":"Nicolas
Chaulet","email":"[email protected]"},"sourceCommit":{"committedDate":"2024-09-26T19:20:43Z","message":"[Fleet]
Document space awareness (#193963)\n\n## Summary\r\n\r\nAdd some
developer documentation on how to develop to support a space\r\naware
Fleet, especially document which saved object client could be used\r\nin
different scenario.\r\n\r\n---------\r\n\r\nCo-authored-by: Jen Huang
<[email protected]>","sha":"641eee0a2d09f00593daed57c3152e4ee0160fe7","branchLabelMapping":{"^v9.0.0$":"main","^v8.16.0$":"8.x","^v(\\d+).(\\d+).\\d+$":"$1.$2"}},"sourcePullRequest":{"labels":["release_note:skip","Team:Fleet","v9.0.0","backport:prev-minor","v8.16.0"],"title":"[Fleet]
Document space
awareness","number":193963,"url":"https://github.com/elastic/kibana/pull/193963","mergeCommit":{"message":"[Fleet]
Document space awareness (#193963)\n\n## Summary\r\n\r\nAdd some
developer documentation on how to develop to support a space\r\naware
Fleet, especially document which saved object client could be used\r\nin
different scenario.\r\n\r\n---------\r\n\r\nCo-authored-by: Jen Huang
<[email protected]>","sha":"641eee0a2d09f00593daed57c3152e4ee0160fe7"}},"sourceBranch":"main","suggestedTargetBranches":["8.x"],"targetPullRequestStates":[{"branch":"main","label":"v9.0.0","branchLabelMappingKey":"^v9.0.0$","isSourceBranch":true,"state":"MERGED","url":"https://github.com/elastic/kibana/pull/193963","number":193963,"mergeCommit":{"message":"[Fleet]
Document space awareness (#193963)\n\n## Summary\r\n\r\nAdd some
developer documentation on how to develop to support a space\r\naware
Fleet, especially document which saved object client could be used\r\nin
different scenario.\r\n\r\n---------\r\n\r\nCo-authored-by: Jen Huang
<[email protected]>","sha":"641eee0a2d09f00593daed57c3152e4ee0160fe7"}},{"branch":"8.x","label":"v8.16.0","branchLabelMappingKey":"^v8.16.0$","isSourceBranch":false,"state":"NOT_CREATED"}]}]
BACKPORT-->

Co-authored-by: Nicolas Chaulet <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backport:prev-minor Backport to (8.x) the previous minor version (i.e. one version back from main) release_note:skip Skip the PR/issue when compiling release notes Team:Fleet Team label for Observability Data Collection Fleet team v8.16.0 v9.0.0
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants