feat(rca): add external incident url #193919
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
🤖 GitHub commentsExpand to view the GitHub comments
Just comment with:
|
kdelemme
added
backport:prev-minor
|
Pinging @elastic/obs-ux-management-team (Team:obs-ux-management) |
kdelemme
force-pushed
the
rca/external-links
branch
from
6575855 to
ca51e9c
Compare
botelastic
bot
added
the
ci:project-deploy-observability
shahzad31
reviewed
Sep 25, 2024
| defaultValues: { title: 'New investigation', status: 'triage', tags: [] }, | ||
| values: investigation ? pick(investigation, ['title', 'status', 'tags']) : undefined, | ||
| defaultValues: { | ||
| title: 'New investigation', |
💛 Build succeeded, but was flaky
Failed CI StepsMetrics [docs]Module Count
Async chunks
History
To update your PR or re-run it, just comment with: cc @kdelemme |
kibanamachine
pushed a commit
to kibanamachine/kibana
that referenced
this pull request
Sep 25, 2024
(cherry picked from commit 5d51da9)
💚 All backports created successfully
Note: Successful backport PRs will be merged automatically after passing CI. Questions ?Please refer to the Backport tool documentation |
kibanamachine
added a commit
that referenced
this pull request
Sep 25, 2024
# Backport This will backport the following commits from `main` to `8.x`: - [feat(rca): add external incident url (#193919)](#193919) <!--- Backport version: 9.4.3 --> ### Questions ? Please refer to the [Backport tool documentation](https://github.com/sqren/backport) <!--BACKPORT [{"author":{"name":"Kevin Delemme","email":"[email protected]"},"sourceCommit":{"committedDate":"2024-09-25T15:19:11Z","message":"feat(rca): add external incident url (#193919)","sha":"5d51da90f626606ef6ea217e4b0be68e85aaa86c","branchLabelMapping":{"^v9.0.0$":"main","^v8.16.0$":"8.x","^v(\\d+).(\\d+).\\d+$":"$1.$2"}},"sourcePullRequest":{"labels":["release_note:skip","v9.0.0","backport:prev-minor","ci:project-deploy-observability","Team:obs-ux-management","v8.16.0"],"title":"feat(rca): add external incident url","number":193919,"url":"https://github.com/elastic/kibana/pull/193919","mergeCommit":{"message":"feat(rca): add external incident url (#193919)","sha":"5d51da90f626606ef6ea217e4b0be68e85aaa86c"}},"sourceBranch":"main","suggestedTargetBranches":["8.x"],"targetPullRequestStates":[{"branch":"main","label":"v9.0.0","branchLabelMappingKey":"^v9.0.0$","isSourceBranch":true,"state":"MERGED","url":"https://github.com/elastic/kibana/pull/193919","number":193919,"mergeCommit":{"message":"feat(rca): add external incident url (#193919)","sha":"5d51da90f626606ef6ea217e4b0be68e85aaa86c"}},{"branch":"8.x","label":"v8.16.0","branchLabelMappingKey":"^v8.16.0$","isSourceBranch":false,"state":"NOT_CREATED"}]}] BACKPORT--> Co-authored-by: Kevin Delemme <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
resolves #192589
Summary
This PR adds a simple
externalIncidentUrlinto the schema and the form. We display the link in the header when provided.