[map embeddable] fix panel disappears from dashboard when canceling edit after dashboard save #193911
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nreese
added
v9.0.0
v8.16.0
backport:version
|
/ci |
nreese
changed the title
nreese
commented
Sep 24, 2024
| return MAP_EMBEDDABLE_NAME; | ||
| }, | ||
| onEdit: async () => { | ||
| const parentApiContext = parentApi.getAppContext(); |
There was a problem hiding this comment.
This is the fix. Call getAppContext inside the scope of onEdit
nreese
added
release_note:fix
Team:Presentation
|
Pinging @elastic/kibana-presentation (Team:Presentation) |
nickpeihl
approved these changes
Sep 24, 2024
💚 Build Succeeded
Metrics [docs]Async chunks
To update your PR or re-run it, just comment with: |
kibanamachine
pushed a commit
to kibanamachine/kibana
that referenced
this pull request
Sep 24, 2024
…dit after dashboard save (elastic#193911) Part of elastic#193905. Broke work into separate PRs to backport map embeddable changes to 8.15. Resolves issue for Map embeddable. The problem is that Map embeddable is using a stale result from `parentApi.getAppContext`. Dashboard's `getAppContext` changes the `getCurrentPath` when the dashboard has a saved object id. By using the stale results, `getCurrentPath` returned `#/create` instead of `#/view/`. ### Test steps 1. create new dashboard 2. Click "Add panel" (problem also exists when using "Add from library") 3. Select "Maps" 4. In editor, click "Save and return" 5. Save dashboard 6. Click "Edit" in panel context menu 7. In editor, click "Cancel" 8. Ensure map panel is still displayed in dashboard (cherry picked from commit 882b6fb)
kibanamachine
pushed a commit
to kibanamachine/kibana
that referenced
this pull request
Sep 24, 2024
…dit after dashboard save (elastic#193911) Part of elastic#193905. Broke work into separate PRs to backport map embeddable changes to 8.15. Resolves issue for Map embeddable. The problem is that Map embeddable is using a stale result from `parentApi.getAppContext`. Dashboard's `getAppContext` changes the `getCurrentPath` when the dashboard has a saved object id. By using the stale results, `getCurrentPath` returned `#/create` instead of `#/view/`. ### Test steps 1. create new dashboard 2. Click "Add panel" (problem also exists when using "Add from library") 3. Select "Maps" 4. In editor, click "Save and return" 5. Save dashboard 6. Click "Edit" in panel context menu 7. In editor, click "Cancel" 8. Ensure map panel is still displayed in dashboard (cherry picked from commit 882b6fb)
💚 All backports created successfully
Note: Successful backport PRs will be merged automatically after passing CI. Questions ?Please refer to the Backport tool documentation |
kibanamachine
added a commit
that referenced
this pull request
Sep 24, 2024
…ling edit after dashboard save (#193911) (#193929) # Backport This will backport the following commits from `main` to `8.x`: - [[map embeddable] fix panel disappears from dashboard when canceling edit after dashboard save (#193911)](#193911) <!--- Backport version: 9.4.3 --> ### Questions ? Please refer to the [Backport tool documentation](https://github.com/sqren/backport) <!--BACKPORT [{"author":{"name":"Nathan Reese","email":"[email protected]"},"sourceCommit":{"committedDate":"2024-09-24T22:13:10Z","message":"[map embeddable] fix panel disappears from dashboard when canceling edit after dashboard save (#193911)\n\nPart of #193905. Broke work into\r\nseparate PRs to backport map embeddable changes to 8.15.\r\n\r\nResolves issue for Map embeddable. The problem is that Map embeddable is\r\nusing a stale result from `parentApi.getAppContext`. Dashboard's\r\n`getAppContext` changes the `getCurrentPath` when the dashboard has a\r\nsaved object id. By using the stale results, `getCurrentPath` returned\r\n`#/create` instead of `#/view/`.\r\n\r\n### Test steps\r\n1. create new dashboard\r\n2. Click \"Add panel\" (problem also exists when using \"Add from library\")\r\n3. Select \"Maps\"\r\n4. In editor, click \"Save and return\"\r\n5. Save dashboard\r\n6. Click \"Edit\" in panel context menu\r\n7. In editor, click \"Cancel\"\r\n8. Ensure map panel is still displayed in dashboard","sha":"882b6fb2f5ebef289dcbbf487ce42f83b95cc58e","branchLabelMapping":{"^v9.0.0$":"main","^v8.16.0$":"8.x","^v(\\d+).(\\d+).\\d+$":"$1.$2"}},"sourcePullRequest":{"labels":["release_note:fix","Team:Presentation","v9.0.0","v8.16.0","backport:version","v8.15.3"],"title":"[map embeddable] fix panel disappears from dashboard when canceling edit after dashboard save","number":193911,"url":"https://github.com/elastic/kibana/pull/193911","mergeCommit":{"message":"[map embeddable] fix panel disappears from dashboard when canceling edit after dashboard save (#193911)\n\nPart of #193905. Broke work into\r\nseparate PRs to backport map embeddable changes to 8.15.\r\n\r\nResolves issue for Map embeddable. The problem is that Map embeddable is\r\nusing a stale result from `parentApi.getAppContext`. Dashboard's\r\n`getAppContext` changes the `getCurrentPath` when the dashboard has a\r\nsaved object id. By using the stale results, `getCurrentPath` returned\r\n`#/create` instead of `#/view/`.\r\n\r\n### Test steps\r\n1. create new dashboard\r\n2. Click \"Add panel\" (problem also exists when using \"Add from library\")\r\n3. Select \"Maps\"\r\n4. In editor, click \"Save and return\"\r\n5. Save dashboard\r\n6. Click \"Edit\" in panel context menu\r\n7. In editor, click \"Cancel\"\r\n8. Ensure map panel is still displayed in dashboard","sha":"882b6fb2f5ebef289dcbbf487ce42f83b95cc58e"}},"sourceBranch":"main","suggestedTargetBranches":["8.x","8.15"],"targetPullRequestStates":[{"branch":"main","label":"v9.0.0","branchLabelMappingKey":"^v9.0.0$","isSourceBranch":true,"state":"MERGED","url":"https://github.com/elastic/kibana/pull/193911","number":193911,"mergeCommit":{"message":"[map embeddable] fix panel disappears from dashboard when canceling edit after dashboard save (#193911)\n\nPart of #193905. Broke work into\r\nseparate PRs to backport map embeddable changes to 8.15.\r\n\r\nResolves issue for Map embeddable. The problem is that Map embeddable is\r\nusing a stale result from `parentApi.getAppContext`. Dashboard's\r\n`getAppContext` changes the `getCurrentPath` when the dashboard has a\r\nsaved object id. By using the stale results, `getCurrentPath` returned\r\n`#/create` instead of `#/view/`.\r\n\r\n### Test steps\r\n1. create new dashboard\r\n2. Click \"Add panel\" (problem also exists when using \"Add from library\")\r\n3. Select \"Maps\"\r\n4. In editor, click \"Save and return\"\r\n5. Save dashboard\r\n6. Click \"Edit\" in panel context menu\r\n7. In editor, click \"Cancel\"\r\n8. Ensure map panel is still displayed in dashboard","sha":"882b6fb2f5ebef289dcbbf487ce42f83b95cc58e"}},{"branch":"8.x","label":"v8.16.0","branchLabelMappingKey":"^v8.16.0$","isSourceBranch":false,"state":"NOT_CREATED"},{"branch":"8.15","label":"v8.15.3","branchLabelMappingKey":"^v(\\d+).(\\d+).\\d+$","isSourceBranch":false,"state":"NOT_CREATED"}]}] BACKPORT--> Co-authored-by: Nathan Reese <[email protected]>
kibanamachine
added a commit
that referenced
this pull request
Sep 24, 2024
…eling edit after dashboard save (#193911) (#193928) # Backport This will backport the following commits from `main` to `8.15`: - [[map embeddable] fix panel disappears from dashboard when canceling edit after dashboard save (#193911)](#193911) <!--- Backport version: 9.4.3 --> ### Questions ? Please refer to the [Backport tool documentation](https://github.com/sqren/backport) <!--BACKPORT [{"author":{"name":"Nathan Reese","email":"[email protected]"},"sourceCommit":{"committedDate":"2024-09-24T22:13:10Z","message":"[map embeddable] fix panel disappears from dashboard when canceling edit after dashboard save (#193911)\n\nPart of #193905. Broke work into\r\nseparate PRs to backport map embeddable changes to 8.15.\r\n\r\nResolves issue for Map embeddable. The problem is that Map embeddable is\r\nusing a stale result from `parentApi.getAppContext`. Dashboard's\r\n`getAppContext` changes the `getCurrentPath` when the dashboard has a\r\nsaved object id. By using the stale results, `getCurrentPath` returned\r\n`#/create` instead of `#/view/`.\r\n\r\n### Test steps\r\n1. create new dashboard\r\n2. Click \"Add panel\" (problem also exists when using \"Add from library\")\r\n3. Select \"Maps\"\r\n4. In editor, click \"Save and return\"\r\n5. Save dashboard\r\n6. Click \"Edit\" in panel context menu\r\n7. In editor, click \"Cancel\"\r\n8. Ensure map panel is still displayed in dashboard","sha":"882b6fb2f5ebef289dcbbf487ce42f83b95cc58e","branchLabelMapping":{"^v9.0.0$":"main","^v8.16.0$":"8.x","^v(\\d+).(\\d+).\\d+$":"$1.$2"}},"sourcePullRequest":{"labels":["release_note:fix","Team:Presentation","v9.0.0","v8.16.0","backport:version","v8.15.3"],"title":"[map embeddable] fix panel disappears from dashboard when canceling edit after dashboard save","number":193911,"url":"https://github.com/elastic/kibana/pull/193911","mergeCommit":{"message":"[map embeddable] fix panel disappears from dashboard when canceling edit after dashboard save (#193911)\n\nPart of #193905. Broke work into\r\nseparate PRs to backport map embeddable changes to 8.15.\r\n\r\nResolves issue for Map embeddable. The problem is that Map embeddable is\r\nusing a stale result from `parentApi.getAppContext`. Dashboard's\r\n`getAppContext` changes the `getCurrentPath` when the dashboard has a\r\nsaved object id. By using the stale results, `getCurrentPath` returned\r\n`#/create` instead of `#/view/`.\r\n\r\n### Test steps\r\n1. create new dashboard\r\n2. Click \"Add panel\" (problem also exists when using \"Add from library\")\r\n3. Select \"Maps\"\r\n4. In editor, click \"Save and return\"\r\n5. Save dashboard\r\n6. Click \"Edit\" in panel context menu\r\n7. In editor, click \"Cancel\"\r\n8. Ensure map panel is still displayed in dashboard","sha":"882b6fb2f5ebef289dcbbf487ce42f83b95cc58e"}},"sourceBranch":"main","suggestedTargetBranches":["8.x","8.15"],"targetPullRequestStates":[{"branch":"main","label":"v9.0.0","branchLabelMappingKey":"^v9.0.0$","isSourceBranch":true,"state":"MERGED","url":"https://github.com/elastic/kibana/pull/193911","number":193911,"mergeCommit":{"message":"[map embeddable] fix panel disappears from dashboard when canceling edit after dashboard save (#193911)\n\nPart of #193905. Broke work into\r\nseparate PRs to backport map embeddable changes to 8.15.\r\n\r\nResolves issue for Map embeddable. The problem is that Map embeddable is\r\nusing a stale result from `parentApi.getAppContext`. Dashboard's\r\n`getAppContext` changes the `getCurrentPath` when the dashboard has a\r\nsaved object id. By using the stale results, `getCurrentPath` returned\r\n`#/create` instead of `#/view/`.\r\n\r\n### Test steps\r\n1. create new dashboard\r\n2. Click \"Add panel\" (problem also exists when using \"Add from library\")\r\n3. Select \"Maps\"\r\n4. In editor, click \"Save and return\"\r\n5. Save dashboard\r\n6. Click \"Edit\" in panel context menu\r\n7. In editor, click \"Cancel\"\r\n8. Ensure map panel is still displayed in dashboard","sha":"882b6fb2f5ebef289dcbbf487ce42f83b95cc58e"}},{"branch":"8.x","label":"v8.16.0","branchLabelMappingKey":"^v8.16.0$","isSourceBranch":false,"state":"NOT_CREATED"},{"branch":"8.15","label":"v8.15.3","branchLabelMappingKey":"^v(\\d+).(\\d+).\\d+$","isSourceBranch":false,"state":"NOT_CREATED"}]}] BACKPORT--> Co-authored-by: Nathan Reese <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Part of #193905. Broke work into separate PRs to backport map embeddable changes to 8.15.
Resolves issue for Map embeddable. The problem is that Map embeddable is using a stale result from
parentApi.getAppContext. Dashboard'sgetAppContextchanges thegetCurrentPathwhen the dashboard has a saved object id. By using the stale results,getCurrentPathreturned#/createinstead of#/view/.Test steps