Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Console] Fix small UX bugs #193887

Merged
merged 11 commits into from
Sep 27, 2024
Merged

[Console] Fix small UX bugs #193887

merged 11 commits into from
Sep 27, 2024

Conversation

sabarasaba
Copy link
Member

@sabarasaba sabarasaba commented Sep 24, 2024 •
edited by kibanamachine
Loading

Fixes #193949

Summary

This PR fixes a few UX bugs that were noticed during testing:

  • The help contextual menu has now full row links instead of just the icons being clicky
  • The history now shows the method per each history item
  • When running a request the editor keeps the focus on the line that was executed, and the output is not highlighted unless there is focus on its text editor.
Screenshots

Screenshot 2024-09-24 at 16 57 33
Screenshot 2024-09-24 at 16 13 41
Screenshot 2024-09-25 at 10 20 13

@sabarasaba sabarasaba added Feature:Console Dev Tools Console Feature Team:Kibana Management Dev Tools, Index Management, Upgrade Assistant, ILM, Ingest Node Pipelines, and more backport:skip This commit does not require backporting v9.0.0 backport:prev-minor Backport to (8.x) the previous minor version (i.e. one version back from main) v8.16.0 labels Sep 24, 2024
@sabarasaba sabarasaba self-assigned this Sep 24, 2024
@sabarasaba
Copy link
Member Author

@elasticmachine merge upstream

@sabarasaba sabarasaba marked this pull request as ready for review September 25, 2024 08:24
@sabarasaba sabarasaba requested a review from a team as a code owner September 25, 2024 08:25
@elasticmachine
Copy link
Contributor

Pinging @elastic/kibana-management (Team:Kibana Management)

@sabarasaba sabarasaba added release_note:skip Skip the PR/issue when compiling release notes and removed backport:skip This commit does not require backporting labels Sep 25, 2024
ElenaStoeva
ElenaStoeva approved these changes Sep 26, 2024
View reviewed changes
Copy link
Contributor

@ElenaStoeva ElenaStoeva left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for adding these fixes @sabarasaba! Tested them locally, changes lgtm.

I'm approving to unblock the PR but wanted to mention that I noticed a small regression from these changes: when we add a request from History, it doesn't get highlighted as it did before. Could you look into this (hopefully it's not too complex to fix it)?

Screen.Recording.2024-09-26.at.17.17.31.mov

@sabarasaba
Copy link
Member Author

Thanks for having a look @ElenaStoeva! The bug for clearing output, navigating away and coming back and the last request is highlighted was more complex than what I initially thought. So I ended up creaing a separate issue for it as I think will require more investigation of how it happens. I'll go ahead and merge these fixes for now and we'll deal with the other one separately.

@sabarasaba
Copy link
Member Author

@elasticmachine merge upstream

@kibana-ci
Copy link
Collaborator

💚 Build Succeeded

Metrics [docs]

Async chunks

Total size of all lazy-loaded chunks that will be downloaded as the user navigates the app

id before after diff
console 208.0KB 208.1KB +86.0B

History

To update your PR or re-run it, just comment with:
@elasticmachine merge upstream

cc @sabarasaba

@sabarasaba sabarasaba merged commit 8af2334 into elastic:main Sep 27, 2024
23 checks passed
@kibanamachine
Copy link
Contributor

Starting backport for target branches: 8.x

https://github.com/elastic/kibana/actions/runs/11071265696

kibanamachine pushed a commit to kibanamachine/kibana that referenced this pull request Sep 27, 2024
@sabarasaba
[Console] Fix small UX bugs (elastic#193887)
67819b6 
(cherry picked from commit 8af2334)
@kibanamachine kibanamachine mentioned this pull request Sep 27, 2024
Merged
@kibanamachine
Copy link
Contributor

💚 All backports created successfully

Status Branch Result
✅ 8.x

Note: Successful backport PRs will be merged automatically after passing CI.

Questions ?

Please refer to the Backport tool documentation

kibanamachine added a commit that referenced this pull request Sep 27, 2024
@kibanamachine @sabarasaba
[8.x] [Console] Fix small UX bugs (#193887) (#194299)
71fa6d7 
# Backport

This will backport the following commits from `main` to `8.x`:
- [[Console] Fix small UX bugs
(#193887)](#193887)

<!--- Backport version: 9.4.3 -->

### Questions ?
Please refer to the [Backport tool
documentation](https://github.com/sqren/backport)

<!--BACKPORT [{"author":{"name":"Ignacio
Rivas","email":"[email protected]"},"sourceCommit":{"committedDate":"2024-09-27T13:09:46Z","message":"[Console]
Fix small UX bugs
(#193887)","sha":"8af23349e185368601b435619ce4eaf90d5071ed","branchLabelMapping":{"^v9.0.0$":"main","^v8.16.0$":"8.x","^v(\\d+).(\\d+).\\d+$":"$1.$2"}},"sourcePullRequest":{"labels":["Feature:Console","Team:Kibana
Management","release_note:skip","v9.0.0","backport:prev-minor","v8.16.0"],"title":"[Console]
Fix small UX
bugs","number":193887,"url":"https://github.com/elastic/kibana/pull/193887","mergeCommit":{"message":"[Console]
Fix small UX bugs
(#193887)","sha":"8af23349e185368601b435619ce4eaf90d5071ed"}},"sourceBranch":"main","suggestedTargetBranches":["8.x"],"targetPullRequestStates":[{"branch":"main","label":"v9.0.0","branchLabelMappingKey":"^v9.0.0$","isSourceBranch":true,"state":"MERGED","url":"https://github.com/elastic/kibana/pull/193887","number":193887,"mergeCommit":{"message":"[Console]
Fix small UX bugs
(#193887)","sha":"8af23349e185368601b435619ce4eaf90d5071ed"}},{"branch":"8.x","label":"v8.16.0","branchLabelMappingKey":"^v8.16.0$","isSourceBranch":false,"state":"NOT_CREATED"}]}]
BACKPORT-->

Co-authored-by: Ignacio Rivas <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ElenaStoeva ElenaStoeva ElenaStoeva approved these changes

Assignees

@sabarasaba sabarasaba

Labels
backport:prev-minor Backport to (8.x) the previous minor version (i.e. one version back from main) Feature:Console Dev Tools Console Feature release_note:skip Skip the PR/issue when compiling release notes Team:Kibana Management Dev Tools, Index Management, Upgrade Assistant, ILM, Ingest Node Pipelines, and more v8.16.0 v9.0.0
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[Console] Last request gets autoselected when clearing editor input navigating away and coming back
5 participants
@sabarasaba @elasticmachine @kibana-ci @kibanamachine @ElenaStoeva