Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Inventory][ECO] filter by type on grid #193875

Merged
merged 2 commits into from
Sep 25, 2024
Merged

[Inventory][ECO] filter by type on grid #193875

merged 2 commits into from
Sep 25, 2024

Conversation

cauemarcondes
Copy link
Contributor

@cauemarcondes cauemarcondes commented Sep 24, 2024 •
edited by kibanamachine
Loading

closes #192669

Screen.Recording.2024-09-24.at.15.mp4

@cauemarcondes cauemarcondes added release_note:skip Skip the PR/issue when compiling release notes backport:prev-minor Backport to (8.x) the previous minor version (i.e. one version back from main) v8.16.0 labels Sep 24, 2024
@cauemarcondes cauemarcondes requested a review from a team as a code owner September 24, 2024 14:11
@botelastic botelastic bot added the ci:project-deploy-observability Create an Observability project label Sep 24, 2024
@obltmachine
Copy link

🤖 GitHub comments

Expand to view the GitHub comments

Just comment with:

  • /oblt-deploy : Deploy a Kibana instance using the Observability test environments.
  • run docs-build : Re-trigger the docs validation. (use unformatted text in the comment!)

kpatticha
kpatticha reviewed Sep 25, 2024
View reviewed changes
...ugins/observability_solution/inventory/public/components/badge_filter_with_popover/index.tsx Outdated
onFilter: () => void;
}

export function BadgeFilterWithPopover({ property, value, onFilter, label }: Props) {
Copy link
Contributor

@kpatticha kpatticha Sep 25, 2024 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

we can't reuse the component from logs explorer?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

That one used in the logs explorer belongs to the Discover plugin. I won't drag myself into refactoring that into a shareable place, at least not for now.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

make sense, thanks

kpatticha
kpatticha approved these changes Sep 25, 2024
View reviewed changes
Copy link
Contributor

@kpatticha kpatticha left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Overall looks good to me. Thanks for adding the tests. Added some nits and comments

@cauemarcondes cauemarcondes enabled auto-merge (squash) September 25, 2024 10:04
@kibana-ci
Copy link
Collaborator

kibana-ci commented Sep 25, 2024 •
edited
Loading

💛 Build succeeded, but was flaky

Failed CI Steps

Test Failures

  • [job] [logs] Jest Tests #3 / When using CommandExecutionOutput component should show long running hint message if pending and >15s have passed

Metrics [docs]

Module Count

Fewer modules leads to a faster build time

id before after diff
inventory 189 190 +1

Async chunks

Total size of all lazy-loaded chunks that will be downloaded as the user navigates the app

id before after diff
inventory 143.3KB 145.0KB +1.7KB

History

To update your PR or re-run it, just comment with:
@elasticmachine merge upstream

@cauemarcondes cauemarcondes merged commit 475fd6c into elastic:main Sep 25, 2024
26 checks passed
kibanamachine pushed a commit to kibanamachine/kibana that referenced this pull request Sep 25, 2024
@cauemarcondes
[Inventory][ECO] filter by type on grid (elastic#193875)
251c3d1 
closes elastic#192669

https://github.com/user-attachments/assets/d8c51a63-6783-4a9c-a785-83004489cd5d
(cherry picked from commit 475fd6c)
@kibanamachine kibanamachine mentioned this pull request Sep 25, 2024
Merged
@kibanamachine
Copy link
Contributor

💚 All backports created successfully

Status Branch Result
✅ 8.x

Note: Successful backport PRs will be merged automatically after passing CI.

Questions ?

Please refer to the Backport tool documentation

@cauemarcondes cauemarcondes deleted the eco-filter-by-entity-type-on-table branch September 25, 2024 13:01
kibanamachine added a commit that referenced this pull request Sep 25, 2024
@kibanamachine @cauemarcondes
[8.x] [Inventory][ECO] filter by type on grid (#193875) (#193985)
668f212 
# Backport

This will backport the following commits from `main` to `8.x`:
- [[Inventory][ECO] filter by type on grid
(#193875)](#193875)

<!--- Backport version: 9.4.3 -->

### Questions ?
Please refer to the [Backport tool
documentation](https://github.com/sqren/backport)

<!--BACKPORT [{"author":{"name":"Cauê
Marcondes","email":"[email protected]"},"sourceCommit":{"committedDate":"2024-09-25T11:40:12Z","message":"[Inventory][ECO]
filter by type on grid (#193875)\n\ncloses
https://github.com/elastic/kibana/issues/192669\r\n\r\n\r\n\r\nhttps://github.com/user-attachments/assets/d8c51a63-6783-4a9c-a785-83004489cd5d","sha":"475fd6c2021ffc79e91afae05fa6793f42a4bb6a","branchLabelMapping":{"^v9.0.0$":"main","^v8.16.0$":"8.x","^v(\\d+).(\\d+).\\d+$":"$1.$2"}},"sourcePullRequest":{"labels":["release_note:skip","v9.0.0","backport:prev-minor","ci:project-deploy-observability","v8.16.0"],"title":"[Inventory][ECO]
filter by type on
grid","number":193875,"url":"https://github.com/elastic/kibana/pull/193875","mergeCommit":{"message":"[Inventory][ECO]
filter by type on grid (#193875)\n\ncloses
https://github.com/elastic/kibana/issues/192669\r\n\r\n\r\n\r\nhttps://github.com/user-attachments/assets/d8c51a63-6783-4a9c-a785-83004489cd5d","sha":"475fd6c2021ffc79e91afae05fa6793f42a4bb6a"}},"sourceBranch":"main","suggestedTargetBranches":["8.x"],"targetPullRequestStates":[{"branch":"main","label":"v9.0.0","branchLabelMappingKey":"^v9.0.0$","isSourceBranch":true,"state":"MERGED","url":"https://github.com/elastic/kibana/pull/193875","number":193875,"mergeCommit":{"message":"[Inventory][ECO]
filter by type on grid (#193875)\n\ncloses
https://github.com/elastic/kibana/issues/192669\r\n\r\n\r\n\r\nhttps://github.com/user-attachments/assets/d8c51a63-6783-4a9c-a785-83004489cd5d","sha":"475fd6c2021ffc79e91afae05fa6793f42a4bb6a"}},{"branch":"8.x","label":"v8.16.0","branchLabelMappingKey":"^v8.16.0$","isSourceBranch":false,"state":"NOT_CREATED"}]}]
BACKPORT-->

Co-authored-by: Cauê Marcondes <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kpatticha kpatticha kpatticha approved these changes

Assignees
No one assigned
Labels
backport:prev-minor Backport to (8.x) the previous minor version (i.e. one version back from main) ci:project-deploy-observability Create an Observability project release_note:skip Skip the PR/issue when compiling release notes v8.16.0 v9.0.0
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[Inventory] filter by entity type component
5 participants
@cauemarcondes @obltmachine @kibana-ci @kibanamachine @kpatticha