[Security Solution][Detection Engine] removes field_caps call for all fields in index during rule execution #193869
+50
−181
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… fields in index during rule execution
vitaliidm
added
release_note:skip
…/github.com/vitaliidm/kibana into de_8_16/field_caps_in_security_rule_wrapper
|
Pinging @elastic/security-solution (Team: SecuritySolution) |
|
Pinging @elastic/security-detection-engine (Team:Detection Engine) |
rylnd
approved these changes
Sep 28, 2024
There was a problem hiding this comment.
@vitaliidm I wasn't sure exactly how to test this, but the code looks good and I verified several rule types run as expected. Please let me know if you'd like additional review and I can do that!
| title: index.join(), | ||
| }); | ||
| return Object.values( | ||
| await queryToFields({ |
There was a problem hiding this comment.
Great to see queryToFields is back! 😎
💛 Build succeeded, but was flaky
Failed CI StepsMetrics [docs]
History
To update your PR or re-run it, just comment with: cc @vitaliidm |
|
Starting backport for target branches: 8.x |
kibanamachine
pushed a commit
to kibanamachine/kibana
that referenced
this pull request
Sep 30, 2024
… fields in index during rule execution (elastic#193869) ## Summary - addresses elastic#187059 ### Checklist Delete any items that are not applicable to this PR. - [x] [Unit or functional tests](https://www.elastic.co/guide/en/kibana/master/development-tests.html) were updated or added to match the most common scenarios --------- Co-authored-by: kibanamachine <[email protected]> (cherry picked from commit b005ea9)
💚 All backports created successfully
Note: Successful backport PRs will be merged automatically after passing CI. Questions ?Please refer to the Backport tool documentation |
kibanamachine
added a commit
that referenced
this pull request
Sep 30, 2024
…or all fields in index during rule execution (#193869) (#194433) # Backport This will backport the following commits from `main` to `8.x`: - [[Security Solution][Detection Engine] removes field_caps call for all fields in index during rule execution (#193869)](#193869) <!--- Backport version: 9.4.3 --> ### Questions ? Please refer to the [Backport tool documentation](https://github.com/sqren/backport) <!--BACKPORT [{"author":{"name":"Vitalii Dmyterko","email":"[email protected]"},"sourceCommit":{"committedDate":"2024-09-30T13:15:24Z","message":"[Security Solution][Detection Engine] removes field_caps call for all fields in index during rule execution (#193869)\n\n## Summary\r\n\r\n- addresses https://github.com/elastic/kibana/issues/187059\r\n\r\n### Checklist\r\n\r\nDelete any items that are not applicable to this PR.\r\n\r\n\r\n- [x] [Unit or functional\r\ntests](https://www.elastic.co/guide/en/kibana/master/development-tests.html)\r\nwere updated or added to match the most common scenarios\r\n\r\n---------\r\n\r\nCo-authored-by: kibanamachine <[email protected]>","sha":"b005ea907b7173b2aa7ab0974f9a2fcfef08de0d","branchLabelMapping":{"^v9.0.0$":"main","^v8.16.0$":"8.x","^v(\\d+).(\\d+).\\d+$":"$1.$2"}},"sourcePullRequest":{"labels":["release_note:skip","v9.0.0","Team: SecuritySolution","backport:prev-minor","Team:Detection Engine","8.16 candidate"],"title":"[Security Solution][Detection Engine] removes field_caps call for all fields in index during rule execution","number":193869,"url":"https://github.com/elastic/kibana/pull/193869","mergeCommit":{"message":"[Security Solution][Detection Engine] removes field_caps call for all fields in index during rule execution (#193869)\n\n## Summary\r\n\r\n- addresses https://github.com/elastic/kibana/issues/187059\r\n\r\n### Checklist\r\n\r\nDelete any items that are not applicable to this PR.\r\n\r\n\r\n- [x] [Unit or functional\r\ntests](https://www.elastic.co/guide/en/kibana/master/development-tests.html)\r\nwere updated or added to match the most common scenarios\r\n\r\n---------\r\n\r\nCo-authored-by: kibanamachine <[email protected]>","sha":"b005ea907b7173b2aa7ab0974f9a2fcfef08de0d"}},"sourceBranch":"main","suggestedTargetBranches":[],"targetPullRequestStates":[{"branch":"main","label":"v9.0.0","branchLabelMappingKey":"^v9.0.0$","isSourceBranch":true,"state":"MERGED","url":"https://github.com/elastic/kibana/pull/193869","number":193869,"mergeCommit":{"message":"[Security Solution][Detection Engine] removes field_caps call for all fields in index during rule execution (#193869)\n\n## Summary\r\n\r\n- addresses https://github.com/elastic/kibana/issues/187059\r\n\r\n### Checklist\r\n\r\nDelete any items that are not applicable to this PR.\r\n\r\n\r\n- [x] [Unit or functional\r\ntests](https://www.elastic.co/guide/en/kibana/master/development-tests.html)\r\nwere updated or added to match the most common scenarios\r\n\r\n---------\r\n\r\nCo-authored-by: kibanamachine <[email protected]>","sha":"b005ea907b7173b2aa7ab0974f9a2fcfef08de0d"}}]}] BACKPORT--> Co-authored-by: Vitalii Dmyterko <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Checklist
Delete any items that are not applicable to this PR.