Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[7.17] [data views] Remove regex for creating dot notation (#193795) #193811

Merged
merged 3 commits into from
Sep 24, 2024
Merged

[7.17] [data views] Remove regex for creating dot notation (#193795) #193811

merged 3 commits into from
Sep 24, 2024

Conversation

mattkime
Copy link
Contributor

Backport

This will backport the following commits from main to 7.17:

Questions ?

Please refer to the Backport tool documentation

@mattkime
[data views] Remove regex for creating dot notation (elastic#193795)
cbc3ece 
## Summary

Use basic string and array functions instead of regex to create short
dot field names.

(cherry picked from commit ab9459c)

# Conflicts:
#	src/plugins/data_views/common/fields/utils.ts
@mattkime mattkime enabled auto-merge (squash) September 24, 2024 01:41
@mattkime mattkime mentioned this pull request Sep 24, 2024
Merged
@mattkime
Copy link
Contributor Author

/ci

@mattkime
Copy link
Contributor Author

/ci

@kibana-ci
Copy link
Collaborator

💛 Build succeeded, but was flaky

Failed CI Steps

Test Failures

  • [job] [logs] Rules, Alerts and Exceptions ResponseOps Cypress Tests on Security Solution #1 / Detection rules, override Creates and activates a new custom rule with override option
  • [job] [logs] Rules, Alerts and Exceptions ResponseOps Cypress Tests on Security Solution #4 / From rule Creates an exception and deletes it

Metrics [docs]

Page load bundle

Size of the bundles that are downloaded on every page load. Target size is below 100kb

id before after diff
dataViews 38.9KB 39.0KB +67.0B

History

To update your PR or re-run it, just comment with:
@elasticmachine merge upstream

@mattkime mattkime merged commit a383439 into elastic:7.17 Sep 24, 2024
31 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@lukasolson lukasolson lukasolson approved these changes

Assignees
No one assigned
Labels
backport
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@mattkime @kibana-ci @lukasolson