Auto-focus ES|QL editor on mount #193800
Merged
Auto-focus ES|QL editor on mount #193800
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Currently, when the page loads, in order to start interacting with the ES|QL editor using keyboard navigation, you must: * Tab to the "Skip to main content" link * Follow that link * Tab through the tab and toolbar elements until you get to the editor * Press <end> or <ctrl-e> or down-down-down-down, depending on what's in the editor text box * Type my query This change auto-focuses the editor and moves the cursor to the end when the editor is mounted. The [ARIA Authoring Practices Guide (APG) for Developing a Keyboard Interface](https://www.w3.org/WAI/ARIA/apg/practices/keyboard-interface/) says: > * Do not set initial focus when the page loads except in cases where: > ** The page offers a single, primary function that nearly all users employ immediately after page load. > ** Any given user is likely to use the page often. When using ES|QL in discover you almost always want to initially focus on the query, look at the results, and further refine the query.
🤖 GitHub commentsExpand to view the GitHub comments
Just comment with:
|
smith
added
backport:skip
💛 Build succeeded, but was flaky
Failed CI StepsTest Failures
Metrics [docs]Async chunks
To update your PR or re-run it, just comment with: |
|
@smith thanx for the contribution! I am going to change your labels to also backport it in 8.x (with skip it only goes to 9.0) |
stratoula
added
backport:prev-minor
|
Pinging @elastic/kibana-esql (Team:ESQL) |
kibanamachine
pushed a commit
to kibanamachine/kibana
that referenced
this pull request
Sep 24, 2024
## Summary Currently, when the page loads, in order to start interacting with the ES|QL editor using keyboard navigation, you must: * Tab to the "Skip to main content" link * Follow that link * Tab through the tab and toolbar elements until you get to the editor * Press END or CTRL-E or down-down-down-down, depending on what's in the editor text box * Type my query This change auto-focuses the editor and moves the cursor to the end when the editor is mounted. The [ARIA Authoring Practices Guide (APG) for Developing a Keyboard Interface](https://www.w3.org/WAI/ARIA/apg/practices/keyboard-interface/) says: > * Do not set initial focus when the page loads except in cases where: > ** The page offers a single, primary function that nearly all users employ immediately after page load. > ** Any given user is likely to use the page often. When using ES|QL in discover you almost always want to initially focus on the query, look at the results, and further refine the query. ### Checklist - [x] Any UI touched in this PR is usable by keyboard only (learn more about [keyboard accessibility](https://webaim.org/techniques/keyboard/)) (cherry picked from commit 80f938e)
💚 All backports created successfully
Note: Successful backport PRs will be merged automatically after passing CI. Questions ?Please refer to the Backport tool documentation |
kibanamachine
added a commit
that referenced
this pull request
Sep 24, 2024
# Backport This will backport the following commits from `main` to `8.x`: - [Auto-focus ES|QL editor on mount (#193800)](#193800) <!--- Backport version: 9.4.3 --> ### Questions ? Please refer to the [Backport tool documentation](https://github.com/sqren/backport) <!--BACKPORT [{"author":{"name":"Nathan L Smith","email":"[email protected]"},"sourceCommit":{"committedDate":"2024-09-24T06:29:46Z","message":"Auto-focus ES|QL editor on mount (#193800)\n\n## Summary\r\n\r\nCurrently, when the page loads, in order to start interacting with the\r\nES|QL editor using keyboard navigation, you must:\r\n\r\n* Tab to the \"Skip to main content\" link\r\n* Follow that link\r\n* Tab through the tab and toolbar elements until you get to the editor\r\n* Press END or CTRL-E or down-down-down-down, depending on what's in the\r\neditor text box\r\n* Type my query\r\n\r\nThis change auto-focuses the editor and moves the cursor to the end when\r\nthe editor is mounted.\r\n\r\nThe [ARIA Authoring Practices Guide (APG) for Developing a Keyboard\r\nInterface](https://www.w3.org/WAI/ARIA/apg/practices/keyboard-interface/)\r\nsays:\r\n\r\n> * Do not set initial focus when the page loads except in cases where:\r\n> ** The page offers a single, primary function that nearly all users\r\nemploy immediately after page load.\r\n> ** Any given user is likely to use the page often.\r\n\r\nWhen using ES|QL in discover you almost always want to initially focus\r\non the query, look at the results, and further refine the query.\r\n\r\n### Checklist\r\n\r\n- [x] Any UI touched in this PR is usable by keyboard only (learn more\r\nabout [keyboard accessibility](https://webaim.org/techniques/keyboard/))","sha":"80f938e174b1e6efce784bd3e44d477b2b512c3a","branchLabelMapping":{"^v9.0.0$":"main","^v8.16.0$":"8.x","^v(\\d+).(\\d+).\\d+$":"$1.$2"}},"sourcePullRequest":{"labels":["release_note:enhancement","v9.0.0","backport:prev-minor","Feature:ES|QL","Team:ESQL","v8.16.0"],"title":"Auto-focus ES|QL editor on mount","number":193800,"url":"https://github.com/elastic/kibana/pull/193800","mergeCommit":{"message":"Auto-focus ES|QL editor on mount (#193800)\n\n## Summary\r\n\r\nCurrently, when the page loads, in order to start interacting with the\r\nES|QL editor using keyboard navigation, you must:\r\n\r\n* Tab to the \"Skip to main content\" link\r\n* Follow that link\r\n* Tab through the tab and toolbar elements until you get to the editor\r\n* Press END or CTRL-E or down-down-down-down, depending on what's in the\r\neditor text box\r\n* Type my query\r\n\r\nThis change auto-focuses the editor and moves the cursor to the end when\r\nthe editor is mounted.\r\n\r\nThe [ARIA Authoring Practices Guide (APG) for Developing a Keyboard\r\nInterface](https://www.w3.org/WAI/ARIA/apg/practices/keyboard-interface/)\r\nsays:\r\n\r\n> * Do not set initial focus when the page loads except in cases where:\r\n> ** The page offers a single, primary function that nearly all users\r\nemploy immediately after page load.\r\n> ** Any given user is likely to use the page often.\r\n\r\nWhen using ES|QL in discover you almost always want to initially focus\r\non the query, look at the results, and further refine the query.\r\n\r\n### Checklist\r\n\r\n- [x] Any UI touched in this PR is usable by keyboard only (learn more\r\nabout [keyboard accessibility](https://webaim.org/techniques/keyboard/))","sha":"80f938e174b1e6efce784bd3e44d477b2b512c3a"}},"sourceBranch":"main","suggestedTargetBranches":["8.x"],"targetPullRequestStates":[{"branch":"main","label":"v9.0.0","branchLabelMappingKey":"^v9.0.0$","isSourceBranch":true,"state":"MERGED","url":"https://github.com/elastic/kibana/pull/193800","number":193800,"mergeCommit":{"message":"Auto-focus ES|QL editor on mount (#193800)\n\n## Summary\r\n\r\nCurrently, when the page loads, in order to start interacting with the\r\nES|QL editor using keyboard navigation, you must:\r\n\r\n* Tab to the \"Skip to main content\" link\r\n* Follow that link\r\n* Tab through the tab and toolbar elements until you get to the editor\r\n* Press END or CTRL-E or down-down-down-down, depending on what's in the\r\neditor text box\r\n* Type my query\r\n\r\nThis change auto-focuses the editor and moves the cursor to the end when\r\nthe editor is mounted.\r\n\r\nThe [ARIA Authoring Practices Guide (APG) for Developing a Keyboard\r\nInterface](https://www.w3.org/WAI/ARIA/apg/practices/keyboard-interface/)\r\nsays:\r\n\r\n> * Do not set initial focus when the page loads except in cases where:\r\n> ** The page offers a single, primary function that nearly all users\r\nemploy immediately after page load.\r\n> ** Any given user is likely to use the page often.\r\n\r\nWhen using ES|QL in discover you almost always want to initially focus\r\non the query, look at the results, and further refine the query.\r\n\r\n### Checklist\r\n\r\n- [x] Any UI touched in this PR is usable by keyboard only (learn more\r\nabout [keyboard accessibility](https://webaim.org/techniques/keyboard/))","sha":"80f938e174b1e6efce784bd3e44d477b2b512c3a"}},{"branch":"8.x","label":"v8.16.0","branchLabelMappingKey":"^v8.16.0$","isSourceBranch":false,"state":"NOT_CREATED"}]}] BACKPORT--> Co-authored-by: Nathan L Smith <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Currently, when the page loads, in order to start interacting with the ES|QL editor using keyboard navigation, you must:
This change auto-focuses the editor and moves the cursor to the end when the editor is mounted.
The ARIA Authoring Practices Guide (APG) for Developing a Keyboard Interface says:
When using ES|QL in discover you almost always want to initially focus on the query, look at the results, and further refine the query.
Checklist