[Dev Server] Remove dead code #193736
Merged
[Dev Server] Remove dead code #193736
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
afharo
added
Team:Operations
|
Pinging @elastic/kibana-operations (Team:Operations) |
jbudz
approved these changes
Sep 23, 2024
💛 Build succeeded, but was flaky
Failed CI StepsMetrics [docs]
To update your PR or re-run it, just comment with: cc @afharo |
kibanamachine
pushed a commit
to kibanamachine/kibana
that referenced
this pull request
Sep 23, 2024
(cherry picked from commit e6e170e)
💚 All backports created successfully
Note: Successful backport PRs will be merged automatically after passing CI. Questions ?Please refer to the Backport tool documentation |
kibanamachine
added a commit
that referenced
this pull request
Sep 23, 2024
# Backport This will backport the following commits from `main` to `8.x`: - [[Dev Server] Remove dead code (#193736)](#193736) <!--- Backport version: 9.4.3 --> ### Questions ? Please refer to the [Backport tool documentation](https://github.com/sqren/backport) <!--BACKPORT [{"author":{"name":"Alejandro Fernández Haro","email":"[email protected]"},"sourceCommit":{"committedDate":"2024-09-23T17:01:08Z","message":"[Dev Server] Remove dead code (#193736)","sha":"e6e170e687a2221ebdcf49c0942cf6e40aed9b59","branchLabelMapping":{"^v9.0.0$":"main","^v8.16.0$":"8.x","^v(\\d+).(\\d+).\\d+$":"$1.$2"}},"sourcePullRequest":{"labels":["Team:Operations","technical debt","release_note:skip","v9.0.0","backport:prev-minor"],"title":"[Dev Server] Remove dead code","number":193736,"url":"https://github.com/elastic/kibana/pull/193736","mergeCommit":{"message":"[Dev Server] Remove dead code (#193736)","sha":"e6e170e687a2221ebdcf49c0942cf6e40aed9b59"}},"sourceBranch":"main","suggestedTargetBranches":[],"targetPullRequestStates":[{"branch":"main","label":"v9.0.0","branchLabelMappingKey":"^v9.0.0$","isSourceBranch":true,"state":"MERGED","url":"https://github.com/elastic/kibana/pull/193736","number":193736,"mergeCommit":{"message":"[Dev Server] Remove dead code (#193736)","sha":"e6e170e687a2221ebdcf49c0942cf6e40aed9b59"}}]}] BACKPORT--> Co-authored-by: Alejandro Fernández Haro <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Investigating something else, I noticed this due TODO 🔥
For maintainers