[Onboarding] Fix failed Firehose tests #193733
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
🤖 GitHub commentsExpand to view the GitHub comments
Just comment with:
|
mykolaharmash
changed the title
Flaky Test Runner Stats🎉 All tests passed! - kibana-flaky-test-suite-runner#6998[✅] x-pack/test_serverless/functional/test_suites/observability/config.ts: 50/50 tests passed. |
mykolaharmash
added
release_note:skip
|
Pinging @elastic/obs-ux-logs-team (Team:obs-ux-logs) |
mykolaharmash
added
backport:skip
botelastic
bot
added
the
ci:project-deploy-observability
mykolaharmash
force-pushed
the
193294-failed-firehose-tests
branch
from
9871f04 to
f0b88d5
Compare
💛 Build succeeded, but was flaky
Failed CI StepsTest Failures
Metrics [docs]
HistoryTo update your PR or re-run it, just comment with: |
Kerry350
approved these changes
Sep 24, 2024
There was a problem hiding this comment.
Approving so we can unblock the tests, thanks for looking into this one 👍
Do you think in the future the onboarding tests that rely on these installations should use this approach: #192064? Might be worth a followup ticket.
Nice, thank you for pointing that out! I've created a follow up maintenance issue. |
kibanamachine
pushed a commit
to kibanamachine/kibana
that referenced
this pull request
Sep 24, 2024
Closes [193294](elastic#193294) When the Firehose flow initialized it installs firehose integration and assets for all supported AWS services in the background that might take a while. This change increases the wait time until the loader in the UI is hidden and the test can proceed. [Successful flaky test runner job](https://buildkite.com/elastic/kibana-flaky-test-suite-runner/builds/6998#_) (cherry picked from commit ca61209)
💔 Some backports could not be created
Note: Successful backport PRs will be merged automatically after passing CI. Manual backportTo create the backport manually run: Questions ?Please refer to the Backport tool documentation |
kibanamachine
added a commit
that referenced
this pull request
Sep 24, 2024
# Backport This will backport the following commits from `main` to `8.x`: - [[Onboarding] Fix failed Firehose tests (#193733)](#193733) <!--- Backport version: 9.4.3 --> ### Questions ? Please refer to the [Backport tool documentation](https://github.com/sqren/backport) <!--BACKPORT [{"author":{"name":"Mykola Harmash","email":"[email protected]"},"sourceCommit":{"committedDate":"2024-09-24T12:22:59Z","message":"[Onboarding] Fix failed Firehose tests (#193733)\n\nCloses [193294](https://github.com/elastic/kibana/issues/193294)\r\n\r\nWhen the Firehose flow initialized it installs firehose integration and\r\nassets for all supported AWS services in the background that might take\r\na while. This change increases the wait time until the loader in the UI\r\nis hidden and the test can proceed.\r\n\r\n[Successful flaky test runner\r\njob](https://buildkite.com/elastic/kibana-flaky-test-suite-runner/builds/6998#_)","sha":"ca61209d13fa19d6119521a7276bd0c210bc926c","branchLabelMapping":{"^v9.0.0$":"main","^v8.16.0$":"8.x","^v(\\d+).(\\d+).\\d+$":"$1.$2"}},"sourcePullRequest":{"labels":["release_note:skip","v9.0.0","backport:prev-major","ci:project-deploy-observability","Team:obs-ux-logs","v8.16.0"],"title":"[Onboarding] Fix failed Firehose tests","number":193733,"url":"https://github.com/elastic/kibana/pull/193733","mergeCommit":{"message":"[Onboarding] Fix failed Firehose tests (#193733)\n\nCloses [193294](https://github.com/elastic/kibana/issues/193294)\r\n\r\nWhen the Firehose flow initialized it installs firehose integration and\r\nassets for all supported AWS services in the background that might take\r\na while. This change increases the wait time until the loader in the UI\r\nis hidden and the test can proceed.\r\n\r\n[Successful flaky test runner\r\njob](https://buildkite.com/elastic/kibana-flaky-test-suite-runner/builds/6998#_)","sha":"ca61209d13fa19d6119521a7276bd0c210bc926c"}},"sourceBranch":"main","suggestedTargetBranches":["8.x"],"targetPullRequestStates":[{"branch":"main","label":"v9.0.0","branchLabelMappingKey":"^v9.0.0$","isSourceBranch":true,"state":"MERGED","url":"https://github.com/elastic/kibana/pull/193733","number":193733,"mergeCommit":{"message":"[Onboarding] Fix failed Firehose tests (#193733)\n\nCloses [193294](https://github.com/elastic/kibana/issues/193294)\r\n\r\nWhen the Firehose flow initialized it installs firehose integration and\r\nassets for all supported AWS services in the background that might take\r\na while. This change increases the wait time until the loader in the UI\r\nis hidden and the test can proceed.\r\n\r\n[Successful flaky test runner\r\njob](https://buildkite.com/elastic/kibana-flaky-test-suite-runner/builds/6998#_)","sha":"ca61209d13fa19d6119521a7276bd0c210bc926c"}},{"branch":"8.x","label":"v8.16.0","branchLabelMappingKey":"^v8.16.0$","isSourceBranch":false,"state":"NOT_CREATED"}]}] BACKPORT--> Co-authored-by: Mykola Harmash <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes 193294
When the Firehose flow initialized it installs firehose integration and assets for all supported AWS services in the background that might take a while. This change increases the wait time until the loader in the UI is hidden and the test can proceed.
Successful flaky test runner job