Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[APM] Turn 'fast filter' on by default and ensure tech preview badge shows when turned on #193710

Merged
merged 3 commits into from
Sep 23, 2024
Merged

[APM] Turn 'fast filter' on by default and ensure tech preview badge shows when turned on #193710

merged 3 commits into from
Sep 23, 2024

Conversation

cauemarcondes
Copy link
Contributor

@cauemarcondes cauemarcondes commented Sep 23, 2024 •
edited by kibanamachine
Loading

closes #193406

Screenshot 2024-09-23 at 12 37 41 Screenshot 2024-09-23 at 12 37 56 Screenshot 2024-09-23 at 12 38 04

@cauemarcondes cauemarcondes added release_note:enhancement backport:prev-minor Backport to (8.x) the previous minor version (i.e. one version back from main) v8.16.0 labels Sep 23, 2024
@cauemarcondes cauemarcondes requested review from a team as code owners September 23, 2024 11:58
@botelastic botelastic bot added ci:project-deploy-observability Create an Observability project Team:obs-ux-infra_services Observability Infrastructure & Services User Experience Team Team:obs-ux-management Observability Management User Experience Team labels Sep 23, 2024
@elasticmachine
Copy link
Contributor

Pinging @elastic/obs-ux-infra_services-team (Team:obs-ux-infra_services)

@elasticmachine
Copy link
Contributor

Pinging @elastic/obs-ux-management-team (Team:obs-ux-management)

@obltmachine
Copy link

🤖 GitHub comments

Expand to view the GitHub comments

Just comment with:

  • /oblt-deploy : Deploy a Kibana instance using the Observability test environments.
  • run docs-build : Re-trigger the docs validation. (use unformatted text in the comment!)

crespocarlos
crespocarlos approved these changes Sep 23, 2024
View reviewed changes
Copy link
Contributor

@crespocarlos crespocarlos left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code LGTM.

@kibana-ci
Copy link
Collaborator

kibana-ci commented Sep 23, 2024 •
edited
Loading

💛 Build succeeded, but was flaky

  • Buildkite Build
  • Commit: b0e7f3f
  • Kibana Serverless Image: docker.elastic.co/kibana-ci/kibana-serverless:pr-193710-b0e7f3fe6a50

Failed CI Steps

Test Failures

  • [job] [logs] Jest Tests #17 / FilterPopover renders button label correctly

Metrics [docs]

Module Count

Fewer modules leads to a faster build time

id before after diff
apm 1866 1865 -1

Async chunks

Total size of all lazy-loaded chunks that will be downloaded as the user navigates the app

id before after diff
apm 3.4MB 3.4MB -3.8KB

History

To update your PR or re-run it, just comment with:
@elasticmachine merge upstream

@cauemarcondes cauemarcondes enabled auto-merge (squash) September 23, 2024 15:46
colleenmcginnis
colleenmcginnis approved these changes Sep 23, 2024
View reviewed changes
Copy link
Contributor

@colleenmcginnis colleenmcginnis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It looks like there were no updates to the UI text, but there was an edit to the file that contains UI text. 🙃

@cauemarcondes cauemarcondes merged commit 886d009 into elastic:main Sep 23, 2024
25 checks passed
kibanamachine pushed a commit to kibanamachine/kibana that referenced this pull request Sep 23, 2024
@cauemarcondes
[APM] Turn 'fast filter' on by default and ensure tech preview badge …
900189d 
…shows when turned on (elastic#193710)

closes elastic#193406

<img width="1057" alt="Screenshot 2024-09-23 at 12 37 41"
src="https://github.com/user-attachments/assets/189eef68-e5ab-4472-a924-8c417960b09b">
<img width="1077" alt="Screenshot 2024-09-23 at 12 37 56"
src="https://github.com/user-attachments/assets/c0129aeb-2bb3-4055-a6f9-ccbbdb608451">
<img width="1202" alt="Screenshot 2024-09-23 at 12 38 04"
src="https://github.com/user-attachments/assets/ec2b1fa7-0342-440b-966c-965d24ef61c2">

(cherry picked from commit 886d009)
@kibanamachine kibanamachine mentioned this pull request Sep 23, 2024
Merged
@kibanamachine
Copy link
Contributor

💚 All backports created successfully

Status Branch Result
✅ 8.x

Note: Successful backport PRs will be merged automatically after passing CI.

Questions ?

Please refer to the Backport tool documentation

@kibanamachine kibanamachine mentioned this pull request Sep 23, 2024
Merged
kibanamachine added a commit that referenced this pull request Sep 23, 2024
@kibanamachine @cauemarcondes
[8.x] [APM] Turn &#x27;fast filter&#x27; on by default and ensure tec…
3bf4b47 
…h preview badge shows when turned on (#193710) (#193747)

# Backport

This will backport the following commits from `main` to `8.x`:
- [[APM] Turn &#x27;fast filter&#x27; on by default and ensure tech
preview badge shows when turned on
(#193710)](#193710)

<!--- Backport version: 9.4.3 -->

### Questions ?
Please refer to the [Backport tool
documentation](https://github.com/sqren/backport)

<!--BACKPORT [{"author":{"name":"Cauê
Marcondes","email":"[email protected]"},"sourceCommit":{"committedDate":"2024-09-23T15:54:50Z","message":"[APM]
Turn 'fast filter' on by default and ensure tech preview badge shows
when turned on (#193710)\n\ncloses
https://github.com/elastic/kibana/issues/193406\r\n\r\n<img
width=\"1057\" alt=\"Screenshot 2024-09-23 at 12 37
41\"\r\nsrc=\"https://github.com/user-attachments/assets/189eef68-e5ab-4472-a924-8c417960b09b\">\r\n<img
width=\"1077\" alt=\"Screenshot 2024-09-23 at 12 37
56\"\r\nsrc=\"https://github.com/user-attachments/assets/c0129aeb-2bb3-4055-a6f9-ccbbdb608451\">\r\n<img
width=\"1202\" alt=\"Screenshot 2024-09-23 at 12 38
04\"\r\nsrc=\"https://github.com/user-attachments/assets/ec2b1fa7-0342-440b-966c-965d24ef61c2\">","sha":"886d009418821ae4b6a22d7630bab0c484f137c2","branchLabelMapping":{"^v9.0.0$":"main","^v8.16.0$":"8.x","^v(\\d+).(\\d+).\\d+$":"$1.$2"}},"sourcePullRequest":{"labels":["release_note:enhancement","v9.0.0","backport:prev-minor","ci:project-deploy-observability","Team:obs-ux-infra_services","Team:obs-ux-management","v8.16.0"],"title":"[APM]
Turn 'fast filter' on by default and ensure tech preview badge shows
when turned
on","number":193710,"url":"https://github.com/elastic/kibana/pull/193710","mergeCommit":{"message":"[APM]
Turn 'fast filter' on by default and ensure tech preview badge shows
when turned on (#193710)\n\ncloses
https://github.com/elastic/kibana/issues/193406\r\n\r\n<img
width=\"1057\" alt=\"Screenshot 2024-09-23 at 12 37
41\"\r\nsrc=\"https://github.com/user-attachments/assets/189eef68-e5ab-4472-a924-8c417960b09b\">\r\n<img
width=\"1077\" alt=\"Screenshot 2024-09-23 at 12 37
56\"\r\nsrc=\"https://github.com/user-attachments/assets/c0129aeb-2bb3-4055-a6f9-ccbbdb608451\">\r\n<img
width=\"1202\" alt=\"Screenshot 2024-09-23 at 12 38
04\"\r\nsrc=\"https://github.com/user-attachments/assets/ec2b1fa7-0342-440b-966c-965d24ef61c2\">","sha":"886d009418821ae4b6a22d7630bab0c484f137c2"}},"sourceBranch":"main","suggestedTargetBranches":["8.x"],"targetPullRequestStates":[{"branch":"main","label":"v9.0.0","branchLabelMappingKey":"^v9.0.0$","isSourceBranch":true,"state":"MERGED","url":"https://github.com/elastic/kibana/pull/193710","number":193710,"mergeCommit":{"message":"[APM]
Turn 'fast filter' on by default and ensure tech preview badge shows
when turned on (#193710)\n\ncloses
https://github.com/elastic/kibana/issues/193406\r\n\r\n<img
width=\"1057\" alt=\"Screenshot 2024-09-23 at 12 37
41\"\r\nsrc=\"https://github.com/user-attachments/assets/189eef68-e5ab-4472-a924-8c417960b09b\">\r\n<img
width=\"1077\" alt=\"Screenshot 2024-09-23 at 12 37
56\"\r\nsrc=\"https://github.com/user-attachments/assets/c0129aeb-2bb3-4055-a6f9-ccbbdb608451\">\r\n<img
width=\"1202\" alt=\"Screenshot 2024-09-23 at 12 38
04\"\r\nsrc=\"https://github.com/user-attachments/assets/ec2b1fa7-0342-440b-966c-965d24ef61c2\">","sha":"886d009418821ae4b6a22d7630bab0c484f137c2"}},{"branch":"8.x","label":"v8.16.0","branchLabelMappingKey":"^v8.16.0$","isSourceBranch":false,"state":"NOT_CREATED"}]}]
BACKPORT-->

Co-authored-by: Cauê Marcondes <[email protected]>
@cauemarcondes cauemarcondes deleted the apm-enable-ff branch September 24, 2024 09:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@colleenmcginnis colleenmcginnis colleenmcginnis approved these changes

@crespocarlos crespocarlos crespocarlos approved these changes

Assignees
No one assigned
Labels
backport:prev-minor Backport to (8.x) the previous minor version (i.e. one version back from main) ci:project-deploy-observability Create an Observability project release_note:enhancement Team:obs-ux-infra_services Observability Infrastructure & Services User Experience Team Team:obs-ux-management Observability Management User Experience Team v8.16.0 v9.0.0
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[APM] Turn 'fast filter' on by default and ensure tech preview badge shows when turned on
7 participants
@cauemarcondes @elasticmachine @obltmachine @kibana-ci @kibanamachine @crespocarlos @colleenmcginnis