[8.x] [UII] Advanced agent monitoring options UI for HTTP endpoint and diagnostics (#193361) #193658
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…nostics (elastic#193361) ## Summary Resolves elastic#153950. This PR implements a UI to configure advanced Elastic Agent monitoring options under agent policy settings. These advanced options include enabling HTTP monitoring endpoints and various options for agent diagnostics. They are shown under an a toggle under the existing agent monitoring logs and metrics collection options: <img width="1326" alt="image" src="https://github.com/user-attachments/assets/ac8cbe00-d838-4c9a-8a35-3dbf31222dc9"> If the base HTTP monitoring endpoint is not enabled, the rest of the HTTP options are disabled: <img width="1328" alt="image" src="https://github.com/user-attachments/assets/2eac787c-3055-4862-b3eb-2566a39ee86c"> The following new fields are added to agent policy schema to support this: ``` monitoring_http monitoring_pprof_enabled monitoring_diagnostics ``` This work supersedes the previous `HTTP monitoring endpoint` options under `Advanced Settings` at the bottom of the page. Any previous configuration under an agent policy's `advanced_settings.agent_monitoring_http` saved object field are migrated over to the new `monitoring_http` field and the old field is deleted. See the migration fn `backfillAgentPolicyToV4`. These new options are compiled to agent yaml like this: ```yml agent: monitoring: enabled: true use_output: default logs: true metrics: true traces: true namespace: default pprof: enabled: true http: enabled: true host: localhost port: 6791 diagnostics: limit: interval: 1m burst: 1 uploader: max_retries: 10 init_dur: 1s max_dur: 10m ``` Summarize your PR. If it involves visual changes include a screenshot or gif. ### To-do - [x] API integration tests - [x] Full manual test of SO migration - [x] Full manual test with agent using these settings ### Checklist Delete any items that are not applicable to this PR. - [x] Any text added follows [EUI's writing guidelines](https://elastic.github.io/eui/#/guidelines/writing), uses sentence case text and includes [i18n support](https://github.com/elastic/kibana/blob/main/packages/kbn-i18n/README.md) - [ ] [Documentation](https://www.elastic.co/guide/en/kibana/master/development-documentation.html) was added for features that require explanation or tutorials - elastic/ingest-docs#1333 - [x] [Unit or functional tests](https://www.elastic.co/guide/en/kibana/master/development-tests.html) were updated or added to match the most common scenarios --------- Co-authored-by: kibanamachine <[email protected]> (cherry picked from commit 87cdc2d)
botelastic
bot
added
the
Team:Fleet
6 tasks
|
Pinging @elastic/fleet (Team:Fleet) |
![github-actions[bot]](https://avatars.githubusercontent.com/in/15368?s=60&v=4){kind=small}
💛 Build succeeded, but was flaky
Failed CI StepsTest Failures
Metrics [docs]Module Count
Public APIs missing comments
Async chunks
Page load bundle
To update your PR or re-run it, just comment with: cc @jen-huang |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Backport
This will backport the following commits from
mainto8.x:Questions ?
Please refer to the Backport tool documentation