Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[8.x] [Inventory][ECO] Create header action menu (#193398) #193624

Merged
merged 1 commit into from
Sep 20, 2024

Conversation

kibanamachine
Copy link
Contributor

Backport

This will backport the following commits from main to 8.x:

Questions ?

Please refer to the Backport tool documentation

closes [elastic#192326](elastic#192326)

## Summary

This PR introduces the "Add data" item to the header menu:

https://github.com/user-attachments/assets/78ea3667-4ef1-4f02-a513-76e7ca896e67

<img width="600" alt="image"
src="https://github.com/user-attachments/assets/afd21f2d-da66-4d10-83c0-29500591cf3c">

>[!NOTE]
>I have refactored` plugin.ts`, moving the `ReactDOM.render` call to
`application.tsx`. I've also created a new component to render the
context providers.
>
>`useKibana` and `InventoryKibanaContext` were simplified.
>
>Besides, the analytics events created for the EEM Service Inventory
'Add data' button were replicated for this button.

### How to test

- Add `xpack.inventory.enabled: true` to kibana.dev.yml
- Start ES and Kibana locally
- Navigate to Observability -> Inventory

---------

Co-authored-by: kibanamachine <[email protected]>
(cherry picked from commit 1a192bc)
@kibana-ci
Copy link
Collaborator

💚 Build Succeeded

Metrics [docs]

Module Count

Fewer modules leads to a faster build time

id before after diff
inventory 128 143 +15

Async chunks

Total size of all lazy-loaded chunks that will be downloaded as the user navigates the app

id before after diff
inventory 51.2KB 59.8KB +8.7KB

Page load bundle

Size of the bundles that are downloaded on every page load. Target size is below 100kb

id before after diff
inventory 14.9KB 9.5KB -5.3KB

To update your PR or re-run it, just comment with:
@elasticmachine merge upstream

cc @crespocarlos

@kibanamachine kibanamachine merged commit 1b846ce into elastic:8.x Sep 20, 2024
27 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backport ci:project-deploy-observability Create an Observability project
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants