Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[ResponseOps] Flaky test x-pack/test/alerting_api_integration/spaces_only/tests/alerting/group2/monitoring·ts #193614

Merged
merged 7 commits into from
Sep 23, 2024

Conversation

doakalexi
Copy link
Contributor

@doakalexi doakalexi commented Sep 20, 2024

Resolves #193072

Summary

Removes the skip on flaky monitoring tests

@doakalexi doakalexi changed the title Unskips the flaky monitor test [ResponseOps] Flaky test x-pack/test/alerting_api_integration/spaces_only/tests/alerting/group2/monitoring·ts Sep 20, 2024
@doakalexi doakalexi added release_note:skip Skip the PR/issue when compiling release notes Team:ResponseOps Label for the ResponseOps team (formerly the Cases and Alerting teams) v8.16.0 v9.0.0 backport:prev-minor Backport to (8.x) the previous minor version (i.e. one version back from main) labels Sep 20, 2024
@kibanamachine
Copy link
Contributor

Flaky Test Runner Stats

🟠 Some tests failed. - kibana-flaky-test-suite-runner#6993

[❌] x-pack/test/alerting_api_integration/spaces_only/tests/alerting/group2/config.ts: 73/100 tests passed.

see run history

@kibanamachine
Copy link
Contributor

Flaky Test Runner Stats

🟠 Some tests failed. - kibana-flaky-test-suite-runner#6992

[❌] x-pack/test/alerting_api_integration/spaces_only/tests/alerting/group2/config.ts: 74/100 tests passed.

see run history

@kibanamachine
Copy link
Contributor

Flaky Test Runner Stats

🟠 Some tests failed. - kibana-flaky-test-suite-runner#6995

[❌] x-pack/test/alerting_api_integration/spaces_only/tests/alerting/group2/config.ts: 64/100 tests passed.

see run history

@kibanamachine
Copy link
Contributor

Flaky Test Runner Stats

🎉 All tests passed! - kibana-flaky-test-suite-runner#6996

[✅] x-pack/test/alerting_api_integration/spaces_only/tests/alerting/group2/config.ts: 50/50 tests passed.

see run history

@kibanamachine
Copy link
Contributor

Flaky Test Runner Stats

🎉 All tests passed! - kibana-flaky-test-suite-runner#6997

[✅] x-pack/test/alerting_api_integration/spaces_only/tests/alerting/group2/config.ts: 200/200 tests passed.

see run history

@doakalexi doakalexi marked this pull request as ready for review September 21, 2024 16:59
@doakalexi doakalexi requested a review from a team as a code owner September 21, 2024 16:59
@elasticmachine
Copy link
Contributor

Pinging @elastic/response-ops (Team:ResponseOps)

Copy link
Contributor

@ymao1 ymao1 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

const ruleId = createResponse.body.id;
objectRemover.add(Spaces.space1.id, ruleId, 'rule', 'alerting');

await waitForExecutionCount(1, ruleId);
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nit: could probably put these in a for loop :)

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

haha that is prob a good idea! Resolved in this commit 2b150c0

@kibana-ci
Copy link
Collaborator

💛 Build succeeded, but was flaky

Failed CI Steps

Metrics [docs]

✅ unchanged

History

To update your PR or re-run it, just comment with:
@elasticmachine merge upstream

@doakalexi doakalexi merged commit cd5ff16 into elastic:main Sep 23, 2024
21 checks passed
kibanamachine pushed a commit to kibanamachine/kibana that referenced this pull request Sep 23, 2024
…only/tests/alerting/group2/monitoring·ts (elastic#193614)

Resolves elastic#193072

## Summary

Removes the skip on flaky monitoring tests

(cherry picked from commit cd5ff16)
@kibanamachine
Copy link
Contributor

💚 All backports created successfully

Status Branch Result
8.x

Note: Successful backport PRs will be merged automatically after passing CI.

Questions ?

Please refer to the Backport tool documentation

kibanamachine added a commit that referenced this pull request Sep 23, 2024
…paces_only/tests/alerting/group2/monitoring·ts (#193614) (#193785)

# Backport

This will backport the following commits from `main` to `8.x`:
- [[ResponseOps] Flaky test
x-pack/test/alerting_api_integration/spaces_only/tests/alerting/group2/monitoring·ts
(#193614)](#193614)

<!--- Backport version: 9.4.3 -->

### Questions ?
Please refer to the [Backport tool
documentation](https://github.com/sqren/backport)

<!--BACKPORT [{"author":{"name":"Alexi
Doak","email":"[email protected]"},"sourceCommit":{"committedDate":"2024-09-23T19:09:40Z","message":"[ResponseOps]
Flaky test
x-pack/test/alerting_api_integration/spaces_only/tests/alerting/group2/monitoring·ts
(#193614)\n\nResolves
https://github.com/elastic/kibana/issues/193072\r\n\r\n##
Summary\r\n\r\nRemoves the skip on flaky monitoring
tests","sha":"cd5ff16dfdbc5ff46199f4ce5785bf52da22fa8a","branchLabelMapping":{"^v9.0.0$":"main","^v8.16.0$":"8.x","^v(\\d+).(\\d+).\\d+$":"$1.$2"}},"sourcePullRequest":{"labels":["release_note:skip","Team:ResponseOps","v9.0.0","backport:prev-minor","v8.16.0"],"title":"[ResponseOps]
Flaky test
x-pack/test/alerting_api_integration/spaces_only/tests/alerting/group2/monitoring·ts","number":193614,"url":"https://github.com/elastic/kibana/pull/193614","mergeCommit":{"message":"[ResponseOps]
Flaky test
x-pack/test/alerting_api_integration/spaces_only/tests/alerting/group2/monitoring·ts
(#193614)\n\nResolves
https://github.com/elastic/kibana/issues/193072\r\n\r\n##
Summary\r\n\r\nRemoves the skip on flaky monitoring
tests","sha":"cd5ff16dfdbc5ff46199f4ce5785bf52da22fa8a"}},"sourceBranch":"main","suggestedTargetBranches":["8.x"],"targetPullRequestStates":[{"branch":"main","label":"v9.0.0","branchLabelMappingKey":"^v9.0.0$","isSourceBranch":true,"state":"MERGED","url":"https://github.com/elastic/kibana/pull/193614","number":193614,"mergeCommit":{"message":"[ResponseOps]
Flaky test
x-pack/test/alerting_api_integration/spaces_only/tests/alerting/group2/monitoring·ts
(#193614)\n\nResolves
https://github.com/elastic/kibana/issues/193072\r\n\r\n##
Summary\r\n\r\nRemoves the skip on flaky monitoring
tests","sha":"cd5ff16dfdbc5ff46199f4ce5785bf52da22fa8a"}},{"branch":"8.x","label":"v8.16.0","branchLabelMappingKey":"^v8.16.0$","isSourceBranch":false,"state":"NOT_CREATED"}]}]
BACKPORT-->

Co-authored-by: Alexi Doak <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backport:prev-minor Backport to (8.x) the previous minor version (i.e. one version back from main) release_note:skip Skip the PR/issue when compiling release notes Team:ResponseOps Label for the ResponseOps team (formerly the Cases and Alerting teams) v8.16.0 v9.0.0
Projects
None yet
5 participants