Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Fleet] allow optional statusCode and error in generic error response schema #193604

Merged
merged 1 commit into from
Sep 20, 2024
Merged

[Fleet] allow optional statusCode and error in generic error response schema #193604

merged 1 commit into from
Sep 20, 2024

Conversation

juliaElastic
Copy link
Contributor

Relates #184685
Make statusCode and error optional in genericErrorResponse, sometimes it seems to be missing.

Saw this screenshot in another issue:
image

@juliaElastic juliaElastic added release_note:skip Skip the PR/issue when compiling release notes backport:skip This commit does not require backporting labels Sep 20, 2024
@juliaElastic juliaElastic self-assigned this Sep 20, 2024
@juliaElastic juliaElastic requested a review from a team as a code owner September 20, 2024 15:13
@botelastic botelastic bot added the Team:Fleet Team label for Observability Data Collection Fleet team label Sep 20, 2024
@elasticmachine
Copy link
Contributor

Pinging @elastic/fleet (Team:Fleet)

@obltmachine
Copy link

🤖 GitHub comments

Expand to view the GitHub comments

Just comment with:

  • /oblt-deploy : Deploy a Kibana instance using the Observability test environments.
  • run docs-build : Re-trigger the docs validation. (use unformatted text in the comment!)

@juliaElastic juliaElastic enabled auto-merge (squash) September 20, 2024 15:15
nchaulet
nchaulet approved these changes Sep 20, 2024
View reviewed changes
Copy link
Member

@nchaulet nchaulet left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

code LGTM 🚀

@juliaElastic juliaElastic merged commit 4437337 into elastic:main Sep 20, 2024
29 checks passed
@kibana-ci
Copy link
Collaborator

💛 Build succeeded, but was flaky

Failed CI Steps

Metrics [docs]

✅ unchanged

To update your PR or re-run it, just comment with:
@elasticmachine merge upstream

cc @juliaElastic

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@nchaulet nchaulet nchaulet approved these changes

Assignees

@juliaElastic juliaElastic

Labels
backport:skip This commit does not require backporting release_note:skip Skip the PR/issue when compiling release notes Team:Fleet Team label for Observability Data Collection Fleet team v9.0.0
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
6 participants
@juliaElastic @elasticmachine @obltmachine @kibana-ci @nchaulet @kibanamachine