[Inventory] Entity names redirect on click to respective pages #193602
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Bluefinger
added
release_note:skip
🤖 GitHub commentsExpand to view the GitHub comments
Just comment with:
|
|
@elasticmachine merge upstream |
|
merge conflict between base and head |
Bluefinger
force-pushed
the
clickable-entity-names
branch
from
542525a to
8cd608f
Compare
|
@elasticmachine merge upstream |
botelastic
bot
added
the
ci:project-deploy-observability
x-pack/plugins/observability_solution/inventory/public/components/entities_grid/index.tsx
Outdated
Show resolved
Hide resolved
kpatticha
reviewed
Sep 26, 2024
x-pack/plugins/observability_solution/inventory/public/components/entities_grid/index.tsx
Outdated
Show resolved
Hide resolved
x-pack/plugins/observability_solution/inventory/public/components/entities_grid/index.tsx
Outdated
Show resolved
Hide resolved
x-pack/plugins/observability_solution/inventory/public/components/entities_grid/index.tsx
Outdated
Show resolved
Hide resolved
cauemarcondes
approved these changes
Sep 27, 2024
x-pack/plugins/observability_solution/inventory/public/components/entities_grid/index.tsx
Outdated
Show resolved
Hide resolved
|
@elasticmachine merge upstream |
💛 Build succeeded, but was flaky
Failed CI StepsTest FailuresMetrics [docs]Module Count
Public APIs missing comments
Async chunks
Page load bundle
History
To update your PR or re-run it, just comment with: |
|
Starting backport for target branches: 8.x |
kibanamachine
pushed a commit
to kibanamachine/kibana
that referenced
this pull request
Sep 27, 2024
…ic#193602) ## Summary Adds the ability to click through to the overview pages for entities on the Entity Name cell for the Entity Grid on the new Inventory page. https://github.com/user-attachments/assets/e712d3ef-370f-4353-a398-2365176eb582 Closes elastic#192676 ### How to test - Go to Inventory Page. - Click on an Entity Name. **Expected**: Should redirect to the overview page of that Entity, regardless it is a `host`, `container`, or `service`. --------- Co-authored-by: Elastic Machine <[email protected]> (cherry picked from commit 9561698)
💚 All backports created successfully
Note: Successful backport PRs will be merged automatically after passing CI. Questions ?Please refer to the Backport tool documentation |
kibanamachine
added a commit
that referenced
this pull request
Sep 27, 2024
…193602) (#194315) # Backport This will backport the following commits from `main` to `8.x`: - [[Inventory] Entity names redirect on click to respective pages (#193602)](#193602) <!--- Backport version: 9.4.3 --> ### Questions ? Please refer to the [Backport tool documentation](https://github.com/sqren/backport) <!--BACKPORT [{"author":{"name":"Gonçalo Rica Pais da Silva","email":"[email protected]"},"sourceCommit":{"committedDate":"2024-09-27T15:23:12Z","message":"[Inventory] Entity names redirect on click to respective pages (#193602)\n\n## Summary\r\n\r\nAdds the ability to click through to the overview pages for entities on\r\nthe Entity Name cell for the Entity Grid on the new Inventory page.\r\n\r\n\r\nhttps://github.com/user-attachments/assets/e712d3ef-370f-4353-a398-2365176eb582\r\n\r\nCloses #192676 \r\n\r\n### How to test\r\n\r\n- Go to Inventory Page.\r\n- Click on an Entity Name.\r\n\r\n**Expected**: Should redirect to the overview page of that Entity,\r\nregardless it is a `host`, `container`, or `service`.\r\n\r\n---------\r\n\r\nCo-authored-by: Elastic Machine <[email protected]>","sha":"9561698109fb8382625a58f43ab9e66fd2a1642a","branchLabelMapping":{"^v9.0.0$":"main","^v8.16.0$":"8.x","^v(\\d+).(\\d+).\\d+$":"$1.$2"}},"sourcePullRequest":{"labels":["release_note:skip","v9.0.0","backport:prev-minor","ci:project-deploy-observability","Team:obs-ux-infra_services","v8.16.0"],"title":"[Inventory] Entity names redirect on click to respective pages","number":193602,"url":"https://github.com/elastic/kibana/pull/193602","mergeCommit":{"message":"[Inventory] Entity names redirect on click to respective pages (#193602)\n\n## Summary\r\n\r\nAdds the ability to click through to the overview pages for entities on\r\nthe Entity Name cell for the Entity Grid on the new Inventory page.\r\n\r\n\r\nhttps://github.com/user-attachments/assets/e712d3ef-370f-4353-a398-2365176eb582\r\n\r\nCloses #192676 \r\n\r\n### How to test\r\n\r\n- Go to Inventory Page.\r\n- Click on an Entity Name.\r\n\r\n**Expected**: Should redirect to the overview page of that Entity,\r\nregardless it is a `host`, `container`, or `service`.\r\n\r\n---------\r\n\r\nCo-authored-by: Elastic Machine <[email protected]>","sha":"9561698109fb8382625a58f43ab9e66fd2a1642a"}},"sourceBranch":"main","suggestedTargetBranches":["8.x"],"targetPullRequestStates":[{"branch":"main","label":"v9.0.0","branchLabelMappingKey":"^v9.0.0$","isSourceBranch":true,"state":"MERGED","url":"https://github.com/elastic/kibana/pull/193602","number":193602,"mergeCommit":{"message":"[Inventory] Entity names redirect on click to respective pages (#193602)\n\n## Summary\r\n\r\nAdds the ability to click through to the overview pages for entities on\r\nthe Entity Name cell for the Entity Grid on the new Inventory page.\r\n\r\n\r\nhttps://github.com/user-attachments/assets/e712d3ef-370f-4353-a398-2365176eb582\r\n\r\nCloses #192676 \r\n\r\n### How to test\r\n\r\n- Go to Inventory Page.\r\n- Click on an Entity Name.\r\n\r\n**Expected**: Should redirect to the overview page of that Entity,\r\nregardless it is a `host`, `container`, or `service`.\r\n\r\n---------\r\n\r\nCo-authored-by: Elastic Machine <[email protected]>","sha":"9561698109fb8382625a58f43ab9e66fd2a1642a"}},{"branch":"8.x","label":"v8.16.0","branchLabelMappingKey":"^v8.16.0$","isSourceBranch":false,"state":"NOT_CREATED"}]}] BACKPORT--> Co-authored-by: Gonçalo Rica Pais da Silva <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Adds the ability to click through to the overview pages for entities on the Entity Name cell for the Entity Grid on the new Inventory page.
Screen.Recording.2024-09-25.165458.mp4
Closes #192676
How to test
Expected: Should redirect to the overview page of that Entity, regardless it is a
host,container, orservice.