Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Inventory][ECO] API error handler #193560

Merged
merged 3 commits into from
Sep 20, 2024
Merged

[Inventory][ECO] API error handler #193560

merged 3 commits into from
Sep 20, 2024

Conversation

cauemarcondes
Copy link
Contributor

@cauemarcondes cauemarcondes commented Sep 20, 2024 •
edited by kibanamachine
Loading

closes #193547

Screenshot 2024-09-20 at 14 14 12

@cauemarcondes cauemarcondes added release_note:skip Skip the PR/issue when compiling release notes backport:prev-minor Backport to (8.x) the previous minor version (i.e. one version back from main) v8.16.0 labels Sep 20, 2024
@cauemarcondes cauemarcondes requested a review from a team as a code owner September 20, 2024 12:40
@botelastic botelastic bot added the ci:project-deploy-observability Create an Observability project label Sep 20, 2024
@obltmachine
Copy link

🤖 GitHub comments

Expand to view the GitHub comments

Just comment with:

  • /oblt-deploy : Deploy a Kibana instance using the Observability test environments.
  • run docs-build : Re-trigger the docs validation. (use unformatted text in the comment!)

@cauemarcondes cauemarcondes enabled auto-merge (squash) September 20, 2024 12:42
@kibana-ci
Copy link
Collaborator

kibana-ci commented Sep 20, 2024 •
edited
Loading

💚 Build Succeeded

  • Buildkite Build
  • Commit: 67f8948
  • Kibana Serverless Image: docker.elastic.co/kibana-ci/kibana-serverless:pr-193560-67f89481389e

Metrics [docs]

Module Count

Fewer modules leads to a faster build time

id before after diff
inventory 127 128 +1

Async chunks

Total size of all lazy-loaded chunks that will be downloaded as the user navigates the app

id before after diff
inventory 50.7KB 51.2KB +495.0B

History

To update your PR or re-run it, just comment with:
@elasticmachine merge upstream

crespocarlos
crespocarlos approved these changes Sep 20, 2024
View reviewed changes
Copy link
Contributor

@crespocarlos crespocarlos left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@cauemarcondes cauemarcondes merged commit 9b4ace8 into elastic:main Sep 20, 2024
23 checks passed
@kibanamachine kibanamachine mentioned this pull request Sep 20, 2024
Merged
kibanamachine pushed a commit to kibanamachine/kibana that referenced this pull request Sep 20, 2024
@cauemarcondes
[Inventory][ECO] API error handler (elastic#193560)
6631845 
closes elastic#193547

<img width="1278" alt="Screenshot 2024-09-20 at 13 32 26"
src="https://github.com/user-attachments/assets/f68a0952-8d1f-4ff6-acf2-ac74982a9680">

(cherry picked from commit 9b4ace8)
@kibanamachine
Copy link
Contributor

💚 All backports created successfully

Status Branch Result
✅ 8.x

Note: Successful backport PRs will be merged automatically after passing CI.

Questions ?

Please refer to the Backport tool documentation

kibanamachine added a commit that referenced this pull request Sep 20, 2024
@kibanamachine @cauemarcondes
[8.x] [Inventory][ECO] API error handler (#193560) (#193606)
90d6f73 
# Backport

This will backport the following commits from `main` to `8.x`:
- [[Inventory][ECO] API error handler
(#193560)](#193560)

<!--- Backport version: 9.4.3 -->

### Questions ?
Please refer to the [Backport tool
documentation](https://github.com/sqren/backport)

<!--BACKPORT [{"author":{"name":"Cauê
Marcondes","email":"[email protected]"},"sourceCommit":{"committedDate":"2024-09-20T15:18:11Z","message":"[Inventory][ECO]
API error handler (#193560)\n\ncloses
https://github.com/elastic/kibana/issues/193547\r\n\r\n<img
width=\"1278\" alt=\"Screenshot 2024-09-20 at 13 32
26\"\r\nsrc=\"https://github.com/user-attachments/assets/f68a0952-8d1f-4ff6-acf2-ac74982a9680\">","sha":"9b4ace8343f15fb73f79d05e0ff7b4212866ebb9","branchLabelMapping":{"^v9.0.0$":"main","^v8.16.0$":"8.x","^v(\\d+).(\\d+).\\d+$":"$1.$2"}},"sourcePullRequest":{"labels":["release_note:skip","v9.0.0","backport:prev-minor","ci:project-deploy-observability","v8.16.0"],"title":"[Inventory][ECO]
API error
handler","number":193560,"url":"https://github.com/elastic/kibana/pull/193560","mergeCommit":{"message":"[Inventory][ECO]
API error handler (#193560)\n\ncloses
https://github.com/elastic/kibana/issues/193547\r\n\r\n<img
width=\"1278\" alt=\"Screenshot 2024-09-20 at 13 32
26\"\r\nsrc=\"https://github.com/user-attachments/assets/f68a0952-8d1f-4ff6-acf2-ac74982a9680\">","sha":"9b4ace8343f15fb73f79d05e0ff7b4212866ebb9"}},"sourceBranch":"main","suggestedTargetBranches":["8.x"],"targetPullRequestStates":[{"branch":"main","label":"v9.0.0","branchLabelMappingKey":"^v9.0.0$","isSourceBranch":true,"state":"MERGED","url":"https://github.com/elastic/kibana/pull/193560","number":193560,"mergeCommit":{"message":"[Inventory][ECO]
API error handler (#193560)\n\ncloses
https://github.com/elastic/kibana/issues/193547\r\n\r\n<img
width=\"1278\" alt=\"Screenshot 2024-09-20 at 13 32
26\"\r\nsrc=\"https://github.com/user-attachments/assets/f68a0952-8d1f-4ff6-acf2-ac74982a9680\">","sha":"9b4ace8343f15fb73f79d05e0ff7b4212866ebb9"}},{"branch":"8.x","label":"v8.16.0","branchLabelMappingKey":"^v8.16.0$","isSourceBranch":false,"state":"NOT_CREATED"}]}]
BACKPORT-->

Co-authored-by: Cauê Marcondes <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@crespocarlos crespocarlos crespocarlos approved these changes

Assignees
No one assigned
Labels
backport:prev-minor Backport to (8.x) the previous minor version (i.e. one version back from main) ci:project-deploy-observability Create an Observability project release_note:skip Skip the PR/issue when compiling release notes v8.16.0 v9.0.0
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[Inventory] API call error handling
5 participants
@cauemarcondes @obltmachine @kibana-ci @kibanamachine @crespocarlos