Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[8.x] [Feature Flags Service] Hello world 👋 (#188562) #193519

Merged
merged 1 commit into from
Sep 20, 2024

Conversation

afharo
Copy link
Member

@afharo afharo commented Sep 20, 2024

Backport

This will backport the following commits from main to 8.x:

Questions ?

Please refer to the Backport tool documentation

Co-authored-by: kibanamachine <[email protected]>
Co-authored-by: Jean-Louis Leysens <[email protected]>
(cherry picked from commit 02ce1b9)

# Conflicts:
#	.github/CODEOWNERS
@afharo afharo enabled auto-merge (squash) September 20, 2024 08:49
@botelastic botelastic bot added the ci:project-deploy-observability Create an Observability project label Sep 20, 2024
Copy link
Contributor

A documentation preview will be available soon.

Request a new doc build by commenting
  • Rebuild this PR: run docs-build
  • Rebuild this PR and all Elastic docs: run docs-build rebuild

run docs-build is much faster than run docs-build rebuild. A rebuild should only be needed in rare situations.

If your PR continues to fail for an unknown reason, the doc build pipeline may be broken. Elastic employees can check the pipeline status here.

@kibana-ci
Copy link
Collaborator

💚 Build Succeeded

Metrics [docs]

Module Count

Fewer modules leads to a faster build time

id before after diff
cloudExperiments 10 13 +3
core 442 447 +5
total +8

Public APIs missing comments

Total count of every public API that lacks a comment. Target amount is 0. Run node scripts/build_api_docs --plugin [yourplugin] --stats comments for more detailed information.

id before after diff
@kbn/core-http-request-handler-context-server 13 0 -13

Async chunks

Total size of all lazy-loaded chunks that will be downloaded as the user navigates the app

id before after diff
cloudExperiments 52.6KB 0.0B -52.6KB
core 65.3KB 60.9KB -4.4KB
total -56.9KB

Page load bundle

Size of the bundles that are downloaded on every page load. Target size is below 100kb

id before after diff
cloudExperiments 7.8KB 92.4KB +84.6KB
core 418.2KB 454.5KB +36.3KB
total +121.0KB
Unknown metric groups

API count

id before after diff
@kbn/core-feature-flags-browser - 29 +29
@kbn/core-feature-flags-browser-internal - 9 +9
@kbn/core-feature-flags-browser-mocks - 4 +4
@kbn/core-feature-flags-server - 38 +38
@kbn/core-feature-flags-server-internal - 11 +11
@kbn/core-feature-flags-server-mocks - 6 +6
@kbn/core-http-request-handler-context-server 16 17 +1
@kbn/core-lifecycle-browser 36 38 +2
@kbn/core-lifecycle-server 40 42 +2
cloudExperiments 12 0 -12
total +90

async chunk count

id before after diff
cloudExperiments 1 0 -1
core 2 1 -1
total -2

ESLint disabled line counts

id before after diff
cloudExperiments 3 2 -1

References to deprecated APIs

id before after diff
cloudChat 4 0 -4
observabilityOnboarding 3 1 -2
securitySolution 472 470 -2
total -8

Total ESLint disabled count

id before after diff
cloudExperiments 3 2 -1

Unreferenced deprecated APIs

id before after diff
cloudExperiments 1 0 -1

To update your PR or re-run it, just comment with:
@elasticmachine merge upstream

@afharo afharo merged commit 71ad243 into elastic:8.x Sep 20, 2024
41 checks passed
@afharo afharo deleted the backport/8.x/pr-188562 branch September 20, 2024 10:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backport ci:project-deploy-observability Create an Observability project
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants