Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Console] Fix editor value resetting at layout change #193516

Merged
merged 8 commits into from
Sep 24, 2024
Merged

[Console] Fix editor value resetting at layout change #193516

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
8 commits
Select commit Hold shift + click to select a range
f152909
[Console] Fix editor value resetting at layout change
ElenaStoeva Sep 18, 2024
89f6f2d
Fix localstorage update
ElenaStoeva Sep 20, 2024
9bf327f
Merge branch 'main' into console/fix-layout-change-rerender
ElenaStoeva Sep 20, 2024
7512ee2
Fix storing to local storage
ElenaStoeva Sep 23, 2024
2d9c008
[CI] Auto-commit changed files from 'node scripts/notice'
kibanamachine Sep 23, 2024
0da3c11
Merge branch 'main' into console/fix-layout-change-rerender
ElenaStoeva Sep 23, 2024
a5722f3
[CI] Auto-commit changed files from 'node scripts/eslint --no-cache -…
kibanamachine Sep 23, 2024
08415c7
[CI] Auto-commit changed files from 'node scripts/notice'
kibanamachine Sep 23, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion src/plugins/console/common/text_object.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -34,5 +34,5 @@ export interface TextObject {
*
* Used to re-populate a text editor buffer.
*/
text: string;
text: string | undefined;
}
14 changes: 9 additions & 5 deletions src/plugins/console/public/application/containers/config/config.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -8,16 +8,20 @@
*/

import React from 'react';
import { EuiFlexGroup, EuiFlexItem, EuiPanel, EuiSpacer } from '@elastic/eui';
import {
EuiFlexGroup,
EuiFlexItem,
EuiPanel,
EuiSpacer,
useIsWithinBreakpoints,
} from '@elastic/eui';

import { Settings } from './settings';
import { Variables } from './variables';

export interface Props {
isVerticalLayout: boolean;
}
export function Config() {
const isVerticalLayout = useIsWithinBreakpoints(['xs', 's', 'm']);

export function Config({ isVerticalLayout }: Props) {
return (
<EuiPanel
color="subdued"
Expand Down
Loading