[8.x] [APM UI] Fix OpenTelemetry agent names (#193134) #193509
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
## Summary Fixes elastic#180444 This PR fixes the agent names not being able to properly be retrieved by the APM UI, changing the way we map OpenTelemetry agent names. As the format changed from `(opentelemetry|otlp)/{agentName}` to `(opentelemetry|otlp)/{agentName}/{details}`, we now get the second part splitting by `/`. Added mappings for RUM, Android, and iOS OpenTelemetry client, also fixed `get_service_metadata_details` to get the correct OpenTelemetry details. |Before|After| |-|-| ||| ## How to test 1. Checkout to this branch 2. Run `node scripts/synthtrace many_otel_services.ts --live --clean` which will fill some APM Otel services. 3. Check that the icon is now rendering (cherry picked from commit 735e216)
botelastic
bot
added
ci:project-deploy-observability
|
Pinging @elastic/obs-ux-infra_services-team (Team:obs-ux-infra_services) |
![github-actions[bot]](https://avatars.githubusercontent.com/in/15368?s=60&v=4){kind=small}
💛 Build succeeded, but was flaky
Failed CI StepsTest Failures
Metrics [docs]Public APIs missing comments
Async chunks
History
To update your PR or re-run it, just comment with: cc @rmyz |
rmyz
referenced
this pull request
Sep 20, 2024
# Backport This will backport the following commits from `main` to `8.15`: - [[APM UI] Fix OpenTelemetry agent names (#193134)](#193134) <!--- Backport version: 8.9.8 --> ### Questions ? Please refer to the [Backport tool documentation](https://github.com/sqren/backport) <!--BACKPORT [{"author":{"name":"Sergi Romeu","email":"[email protected]"},"sourceCommit":{"committedDate":"2024-09-20T07:07:14Z","message":"[APM UI] Fix OpenTelemetry agent names (#193134)\n\n## Summary\r\n\r\nFixes https://github.com/elastic/kibana/issues/180444\r\n\r\nThis PR fixes the agent names not being able to properly be retrieved by\r\nthe APM UI, changing the way we map OpenTelemetry agent names.\r\nAs the format changed from `(opentelemetry|otlp)/{agentName}` to\r\n`(opentelemetry|otlp)/{agentName}/{details}`, we now get the second part\r\nsplitting by `/`.\r\n\r\nAdded mappings for RUM, Android, and iOS OpenTelemetry client, also\r\nfixed `get_service_metadata_details` to get the correct OpenTelemetry\r\ndetails.\r\n\r\n|Before|After|\r\n|-|-|\r\n\r\n|||\r\n\r\n## How to test\r\n1. Checkout to this branch\r\n2. Run `node scripts/synthtrace many_otel_services.ts --live --clean`\r\nwhich will fill some APM Otel services.\r\n3. Check that the icon is now rendering","sha":"735e216a952670eb57eaea1229be16e89f9bf1cd","branchLabelMapping":{"^v9.0.0$":"main","^v8.16.0$":"8.x","^v(\\d+).(\\d+).\\d+$":"$1.$2"}},"sourcePullRequest":{"labels":["release_note:fix","v9.0.0","apm:opentelemetry","backport:prev-major","ci:project-deploy-observability","Team:obs-ux-infra_services","backport:version"],"number":193134,"url":"https://github.com/elastic/kibana/pull/193134","mergeCommit":{"message":"[APM UI] Fix OpenTelemetry agent names (#193134)\n\n## Summary\r\n\r\nFixes https://github.com/elastic/kibana/issues/180444\r\n\r\nThis PR fixes the agent names not being able to properly be retrieved by\r\nthe APM UI, changing the way we map OpenTelemetry agent names.\r\nAs the format changed from `(opentelemetry|otlp)/{agentName}` to\r\n`(opentelemetry|otlp)/{agentName}/{details}`, we now get the second part\r\nsplitting by `/`.\r\n\r\nAdded mappings for RUM, Android, and iOS OpenTelemetry client, also\r\nfixed `get_service_metadata_details` to get the correct OpenTelemetry\r\ndetails.\r\n\r\n|Before|After|\r\n|-|-|\r\n\r\n|||\r\n\r\n## How to test\r\n1. Checkout to this branch\r\n2. Run `node scripts/synthtrace many_otel_services.ts --live --clean`\r\nwhich will fill some APM Otel services.\r\n3. Check that the icon is now rendering","sha":"735e216a952670eb57eaea1229be16e89f9bf1cd"}},"sourceBranch":"main","suggestedTargetBranches":[],"targetPullRequestStates":[{"branch":"main","label":"v9.0.0","labelRegex":"^v9.0.0$","isSourceBranch":true,"state":"MERGED","url":"https://github.com/elastic/kibana/pull/193134","number":193134,"mergeCommit":{"message":"[APM UI] Fix OpenTelemetry agent names (#193134)\n\n## Summary\r\n\r\nFixes https://github.com/elastic/kibana/issues/180444\r\n\r\nThis PR fixes the agent names not being able to properly be retrieved by\r\nthe APM UI, changing the way we map OpenTelemetry agent names.\r\nAs the format changed from `(opentelemetry|otlp)/{agentName}` to\r\n`(opentelemetry|otlp)/{agentName}/{details}`, we now get the second part\r\nsplitting by `/`.\r\n\r\nAdded mappings for RUM, Android, and iOS OpenTelemetry client, also\r\nfixed `get_service_metadata_details` to get the correct OpenTelemetry\r\ndetails.\r\n\r\n|Before|After|\r\n|-|-|\r\n\r\n|||\r\n\r\n## How to test\r\n1. Checkout to this branch\r\n2. Run `node scripts/synthtrace many_otel_services.ts --live --clean`\r\nwhich will fill some APM Otel services.\r\n3. Check that the icon is now rendering","sha":"735e216a952670eb57eaea1229be16e89f9bf1cd"}},{"url":"https://github.com/elastic/kibana/pull/193509","number":193509,"branch":"8.x","state":"OPEN"}]}] BACKPORT-->
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Backport
This will backport the following commits from
mainto8.x:Questions ?
Please refer to the Backport tool documentation