[Advanced Settings] Fix search does not work for terms with ":" #193506
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@elasticmachine merge upstream |
viajes7
changed the title
alisonelizabeth
added
backport:prev-minor
|
/ci |
|
@elasticmachine merge upstream |
|
@elasticmachine merge upstream |
|
@elasticmachine merge upstream |
ElenaStoeva
reviewed
Sep 23, 2024
There was a problem hiding this comment.
Thanks for working on this @viajes7! Tested locally and searching for settings that include : works well now. I have one suggestion regarding the check for the clause.
packages/kbn-management/settings/application/hooks/use_fields.ts
Outdated
Show resolved
Hide resolved
viajes7
force-pushed
the
fix/query_setting_fields
branch
from
0840de1 to
efc4981
Compare
|
@elasticmachine merge upstream |
ElenaStoeva
approved these changes
Sep 24, 2024
ElenaStoeva
added
Feature:Kibana Management
|
Pinging @elastic/kibana-management (Team:Kibana Management) |
|
@ElenaStoeva Hi, I just pushed a commit, use the On the other hand, |
|
/ci |
|
Hey @viajes7, thanks for using the Sure, I commented a prompt to re-run ci, hopefully it will pass this time. |
|
/ci |
💛 Build succeeded, but was flaky
Failed CI StepsTest Failures
Metrics [docs]Async chunks
History
To update your PR or re-run it, just comment with: |
|
@elasticmachine run docs-build |
kibanamachine
pushed a commit
to kibanamachine/kibana
that referenced
this pull request
Sep 25, 2024
…tic#193506) ## Summary Fixes elastic#192694 When terms with `:`, it will be transformed to a `FieldClause`. So, I'm try to set it back to a `TermClause` if the field is not in `FieldDefinition`. Example: `-defaultValue:false doc_table:high Dashboard`  --------- Co-authored-by: Elastic Machine <[email protected]> Co-authored-by: Elena Stoeva <[email protected]> (cherry picked from commit b8398c7)
💚 All backports created successfully
Note: Successful backport PRs will be merged automatically after passing CI. Questions ?Please refer to the Backport tool documentation |
kibanamachine
added a commit
that referenced
this pull request
Sep 25, 2024
…ot;:" (#193506) (#193965) # Backport This will backport the following commits from `main` to `8.x`: - [[Advanced Settings] Fix search does not work for terms with ":" (#193506)](#193506) <!--- Backport version: 9.4.3 --> ### Questions ? Please refer to the [Backport tool documentation](https://github.com/sqren/backport) <!--BACKPORT [{"author":{"name":"Jusheng Huang","email":"[email protected]"},"sourceCommit":{"committedDate":"2024-09-25T10:36:25Z","message":"[Advanced Settings] Fix search does not work for terms with \":\" (#193506)\n\n## Summary\r\n\r\nFixes #192694\r\n\r\nWhen terms with `:`, it will be transformed to a `FieldClause`.\r\n\r\nSo, I'm try to set it back to a `TermClause` if the field is not in\r\n`FieldDefinition`.\r\n\r\nExample: `-defaultValue:false doc_table:high Dashboard`\r\n\r\n\r\n\r\n\r\n---------\r\n\r\nCo-authored-by: Elastic Machine <[email protected]>\r\nCo-authored-by: Elena Stoeva <[email protected]>","sha":"b8398c7b684d9fb4745c0d9d8c5a9c60a5eddc48","branchLabelMapping":{"^v9.0.0$":"main","^v8.16.0$":"8.x","^v(\\d+).(\\d+).\\d+$":"$1.$2"}},"sourcePullRequest":{"labels":["Feature:Kibana Management","Team:Kibana Management","release_note:skip","💝community","v9.0.0","backport:prev-minor","v8.16.0"],"title":"[Advanced Settings] Fix search does not work for terms with \":\"","number":193506,"url":"https://github.com/elastic/kibana/pull/193506","mergeCommit":{"message":"[Advanced Settings] Fix search does not work for terms with \":\" (#193506)\n\n## Summary\r\n\r\nFixes #192694\r\n\r\nWhen terms with `:`, it will be transformed to a `FieldClause`.\r\n\r\nSo, I'm try to set it back to a `TermClause` if the field is not in\r\n`FieldDefinition`.\r\n\r\nExample: `-defaultValue:false doc_table:high Dashboard`\r\n\r\n\r\n\r\n\r\n---------\r\n\r\nCo-authored-by: Elastic Machine <[email protected]>\r\nCo-authored-by: Elena Stoeva <[email protected]>","sha":"b8398c7b684d9fb4745c0d9d8c5a9c60a5eddc48"}},"sourceBranch":"main","suggestedTargetBranches":["8.x"],"targetPullRequestStates":[{"branch":"main","label":"v9.0.0","branchLabelMappingKey":"^v9.0.0$","isSourceBranch":true,"state":"MERGED","url":"https://github.com/elastic/kibana/pull/193506","number":193506,"mergeCommit":{"message":"[Advanced Settings] Fix search does not work for terms with \":\" (#193506)\n\n## Summary\r\n\r\nFixes #192694\r\n\r\nWhen terms with `:`, it will be transformed to a `FieldClause`.\r\n\r\nSo, I'm try to set it back to a `TermClause` if the field is not in\r\n`FieldDefinition`.\r\n\r\nExample: `-defaultValue:false doc_table:high Dashboard`\r\n\r\n\r\n\r\n\r\n---------\r\n\r\nCo-authored-by: Elastic Machine <[email protected]>\r\nCo-authored-by: Elena Stoeva <[email protected]>","sha":"b8398c7b684d9fb4745c0d9d8c5a9c60a5eddc48"}},{"branch":"8.x","label":"v8.16.0","branchLabelMappingKey":"^v8.16.0$","isSourceBranch":false,"state":"NOT_CREATED"}]}] BACKPORT--> Co-authored-by: Jusheng Huang <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Fixes #192694
When terms with
:, it will be transformed to aFieldClause.So, I'm try to set it back to a
TermClauseif the field is not inFieldDefinition.Example:
-defaultValue:false doc_table:high Dashboard