[Onboarding] Expose settings component in index_management to reuse in search_indices #193492
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
saarikabhasi
added
release_note:skip
saarikabhasi
commented
Sep 19, 2024
...n/sections/home/index_list/details_page/withContextComponents/index_mapping_with_context.tsx
Outdated
Show resolved
Hide resolved
saarikabhasi
commented
Sep 19, 2024
x-pack/plugins/search_indices/public/components/indices/details_page.tsx
Show resolved
Hide resolved
saarikabhasi
commented
Sep 19, 2024
x-pack/plugins/search_indices/public/components/indices/details_page.tsx
Show resolved
Hide resolved
saarikabhasi
commented
Sep 19, 2024
x-pack/test_serverless/functional/test_suites/search/search_index_detail.ts
Show resolved
Hide resolved
saarikabhasi
force-pushed
the
onboarding/expose-settings-from-index-management
branch
from
2ad6e5e to
9152451
Compare
saarikabhasi
commented
Sep 19, 2024
.../sections/home/index_list/details_page/with_context_components/index_mappings_embeddable.tsx
Outdated
Show resolved
Hide resolved
Flaky Test Runner Stats🎉 All tests passed! - kibana-flaky-test-suite-runner#6985[✅] x-pack/test_serverless/functional/test_suites/search/config.feature_flags.ts: 25/25 tests passed. |
saarikabhasi
force-pushed
the
onboarding/expose-settings-from-index-management
branch
from
9152451 to
351c515
Compare
…thub.com:saarikabhasi/kibana into onboarding/expose-settings-from-index-management
|
@elasticmachine merge upstream |
joemcelroy
approved these changes
Sep 23, 2024
💛 Build succeeded, but was flaky
Failed CI StepsMetrics [docs]Module Count
Public APIs missing comments
Async chunks
Page load bundle
Unknown metric groupsAPI count
async chunk count
History
To update your PR or re-run it, just comment with: |
ElenaStoeva
approved these changes
Sep 24, 2024
saarikabhasi
deleted the
onboarding/expose-settings-from-index-management
branch
saarikabhasi
restored the
onboarding/expose-settings-from-index-management
branch
kibanamachine
pushed a commit
to kibanamachine/kibana
that referenced
this pull request
Sep 24, 2024
…n search_indices (elastic#193492) ## Summary This PR exposes `index_management` index details [settings component ](https://github.com/elastic/kibana/blob/main/x-pack/plugins/index_management/public/application/sections/home/index_list/details_page/details_page_settings.tsx#L16)during `index_management` plugin start. This would enable `search_indices` plugin to reuse. With this change, in new search index details page user can : - Can View settings - Update settings & save - Reset changes <img width="1719" alt="Screenshot 2024-09-19 at 5 48 28 PM" src="https://github.com/user-attachments/assets/a6179fb6-c180-434e-bdb1-3c784006069f"> **How to test:** 1. Enable searchIndices plugin in `kibana.dev.yml` as this plugin is behind Feature flag ``` xpack.searchIndices.enabled: true ``` 2. [Create new index](https://www.elastic.co/guide/en/elasticsearch/reference/current/indices-create-index.html) 3. Navigate to `/app/elasticsearch/indices/index_details/${indexName}/settings` ### Checklist - [x] Any text added follows [EUI's writing guidelines](https://elastic.github.io/eui/#/guidelines/writing), uses sentence case text and includes [i18n support](https://github.com/elastic/kibana/blob/main/packages/kbn-i18n/README.md) - [x] [Unit or functional tests](https://www.elastic.co/guide/en/kibana/master/development-tests.html) were updated or added to match the most common scenarios - [x] [Flaky Test Runner](https://ci-stats.kibana.dev/trigger_flaky_test_runner/1) was used on any tests changed --------- Co-authored-by: kibanamachine <[email protected]> Co-authored-by: Elastic Machine <[email protected]> (cherry picked from commit d925391)
💚 All backports created successfully
Note: Successful backport PRs will be merged automatically after passing CI. Questions ?Please refer to the Backport tool documentation |
kibanamachine
added a commit
that referenced
this pull request
Sep 24, 2024
…euse in search_indices (#193492) (#193870) # Backport This will backport the following commits from `main` to `8.x`: - [[Onboarding] Expose settings component in index_management to reuse in search_indices (#193492)](#193492) <!--- Backport version: 9.4.3 --> ### Questions ? Please refer to the [Backport tool documentation](https://github.com/sqren/backport) <!--BACKPORT [{"author":{"name":"Saarika Bhasi","email":"[email protected]"},"sourceCommit":{"committedDate":"2024-09-24T13:13:31Z","message":"[Onboarding] Expose settings component in index_management to reuse in search_indices (#193492)\n\n## Summary\r\nThis PR exposes `index_management` index details [settings component\r\n](https://github.com/elastic/kibana/blob/main/x-pack/plugins/index_management/public/application/sections/home/index_list/details_page/details_page_settings.tsx#L16)during\r\n`index_management` plugin start. This would enable `search_indices`\r\nplugin to reuse.\r\n\r\nWith this change, in new search index details page user can :\r\n\r\n- Can View settings \r\n- Update settings & save \r\n- Reset changes\r\n\r\n<img width=\"1719\" alt=\"Screenshot 2024-09-19 at 5 48 28 PM\"\r\nsrc=\"https://github.com/user-attachments/assets/a6179fb6-c180-434e-bdb1-3c784006069f\">\r\n\r\n**How to test:** \r\n1. Enable searchIndices plugin in `kibana.dev.yml` as this plugin is\r\nbehind Feature flag\r\n```\r\nxpack.searchIndices.enabled: true\r\n\r\n```\r\n2. [Create new\r\nindex](https://www.elastic.co/guide/en/elasticsearch/reference/current/indices-create-index.html)\r\n3. Navigate to\r\n`/app/elasticsearch/indices/index_details/${indexName}/settings`\r\n\r\n \r\n\r\n### Checklist\r\n\r\n\r\n- [x] Any text added follows [EUI's writing\r\nguidelines](https://elastic.github.io/eui/#/guidelines/writing), uses\r\nsentence case text and includes [i18n\r\nsupport](https://github.com/elastic/kibana/blob/main/packages/kbn-i18n/README.md)\r\n- [x] [Unit or functional\r\ntests](https://www.elastic.co/guide/en/kibana/master/development-tests.html)\r\nwere updated or added to match the most common scenarios\r\n- [x] [Flaky Test\r\nRunner](https://ci-stats.kibana.dev/trigger_flaky_test_runner/1) was\r\nused on any tests changed\r\n\r\n---------\r\n\r\nCo-authored-by: kibanamachine <[email protected]>\r\nCo-authored-by: Elastic Machine <[email protected]>","sha":"d925391b90d2ed06c3e940d4112baaa634a9182a","branchLabelMapping":{"^v9.0.0$":"main","^v8.16.0$":"8.x","^v(\\d+).(\\d+).\\d+$":"$1.$2"}},"sourcePullRequest":{"labels":["release_note:skip","v9.0.0","Team:Search","backport:prev-minor","v8.16.0"],"title":"[Onboarding] Expose settings component in index_management to reuse in search_indices ","number":193492,"url":"https://github.com/elastic/kibana/pull/193492","mergeCommit":{"message":"[Onboarding] Expose settings component in index_management to reuse in search_indices (#193492)\n\n## Summary\r\nThis PR exposes `index_management` index details [settings component\r\n](https://github.com/elastic/kibana/blob/main/x-pack/plugins/index_management/public/application/sections/home/index_list/details_page/details_page_settings.tsx#L16)during\r\n`index_management` plugin start. This would enable `search_indices`\r\nplugin to reuse.\r\n\r\nWith this change, in new search index details page user can :\r\n\r\n- Can View settings \r\n- Update settings & save \r\n- Reset changes\r\n\r\n<img width=\"1719\" alt=\"Screenshot 2024-09-19 at 5 48 28 PM\"\r\nsrc=\"https://github.com/user-attachments/assets/a6179fb6-c180-434e-bdb1-3c784006069f\">\r\n\r\n**How to test:** \r\n1. Enable searchIndices plugin in `kibana.dev.yml` as this plugin is\r\nbehind Feature flag\r\n```\r\nxpack.searchIndices.enabled: true\r\n\r\n```\r\n2. [Create new\r\nindex](https://www.elastic.co/guide/en/elasticsearch/reference/current/indices-create-index.html)\r\n3. Navigate to\r\n`/app/elasticsearch/indices/index_details/${indexName}/settings`\r\n\r\n \r\n\r\n### Checklist\r\n\r\n\r\n- [x] Any text added follows [EUI's writing\r\nguidelines](https://elastic.github.io/eui/#/guidelines/writing), uses\r\nsentence case text and includes [i18n\r\nsupport](https://github.com/elastic/kibana/blob/main/packages/kbn-i18n/README.md)\r\n- [x] [Unit or functional\r\ntests](https://www.elastic.co/guide/en/kibana/master/development-tests.html)\r\nwere updated or added to match the most common scenarios\r\n- [x] [Flaky Test\r\nRunner](https://ci-stats.kibana.dev/trigger_flaky_test_runner/1) was\r\nused on any tests changed\r\n\r\n---------\r\n\r\nCo-authored-by: kibanamachine <[email protected]>\r\nCo-authored-by: Elastic Machine <[email protected]>","sha":"d925391b90d2ed06c3e940d4112baaa634a9182a"}},"sourceBranch":"main","suggestedTargetBranches":["8.x"],"targetPullRequestStates":[{"branch":"main","label":"v9.0.0","branchLabelMappingKey":"^v9.0.0$","isSourceBranch":true,"state":"MERGED","url":"https://github.com/elastic/kibana/pull/193492","number":193492,"mergeCommit":{"message":"[Onboarding] Expose settings component in index_management to reuse in search_indices (#193492)\n\n## Summary\r\nThis PR exposes `index_management` index details [settings component\r\n](https://github.com/elastic/kibana/blob/main/x-pack/plugins/index_management/public/application/sections/home/index_list/details_page/details_page_settings.tsx#L16)during\r\n`index_management` plugin start. This would enable `search_indices`\r\nplugin to reuse.\r\n\r\nWith this change, in new search index details page user can :\r\n\r\n- Can View settings \r\n- Update settings & save \r\n- Reset changes\r\n\r\n<img width=\"1719\" alt=\"Screenshot 2024-09-19 at 5 48 28 PM\"\r\nsrc=\"https://github.com/user-attachments/assets/a6179fb6-c180-434e-bdb1-3c784006069f\">\r\n\r\n**How to test:** \r\n1. Enable searchIndices plugin in `kibana.dev.yml` as this plugin is\r\nbehind Feature flag\r\n```\r\nxpack.searchIndices.enabled: true\r\n\r\n```\r\n2. [Create new\r\nindex](https://www.elastic.co/guide/en/elasticsearch/reference/current/indices-create-index.html)\r\n3. Navigate to\r\n`/app/elasticsearch/indices/index_details/${indexName}/settings`\r\n\r\n \r\n\r\n### Checklist\r\n\r\n\r\n- [x] Any text added follows [EUI's writing\r\nguidelines](https://elastic.github.io/eui/#/guidelines/writing), uses\r\nsentence case text and includes [i18n\r\nsupport](https://github.com/elastic/kibana/blob/main/packages/kbn-i18n/README.md)\r\n- [x] [Unit or functional\r\ntests](https://www.elastic.co/guide/en/kibana/master/development-tests.html)\r\nwere updated or added to match the most common scenarios\r\n- [x] [Flaky Test\r\nRunner](https://ci-stats.kibana.dev/trigger_flaky_test_runner/1) was\r\nused on any tests changed\r\n\r\n---------\r\n\r\nCo-authored-by: kibanamachine <[email protected]>\r\nCo-authored-by: Elastic Machine <[email protected]>","sha":"d925391b90d2ed06c3e940d4112baaa634a9182a"}},{"branch":"8.x","label":"v8.16.0","branchLabelMappingKey":"^v8.16.0$","isSourceBranch":false,"state":"NOT_CREATED"}]}] BACKPORT--> Co-authored-by: Saarika Bhasi <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
This PR exposes
index_managementindex details settings component duringindex_managementplugin start. This would enablesearch_indicesplugin to reuse.With this change, in new search index details page user can :
How to test:
kibana.dev.ymlas this plugin is behind Feature flag/app/elasticsearch/indices/index_details/${indexName}/settingsChecklist