Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[8.x] chore(tsconfig): uncomment option `moduleDetection` (#191834) #193481

Merged
merged 2 commits into from
Sep 20, 2024
Merged

[8.x] chore(tsconfig): uncomment option `moduleDetection` (#191834) #193481

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
01f25a3
chore(tsconfig): uncomment option `moduleDetection` (#191834)
afharo Sep 19, 2024
56ef9ce
Merge branch '8.x' into backport/8.x/pr-191834
afharo Sep 20, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 0 additions & 3 deletions packages/kbn-optimizer/src/worker/entry_point_creator.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -7,9 +7,6 @@
* License v3.0 only", or the "Server Side Public License, v 1".
*/

// TODO: we should be able to remove this ts-ignore while using isolatedModules
// this is a skip for the errors created when typechecking with isolatedModules
// @ts-ignore
module.exports = function ({
entries,
}: {
Expand Down
4 changes: 0 additions & 4 deletions src/plugins/event_annotation/server/fetch_event_annotations/index.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -9,10 +9,6 @@

// TODO: implement this on the server

// TODO(jbudz): should be removed when upgrading to [email protected]
// this is a skip for the errors created when typechecking with isolatedModules
export {};

// import { StartServicesAccessor } from '@kbn/core/server';
// import { EventAnnotationStartDependencies } from '../plugin';

Expand Down
5 changes: 1 addition & 4 deletions tsconfig.base.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1982,11 +1982,8 @@
"useUnknownInCatchVariables": false,
// enabled to point out not supported features when emitting in an isolated module environment
"isolatedModules": true,
// TODO(jbudz): should be uncommented when upgrading to [email protected]
//
// ensures every non-declaration file is treated as a module
// "moduleDetection": "force",
//
"moduleDetection": "force",
// disabled for better IDE support, enabled when running the type_check script
"composite": false,
// enabled for improved performance
Expand Down
4 changes: 0 additions & 4 deletions x-pack/plugins/cases/server/common/index.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -5,10 +5,6 @@
* 2.0.
*/

// TODO(jbudz): should be removed when upgrading to [email protected]
// this is a skip for the errors created when typechecking with isolatedModules
export {};

// Careful of exporting anything from this file as any file(s) you export here will cause your functions to be exposed as public.
// If you're using functions/types/etc... internally or within integration tests it's best to import directly from their paths
// than expose the functions/types/etc... here. You should _only_ expose functions/types/etc... that need to be shared with other plugins here.
Expand Down
4 changes: 0 additions & 4 deletions ...ns/cross_cluster_replication/public/__jest__/client_integration/mocks/breadcrumbs.mock.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -5,10 +5,6 @@
* 2.0.
*/

// TODO(jbudz): should be removed when upgrading to [email protected]
// this is a skip for the errors created when typechecking with isolatedModules
export {};

jest.mock('../../../app/services/breadcrumbs', () => {
const original = jest.requireActual('../../../app/services/breadcrumbs');

Expand Down
4 changes: 0 additions & 4 deletions ...ross_cluster_replication/public/__jest__/client_integration/mocks/track_ui_metric.mock.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -5,10 +5,6 @@
* 2.0.
*/

// TODO(jbudz): should be removed when upgrading to [email protected]
// this is a skip for the errors created when typechecking with isolatedModules
export {};

jest.mock('../../../app/services/track_ui_metric', () => {
const original = jest.requireActual('../../../app/services/track_ui_metric');

Expand Down
4 changes: 0 additions & 4 deletions ...board_drilldown/components/dashboard_drilldown_config/dashboard_drilldown_config.test.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -5,10 +5,6 @@
* 2.0.
*/

// TODO(jbudz): should be removed when upgrading to [email protected]
// this is a skip for the errors created when typechecking with isolatedModules
export {};

// Need to wait for https://github.com/elastic/eui/pull/3173/
// to unit test this component
// basic interaction is covered in end-to-end tests
Expand Down
4 changes: 0 additions & 4 deletions ...lications/app_search/components/engines/components/tables/__mocks__/engines_logic.mock.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -5,10 +5,6 @@
* 2.0.
*/

// TODO(jbudz): should be removed when upgrading to [email protected]
// this is a skip for the errors created when typechecking with isolatedModules
export {};

jest.mock('../../..', () => ({
EnginesLogic: { actions: { deleteEngine: jest.fn() } },
}));
3 changes: 0 additions & 3 deletions ...ns/fleet/public/components/agent_enrollment_flyout/agent_enrollment_flyout.test.mocks.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -6,9 +6,6 @@
*/

import React from 'react';
// TODO(jbudz): should be removed when upgrading to [email protected]
// this is a skip for the errors created when typechecking with isolatedModules
export {};

jest.mock('../../hooks', () => {
return {
Expand Down
4 changes: 0 additions & 4 deletions x-pack/plugins/index_management/__jest__/client_integration/helpers/mocks.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -5,10 +5,6 @@
* 2.0.
*/

// TODO(jbudz): should be removed when upgrading to [email protected]
// this is a skip for the errors created when typechecking with isolatedModules
export {};

(window as any).Worker = class Worker {
onmessage() {}
postMessage() {}
Expand Down
4 changes: 0 additions & 4 deletions x-pack/plugins/lists/common/index.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -5,10 +5,6 @@
* 2.0.
*/

// TODO(jbudz): should be removed when upgrading to [email protected]
// this is a skip for the errors created when typechecking with isolatedModules
export {};

// Careful of exporting anything from this file as any file(s) you export here will cause your page bundle size to increase.
// If you're using functions/types/etc... internally it's best to import directly from their paths than expose the functions/types/etc... here.
// You should _only_ expose functions/types/etc... that need to be shared with other plugins here.
4 changes: 0 additions & 4 deletions x-pack/plugins/osquery/cypress/plugins/index.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -21,10 +21,6 @@
/**
* @type {Cypress.PluginConfig}
*/
// TODO: we should be able to remove this ts-ignore while using isolatedModules
// this is a skip for the errors created when typechecking with isolatedModules
// eslint-disable-next-line @typescript-eslint/ban-ts-comment
// @ts-ignore
// eslint-disable-next-line @typescript-eslint/no-explicit-any
module.exports = (on: any, config: any) => {
// eslint-disable-next-line @typescript-eslint/no-var-requires
Expand Down
4 changes: 0 additions & 4 deletions x-pack/plugins/rollup/public/test/client_integration/helpers/jest.mocks.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -5,10 +5,6 @@
* 2.0.
*/

// TODO(jbudz): should be removed when upgrading to [email protected]
// this is a skip for the errors created when typechecking with isolatedModules
export {};

jest.mock('lodash', () => ({
...jest.requireActual('lodash'),
debounce: (fn: () => unknown) => fn,
Expand Down
3 changes: 0 additions & 3 deletions x-pack/plugins/security_solution/common/index.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -5,9 +5,6 @@
* 2.0.
*/

// TODO(jbudz): should be removed when upgrading to [email protected]
// this is a skip for the errors created when typechecking with isolatedModules
export {};
export {
APP_UI_ID,
APP_ID,
Expand Down
4 changes: 0 additions & 4 deletions x-pack/plugins/security_solution/public/common/mock/formatted_relative.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -5,10 +5,6 @@
* 2.0.
*/

// TODO(jbudz): should be removed when upgrading to [email protected]
// this is a skip for the errors created when typechecking with isolatedModules
export {};

jest.mock('@kbn/i18n-react', () => {
const { i18n } = jest.requireActual('@kbn/i18n');
i18n.init({ locale: 'en' });
Expand Down
Loading