Use dashboard factory directly instead of pulling from registry #193480
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@elasticmachine merge upstream |
|
merge conflict between base and head |
|
/ci |
|
/ci |
|
/ci |
|
/ci |
nreese
added
Team:Presentation
|
Pinging @elastic/kibana-presentation (Team:Presentation) |
|
@elasticmachine merge upstream |
💚 Build Succeeded
Metrics [docs]Async chunks
Page load bundle
Unknown metric groupsasync chunk count
ESLint disabled line counts
References to deprecated APIs
Total ESLint disabled count
History
|
Heenawter
approved these changes
Oct 9, 2024
|
Starting backport for target branches: 8.x |
kibanamachine
pushed a commit
to kibanamachine/kibana
that referenced
this pull request
Oct 9, 2024
…tic#193480) PR removes dashboard embeddable from embeddable registry. No other application accesses the dashboard embeddable from the embeddable registry so registration is not needed. Plus, once lens embeddable is converted to a react embeddable, then we can remove the legacy embeddable registry prior to refactoring dashboard to not be an embeddable (which will be a large effort and we want to remove the legacy embeddable registry as soon as possible to avoid any one else using it). --------- Co-authored-by: kibanamachine <[email protected]> Co-authored-by: Elastic Machine <[email protected]> (cherry picked from commit 3b6cfb6)
💚 All backports created successfully
Note: Successful backport PRs will be merged automatically after passing CI. Questions ?Please refer to the Backport tool documentation |
kibanamachine
added a commit
that referenced
this pull request
Oct 9, 2024
…#193480) (#195615) # Backport This will backport the following commits from `main` to `8.x`: - [Use dashboard factory directly instead of pulling from registry (#193480)](#193480) <!--- Backport version: 9.4.3 --> ### Questions ? Please refer to the [Backport tool documentation](https://github.com/sqren/backport) <!--BACKPORT [{"author":{"name":"Nathan Reese","email":"[email protected]"},"sourceCommit":{"committedDate":"2024-10-09T14:26:43Z","message":"Use dashboard factory directly instead of pulling from registry (#193480)\n\nPR removes dashboard embeddable from embeddable registry. No other\r\napplication accesses the dashboard embeddable from the embeddable\r\nregistry so registration is not needed. Plus, once lens embeddable is\r\nconverted to a react embeddable, then we can remove the legacy\r\nembeddable registry prior to refactoring dashboard to not be an\r\nembeddable (which will be a large effort and we want to remove the\r\nlegacy embeddable registry as soon as possible to avoid any one else\r\nusing it).\r\n\r\n---------\r\n\r\nCo-authored-by: kibanamachine <[email protected]>\r\nCo-authored-by: Elastic Machine <[email protected]>","sha":"3b6cfb685d29e5db8c66c4239e709485a81d0db0","branchLabelMapping":{"^v9.0.0$":"main","^v8.16.0$":"8.x","^v(\\d+).(\\d+).\\d+$":"$1.$2"}},"sourcePullRequest":{"labels":["Team:Presentation","release_note:skip","v9.0.0","project:embeddableRebuild","v8.16.0","backport:version"],"title":"Use dashboard factory directly instead of pulling from registry","number":193480,"url":"https://github.com/elastic/kibana/pull/193480","mergeCommit":{"message":"Use dashboard factory directly instead of pulling from registry (#193480)\n\nPR removes dashboard embeddable from embeddable registry. No other\r\napplication accesses the dashboard embeddable from the embeddable\r\nregistry so registration is not needed. Plus, once lens embeddable is\r\nconverted to a react embeddable, then we can remove the legacy\r\nembeddable registry prior to refactoring dashboard to not be an\r\nembeddable (which will be a large effort and we want to remove the\r\nlegacy embeddable registry as soon as possible to avoid any one else\r\nusing it).\r\n\r\n---------\r\n\r\nCo-authored-by: kibanamachine <[email protected]>\r\nCo-authored-by: Elastic Machine <[email protected]>","sha":"3b6cfb685d29e5db8c66c4239e709485a81d0db0"}},"sourceBranch":"main","suggestedTargetBranches":["8.x"],"targetPullRequestStates":[{"branch":"main","label":"v9.0.0","branchLabelMappingKey":"^v9.0.0$","isSourceBranch":true,"state":"MERGED","url":"https://github.com/elastic/kibana/pull/193480","number":193480,"mergeCommit":{"message":"Use dashboard factory directly instead of pulling from registry (#193480)\n\nPR removes dashboard embeddable from embeddable registry. No other\r\napplication accesses the dashboard embeddable from the embeddable\r\nregistry so registration is not needed. Plus, once lens embeddable is\r\nconverted to a react embeddable, then we can remove the legacy\r\nembeddable registry prior to refactoring dashboard to not be an\r\nembeddable (which will be a large effort and we want to remove the\r\nlegacy embeddable registry as soon as possible to avoid any one else\r\nusing it).\r\n\r\n---------\r\n\r\nCo-authored-by: kibanamachine <[email protected]>\r\nCo-authored-by: Elastic Machine <[email protected]>","sha":"3b6cfb685d29e5db8c66c4239e709485a81d0db0"}},{"branch":"8.x","label":"v8.16.0","branchLabelMappingKey":"^v8.16.0$","isSourceBranch":false,"state":"NOT_CREATED"}]}] BACKPORT--> Co-authored-by: Nathan Reese <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR removes dashboard embeddable from embeddable registry. No other application accesses the dashboard embeddable from the embeddable registry so registration is not needed. Plus, once lens embeddable is converted to a react embeddable, then we can remove the legacy embeddable registry prior to refactoring dashboard to not be an embeddable (which will be a large effort and we want to remove the legacy embeddable registry as soon as possible to avoid any one else using it).