[Security Solution][Rules Management] Fix importing rules with connectors from one space to another

[marshallmain]

Summary

Fixes a bug where importing a rule fails with a connector into a space where (1) the connector already exists, and (2) the existing connector was exported and re-imported from another space. The import logic in this scenario effectively tries to convert the action ID on the rule import twice. The second conversion attempt tries to use the old action ID to look up the correct new action ID in a map, however, in this test scenario the action ID has already been updated by legacy SO ID migration logic and there is no map entry with the new ID as a key. The result is that the second attempt sets the action ID to undefined, resulting in an import failure.

Repro Steps

0. Download the export file below and change the extension back to .ndjson from .json (github does not allow .ndjson files
   rules_export.json
1. Import the rule and connector into a space (default is fine)
2. Create a new space
3. Import the rule and connector into the new space
4. Import the rule and connector into the new space again, but check the Overwrite existing connectors with conflicting action "id" box. Observe the failure.

Integration test forthcoming

[elasticmachine]

🤖 Jobs for this PR can be triggered through checkboxes. 🚧

ℹ️ To trigger the CI, please tick the checkbox below 👇

• Click to trigger kibana-pull-request for this PR!

[kibana-ci]

💔 Build Failed

• Buildkite Build
• Commit: ac11afd
• Interpreting CI Failures

Failed CI Steps

• Jest Tests #2
• Jest Tests #2
• FTR Configs #104
• FTR Configs #104

Test Failures

• [job] [logs] Jest Tests #2 / importRuleActionConnectors should import multiple rules with connectors successfully even if they were exported from different namespaces by generating destinationIds and replace the old actionIds with them
• [job] [logs] Jest Tests #2 / importRuleActionConnectors should import multiple rules with connectors successfully even if they were exported from different namespaces by generating destinationIds and replace the old actionIds with them
• [job] [logs] Jest Tests #2 / importRuleActionConnectors should import one rule with connector successfully even if it was exported from different namespaces by generating destinationId and replace the old actionId with it
• [job] [logs] Jest Tests #2 / importRuleActionConnectors should import one rule with connector successfully even if it was exported from different namespaces by generating destinationId and replace the old actionId with it
• [job] [logs] FTR Configs #104 / Rules Management - Rule import export API @ess @serverless @skipInServerlessMKI import_rules importing rules with an index @skipInServerless migrate pre-8.0 action connector ids should be imported into the non-default space importing a non-default-space 7.16 rule with a connector made in the non-default space should result in a 200
• [job] [logs] FTR Configs #104 / Rules Management - Rule import export API @ess @serverless @skipInServerlessMKI import_rules importing rules with an index @skipInServerless migrate pre-8.0 action connector ids should be imported into the non-default space importing a non-default-space 7.16 rule with a connector made in the non-default space should result in a 200

Metrics [docs]

✅ unchanged

History

To update your PR or re-run it, just comment with:
@elasticmachine merge upstream