Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[8.x] [Dataset quality] remove usage of dataStreamStats API in serverless (#192839) #193468

Merged
merged 2 commits into from
Sep 20, 2024

Conversation

kibanamachine
Copy link
Contributor

Backport

This will backport the following commits from main to 8.x:

Questions ?

Please refer to the Backport tool documentation

…lastic#192839)

Closes elastic#192166.

This PR aims to remove the usage of `DataStreamStats` API in serverless.
Aditionally we now make use of the new verbose mode for `DataStream` API
which allow us to still show the `lastActivity` for serverless projects.
The change was implemented for both flavours.

Visually it won't represent any changes at the moment, but here are the
two flavours still working as before

https://github.com/user-attachments/assets/18cc9b14-24f1-438a-ac07-565c3e728991
(cherry picked from commit 444f95e)
@yngrdyn
Copy link
Contributor

yngrdyn commented Sep 20, 2024

@elasticmachine merge upstream

@kibana-ci
Copy link
Collaborator

kibana-ci commented Sep 20, 2024

💛 Build succeeded, but was flaky

  • Buildkite Build
  • Commit: 3f81736
  • Kibana Serverless Image: docker.elastic.co/kibana-ci/kibana-serverless:pr-193468-3f81736b38dd

Failed CI Steps

Test Failures

  • [job] [logs] FTR Configs #34 / dashboard app - group 4 dashboard empty state adds a new data view when no data views

Metrics [docs]

Async chunks

Total size of all lazy-loaded chunks that will be downloaded as the user navigates the app

id before after diff
datasetQuality 208.7KB 208.5KB -237.0B

History

To update your PR or re-run it, just comment with:
@elasticmachine merge upstream

cc @yngrdyn

@kibanamachine kibanamachine merged commit b8b72be into elastic:8.x Sep 20, 2024
30 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backport ci:project-deploy-observability Create an Observability project
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants